Makes sense.
Thanks,
Hari
On Tue, Nov 11, 2014 at 9:51 PM, Ashish wrote:
> That's what I had in mind, just need to figure out how to do it with
> CodaHale. Want to avoid CodaHale MetricRegistry class floating around
> in code. 1st step would be to migrate to CodaHale, I am yet to figure
> out
That's what I had in mind, just need to figure out how to do it with
CodaHale. Want to avoid CodaHale MetricRegistry class floating around
in code. 1st step would be to migrate to CodaHale, I am yet to figure
out how managing the Reporter part. Let me try to put a patch
together.
On Wed, Nov 12, 2
Currently the metrics exposed via Sources/sinks/channels are hardcoded. We
could add a method to add custom metrics (I think it is already there in
MonitoredCounterGroup, just not in the *Counter classes).
Thanks,
Hari
On Tue, Nov 11, 2014 at 6:34 PM, Ashish wrote:
> I was just playing aroun
I was just playing around so piggy-backed it. The changes have to be
within MonitoredCounterGroup and its sub-classes, as its used across
the implementations. Let me raise a JIRA for this.
One thing that I would like to have in future is to allow
Sinks/Channels/Sources to be able to have custom co
I think it is best to replace the current system rather than having multiple
metrics systems. We should implement it such that it is transparent to user
code, and the changes only go into MonitoredCounterGroup (the CounterGroup
class is obsolete - dont bother).
Thanks,
Hari
On Mon, Nov 10, 20
Codahale does have lot more features like the rate/sec one, which is
most needed metrics. It provides a lot of reporters out of box
(Nagios, HTTP, Ganglia, Graphite, Console etc) so we just need to
enable it, rather than writing custom components.
As of now we have to hide it within MonitoredCount
Is it easier to use than the current one and/or does it give better
performance? You’d need to support the current metrics API
(MonitoredCounterGroup, SourceCounter, SinkCounter, ChannelCounter etc).
Thanks,
Hari
On Sat, Nov 8, 2014 at 8:21 PM, Ashish wrote:
> Hi,
> Have hacked a bit into ou
