> patches for whitespace cleanup
> --
>
> Key: FOR-645
> URL: http://issues.apache.org/jira/browse/FOR-645
> Project: Forrest
> Type: Sub-task
> Components: Other
> Versions: 0.8-dev
> Reporter: Davi
Of course many many thanks to Richard for the enhancement
of the forrestbot docs.
However this patch demonstrates the problems with whitespace
changes. We have no idea what the actual changes were.
For example, perhaps the author removed a section by accident.
So what are we going to do about thi
[ http://issues.apache.org/jira/browse/FOR-645?page=all ]
Tim Williams updated FOR-645:
-
Component: Other
> patches for whitespace cleanup
> --
>
> Key: FOR-645
> URL: http://issues.apache.org/
[ http://issues.apache.org/jira/browse/FOR-644?page=all ]
Tim Williams updated FOR-644:
-
Component: Other
> whitespace cleanup
> --
>
> Key: FOR-644
> URL: http://issues.apache.org/jira/browse/FOR-644
David Crossley wrote:
Addi wrote:
I went ahead and cleaned the test files with my editor. How would you
like to check/compare them to your editor to make sure we are on the
same page?
I tried doing a reformat using IDEA and it was too zealous.
It could be configured to be more minim
Addi wrote:
>
> I went ahead and cleaned the test files with my editor. How would you
> like to check/compare them to your editor to make sure we are on the
> same page?
I tried doing a reformat using IDEA and it was too zealous.
It could be configured to be more minimal, but i bet that
it woul
Diwaker Gupta wrote:
> > Jalopy was mentioned during that big cocoon-dev thread.
> > Follow the links from http://issues.apache.org/jira/browse/FOR-644
> >
> > For some reason, we decided not to use it. Perhaps because
> > periodic cleanups can still cause havoc for people who
> > are working on t
addi wrote:
> David Crossley wrote:
> >
> > Did you use the UNIX command 'tree' or create it manually?
> > The former i hope.
>
> No, I did it manually. Everything that I know about computers has been
> self-taught so unfortunately I have huge gaps in my knowledge. I end up
> being a big Rube q
[ http://issues.apache.org/jira/browse/FOR-646?page=all ]
David Crossley closed FOR-646:
--
Resolution: Fixed
applied thanks.
> Corrected whitespace cleanup dir tree
> -
>
> Key: FOR-646
>
David Crossley wrote:
Addi wrote:
David Crossley wrote:
I suggest that we do a test of one quiet directory,
to ensure that our various text editors do the job
consistently.
Agreed. Not much point to cleaning up if we have to clean up afterwards
because someone's editor was out
[ http://issues.apache.org/jira/browse/FOR-646?page=all ]
Addison Berry updated FOR-646:
--
Attachment: whitespace-cleanup.txt.diff
Cleaned it up using tree command...
> Corrected whitespace cleanup dir t
Corrected whitespace cleanup dir tree
-
Key: FOR-646
URL: http://issues.apache.org/jira/browse/FOR-646
Project: Forrest
Type: Task
Components: Other
Versions: 0.8-dev
Reporter: Addison Berry
Priority: Trivial
> Jalopy was mentioned during that big cocoon-dev thread.
> Follow the links from http://issues.apache.org/jira/browse/FOR-644
>
> For some reason, we decided not to use it. Perhaps because
> periodic cleanups can still cause havoc for people who
> are working on those files. A lot of Cocoon peopl
On Tuesday August 23 2005 10:58 pm, David Crossley wrote:
> Addi wrote:
> > David Crossley wrote:
> > >We could add a list of all directories to a file in the
> > >"etc" directory. You can still see remnants of previous
> > >half-finished jobs there. That list could provide notice
> > >of which sec
Addi wrote:
> David Crossley wrote:
> >
> >I suggest that we do a test of one quiet directory,
> >to ensure that our various text editors do the job
> >consistently.
>
> Agreed. Not much point to cleaning up if we have to clean up afterwards
> because someone's editor was out of line.
I added so
Diwaker Gupta wrote:
> Can we use something like Jalopy (http://jalopy.sf.net) to periodically clean
> up all the Java files? It doesn't need to be a Forrest. One of us can run it
> through once in a while (I'm happy to volunteer). I've used Jalopy in the
> past -- it works really well, its high
airly quickly.
> > --tim
> >
> > > Author: twilliams
> > > Date: Tue Aug 23 19:41:53 2005
> > > New Revision: 239511
> > >
> > > URL: http://svn.apache.org/viewcvs?rev=239511&view=rev
> > > Log:
> > > whitespace cleanu
o one
> else is touching the files I am so if this works, I could go ahead and
> fix them all fairly quickly.
> --tim
>
> > Author: twilliams
> > Date: Tue Aug 23 19:41:53 2005
> > New Revision: 239511
> >
> > URL: http://svn.apache.org/viewcvs?rev=23951
Addi wrote:
> David Crossley wrote:
>
> >We could add a list of all directories to a file in the
> >"etc" directory. You can still see remnants of previous
> >half-finished jobs there. That list could provide notice
> >of which sections have been done and which are next.
>
> OK, I found those and
patches for whitespace cleanup
--
Key: FOR-645
URL: http://issues.apache.org/jira/browse/FOR-645
Project: Forrest
Type: Sub-task
Versions: 0.8-dev
Reporter: David Crossley
Fix For: 0.8-dev
Use this issue to provide
whitespace cleanup
--
Key: FOR-644
URL: http://issues.apache.org/jira/browse/FOR-644
Project: Forrest
Type: Task
Versions: 0.8-dev
Reporter: David Crossley
Fix For: 0.8-dev
We have much inconsistent whitespace in all of our files
[ http://issues.apache.org/jira/browse/FOR-643?page=all ]
David Crossley closed FOR-643:
--
Fix Version: 0.8-dev
Resolution: Fixed
Patch applied thanks.
> Whitespace cleanup dir tree
> ---
>
>
David Crossley wrote:
... snip ...
We need to properly define what our whitespace treatment is
for each class of file-type: *.java and *.x* and *.txt etc.
I started that in docs_0_80/howto/howto-dev.xml and linked
to Cocoon's decision. We could adopt the same.
I agree with that. It seems
[ http://issues.apache.org/jira/browse/FOR-643?page=all ]
Addison Berry updated FOR-643:
--
Attachment: whitespace-cleanup.txt
Attached a new dir tree for the whitespace cleanup.
> Whitespace cleanup dir tree
> ---
>
>
Whitespace cleanup dir tree
---
Key: FOR-643
URL: http://issues.apache.org/jira/browse/FOR-643
Project: Forrest
Type: Task
Components: Other
Versions: 0.8-dev
Reporter: Addison Berry
Priority: Minor
We will use a text
Addi wrote:
>
> I am willing to help with the cleanup. I don't know what the best way
> to organize and execute is though. Could I just post to the list that I
> am cleaning "xyz" dir today and please don't do any commits.
It is more than just no commits. Also needs no "developers"
to be doing
David Crossley wrote:
>
> The dos2unix stuff is discussed:
> http://cocoon.apache.org/community/committer.html
> http://www.apache.org/dev/version-control.html#https-svn
> http://svnbook.red-bean.com/en/1.0/ch07s02.html (svn:eol-style)
And http://marc.theaimsgroup.com/?l=forrest-dev&m=11247691051
are thinking in terms of
cleaning process, but let me know what I can do to help.
- Addi
There was a huge discussion at Cocoon:
Re: whitespace cleanup and efficiency drive
http://marc.theaimsgroup.com/?t=10684399772
The dos2unix stuff is discussed:
http://cocoon.apache.org/comm
s when the devloper contributes a patch.
We need to gradually cleanup the whitespace inconsistencies in our
SVN first, then people can do auto-formatting properly.
There was a huge discussion at Cocoon:
Re: whitespace cleanup and efficiency drive
http://marc.theaimsgroup.com/?t=1068439977
29 matches
Mail list logo
