[GitHub] incubator-gearpump pull request #186: [GEARPUMP-316] Decouple groupBy from w...

2017-06-06 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/186#discussion_r120526897 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/api/WindowFunction.scala --- @@ -32,35 +32,34 @@ object WindowFunct

[GitHub] incubator-gearpump issue #186: [GEARPUMP-316] Decouple groupBy from window

2017-06-06 Thread huafengw
Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/186 First I got an irrelevant comment, there is a `org.apache.gearpump.streaming.dsl.partitioner.GroupByPartitioner`, which looks like in a wrong place. --- If your project is set up for i

[GitHub] incubator-gearpump issue #186: [GEARPUMP-316] Decouple groupBy from window

2017-06-06 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/incubator-gearpump/pull/186 # [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/186?src=pr&el=h1) Report > Merging [#186](https://codecov.io/gh/apache/incubator-gearpump/pull/186?src=pr&el=desc)

[GitHub] incubator-gearpump pull request #186: [GEARPUMP-316] Decouple groupBy from w...

2017-06-06 Thread huafengw
Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/186#discussion_r120526614 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/task/GroupByTask.scala --- @@ -0,0 +1,72 @@ +/* + * Licensed to th

[jira] [Commented] (GEARPUMP-316) Don't enforce groupBy after window

2017-06-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEARPUMP-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040086#comment-16040086 ] ASF GitHub Bot commented on GEARPUMP-316: - Github user huafengw commented on a d

[jira] [Commented] (GEARPUMP-316) Don't enforce groupBy after window

2017-06-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEARPUMP-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040082#comment-16040082 ] ASF GitHub Bot commented on GEARPUMP-316: - Github user huafengw commented on a d

[jira] [Commented] (GEARPUMP-316) Don't enforce groupBy after window

2017-06-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEARPUMP-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040076#comment-16040076 ] ASF GitHub Bot commented on GEARPUMP-316: - Github user huafengw commented on the

[jira] [Commented] (GEARPUMP-316) Don't enforce groupBy after window

2017-06-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEARPUMP-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040028#comment-16040028 ] ASF GitHub Bot commented on GEARPUMP-316: - Github user codecov-io commented on t

Re: Podling Report Reminder - June 2017

2017-06-06 Thread Manu Zhang
Hi Andy, Updated below. Yes, #3 is not necessary for graduation. Although we've made several releases but each had taken more than 3 months. We need to release more frequently (#1) and the real issue blocking graduation, IMHO, is #2 and the updated #3. I don't feel confident for graduation unless

Podling Report Reminder - June 2017

2017-06-06 Thread johndament
Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 21 June 2017, 10:30 am PDT. The report for your podling will form a

Re: Podling Report Reminder - June 2017

2017-06-06 Thread Andrew Purtell
lgtm Question: > 1. Make initial Apache branded release and release on a regular schedule. ​Want to update this? You've made a couple of releases. Have you considered how far along to graduation you think you are? Are the technical requirements in your item #3 necessary for graduation? Why? Isn

[GitHub] incubator-gearpump pull request #186: [GEARPUMP-316] Decouple groupBy from w...

2017-06-06 Thread manuzhang
GitHub user manuzhang opened a pull request: https://github.com/apache/incubator-gearpump/pull/186 [GEARPUMP-316] Decouple groupBy from window Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the commit mess

[jira] [Commented] (GEARPUMP-316) Don't enforce groupBy after window

2017-06-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEARPUMP-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039095#comment-16039095 ] ASF GitHub Bot commented on GEARPUMP-316: - GitHub user manuzhang opened a pull r