Build failed in Jenkins: Geode-nightly #875

2017-06-23 Thread Apache Jenkins Server
See Changes: [klund] GEODE-3062: create new SecurityService after receiving cluster config [bschuchardt] GEODE-3052 Restarting 2 locators together causes potential locator split ---

Re: Review Request 60394: GEODE-3075 and GEODE-2995: merge of new protobuf protocol work.

2017-06-23 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60394/#review178829 --- Ship it! Ship It! - Udo Kohlmeyer On June 23, 2017, 5:52 p.m

[GitHub] geode-native pull request #103: GEODE-2525: Removes MersenneTwister sources.

2017-06-23 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/103#discussion_r123866557 --- Diff: src/tests/cpp/fwklib/GsRandom.cpp --- @@ -18,60 +18,16 @@ #include "GsRandom.hpp" #include -#include -#incl

[GitHub] geode-native pull request #103: GEODE-2525: Removes MersenneTwister sources.

2017-06-23 Thread dgkimura
Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/103#discussion_r123862142 --- Diff: src/tests/cpp/fwklib/GsRandom.cpp --- @@ -18,60 +18,16 @@ #include "GsRandom.hpp" #include -#include -#include

[GitHub] geode pull request #599: GEODE-2819 Document http status code 414 for PUT

2017-06-23 Thread karensmolermiller
GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode/pull/599 GEODE-2819 Document http status code 414 for PUT - Include that 2000-byte size limits should work for most components. @jinmeiliao @kirklund @joeymcallister @davebarnes97 and al

Re: release 1.2

2017-06-23 Thread Bruce Schuchardt
There is a backward-compatibility problem that we need to address before the release can go out. It prevents the subscription queues in a 1.2 server from draining if the subscribed client is running an old version. Barry and I are both working on this issue. See https://issues.apache.org/jir

[GitHub] geode-native pull request #103: GEODE-2525: Removes MersenneTwister sources.

2017-06-23 Thread pivotal-jbarrett
GitHub user pivotal-jbarrett opened a pull request: https://github.com/apache/geode-native/pull/103 GEODE-2525: Removes MersenneTwister sources. Can I get a quick review before I merge. You can merge this pull request into a Git repository by running: $ git pull https://github.

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied
Github user PurelyApplied closed the pull request at: https://github.com/apache/geode/pull/596 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] geode issue #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread jaredjstewart
Github user jaredjstewart commented on the issue: https://github.com/apache/geode/pull/596 Merged as 451d12e --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #594 was SUCCESSFUL (with 1868 tests)

2017-06-23 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #594 was successful. --- Scheduled 1870 tests in total. https://build.spring.io/browse/SGF-NAG-594/ -- This

[GitHub] geode issue #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied
Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/596 Excepting one flaky test, precheckin is green through `14298a`. Precheckin is currently very unhappy, though, and starting new test runs is not going well. --- If your project is set up for it

[GitHub] geode pull request #591: GEODE-3073: Renamed OrderByComparatorUnmapped to Or...

2017-06-23 Thread YehEmily
Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/591#discussion_r123854670 --- Diff: geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledSelect.java --- @@ -925,79 +917,89 @@ private SelectResults applyProjectio

[GitHub] geode issue #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread jaredjstewart
Github user jaredjstewart commented on the issue: https://github.com/apache/geode/pull/596 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

Re: Review Request 60394: GEODE-3075 and GEODE-2995: merge of new protobuf protocol work.

2017-06-23 Thread Hitesh Khamesra
> On June 23, 2017, 6:38 p.m., Udo Kohlmeyer wrote: > > Will fix this latter on. But merging the code now. - Hitesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60394/#review178803 ---

[GitHub] geode pull request #589: GEODE-393: Providing cache for FunctionContext

2017-06-23 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/589#discussion_r123845237 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java --- @@ -37,20 +38,25 @@ private String fu

Re: Review Request 60348: GEODE-3103: GfshRule no longer clutters output

2017-06-23 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60348/#review178811 --- Ship it! LGTM geode-assembly/src/test/java/org/apache/geode/t

Re: Review Request 60348: GEODE-3103: GfshRule no longer clutters output

2017-06-23 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60348/#review178810 --- Ship it! Ship It! - Emily Yeh On June 23, 2017, 6:01 p.m., J

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123832520 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java --- @@ -109,12 +107,10 @@ public Result listCl

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123832527 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java --- @@ -130,31 +125,8 @@ public Result execu

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123830383 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/beans/MemberMBean.java --- @@ -148,7 +148,12 @@ public long getInitialImageTime

[GitHub] geode pull request #589: GEODE-393: Providing cache for FunctionContext

2017-06-23 Thread jhuynh1
Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/589#discussion_r123830138 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java --- @@ -37,20 +38,25 @@ private String funct

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread PurelyApplied
Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123829882 --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java --- @@ -57,7 +56,48 @@ public vo

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123822645 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java --- @@ -130,31 +125,8 @@ public Result execu

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123820699 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java --- @@ -109,12 +107,10 @@ public Result listCl

Re: Review Request 60348: GEODE-3103: GfshRule no longer clutters output

2017-06-23 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60348/#review178805 --- Ship it! Ship It! - Jinmei Liao On June 23, 2017, 6:01 p.m.,

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123819260 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/beans/MemberMBean.java --- @@ -148,7 +148,12 @@ public long getInitialImageTime

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123818520 --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java --- @@ -57,7 +56,48 @@ public vo

[GitHub] geode pull request #589: GEODE-393: Providing cache for FunctionContext

2017-06-23 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/589#discussion_r123818259 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionContextImpl.java --- @@ -37,20 +38,25 @@ private String fu

Re: Review Request 60394: GEODE-3075 and GEODE-2995: merge of new protobuf protocol work.

2017-06-23 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60394/#review178803 --- geode-core/src/main/java/org/apache/geode/internal/cache/tier/soc

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123817037 --- Diff: geode-core/src/main/java/org/apache/geode/management/CacheServerMXBean.java --- @@ -60,48 +61,48 @@ /** * Returns the port on w

[GitHub] geode pull request #596: GEODE-2920 - GEODE-2925: Finer Grained Security

2017-06-23 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/596#discussion_r123815346 --- Diff: geode-core/src/main/java/org/apache/geode/management/CacheServerMXBean.java --- @@ -60,48 +61,48 @@ /** * Returns the port on w

Re: Review Request 60348: GEODE-3103: GfshRule no longer clutters output

2017-06-23 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60348/ --- (Updated June 23, 2017, 6:01 p.m.) Review request for geode, Emily Yeh, Jared S

Re: Review Request 60394: GEODE-3075 and GEODE-2995: merge of new protobuf protocol work.

2017-06-23 Thread Galen O'Sullivan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60394/ --- (Updated June 23, 2017, 5:52 p.m.) Review request for geode, Alexander Murmann,

Re: Review Request 60394: GEODE-3075 and GEODE-2995: merge of new protobuf protocol work.

2017-06-23 Thread Galen O'Sullivan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60394/ --- (Updated June 23, 2017, 5:50 p.m.) Review request for geode, Alexander Murmann,

Review Request 60394: GEODE-3075 and GEODE-2995: merg

2017-06-23 Thread Galen O'Sullivan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60394/ --- Review request for geode, Alexander Murmann, Bruce Schuchardt, Hitesh Khamesra,

[GitHub] geode pull request #598: GEODE-2818: Completing implementation/testing of al...

2017-06-23 Thread YehEmily
GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/598 GEODE-2818: Completing implementation/testing of aliases [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-2818) Changes were previously implemented to allow users to

[GitHub] geode issue #597: Client protocol with develop, gated by a feature flag.

2017-06-23 Thread galen-pivotal
Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/597 All tests pass! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,