[GitHub] geode issue #620: GEODE-3172: Fix serialization errors with client queues fr...

Github user upthewaterspout commented on the issue: https://github.com/apache/geode/pull/620 @jhuynh1 @ladyVader @bschuchardt @hiteshk25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] geode pull request #620: GEODE-3172: Fix serialization errors with client qu...

GitHub user upthewaterspout opened a pull request: https://github.com/apache/geode/pull/620 GEODE-3172: Fix serialization errors with client queues from between 1.0 and 1.2 Adding new tests and fixing errors when copying a client queue from a 1.0 member to a 1.2 member, or from a

[GitHub] geode-native pull request #109: GEODE-3173: Upgrade to gtest 1.8

GitHub user dgkimura opened a pull request: https://github.com/apache/geode-native/pull/109 GEODE-3173: Upgrade to gtest 1.8 Upgrades to gtest 1.8. Testing: Unittests compiled and ran You can merge this pull request into a Git repository by running: $ git pull

[GitHub] geode-native pull request #108: GEODE-3135 Update Geode Client docs OpenSSL ...

GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode-native/pull/108 GEODE-3135 Update Geode Client docs OpenSSL version @pivotal-jbarrett @joeymcallister @davebarnes97 Please review. You can merge this pull request into a Git repository by

Re: Review Request 60629: GEODE-3129 - Added error messages to protobuf protocol

> On July 6, 2017, 8:45 p.m., Udo Kohlmeyer wrote: > > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandler.java > > Line 32 (original), 34 (patched) > > > > > > I

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #608 was SUCCESSFUL (with 1908 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #608 was successful. --- Scheduled 1910 tests in total. https://build.spring.io/browse/SGF-NAG-608/ -- This

[GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class

Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/107#discussion_r126029862 --- Diff: src/cppcache/include/geode/Struct.hpp --- @@ -138,7 +138,7 @@ class CPPCACHE_EXPORT Struct : public Serializable { * Returns

[GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class

Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/107#discussion_r126027361 --- Diff: src/cppcache/include/geode/Struct.hpp --- @@ -138,7 +138,7 @@ class CPPCACHE_EXPORT Struct : public Serializable { * Returns the

[GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class

Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/107#discussion_r126027851 --- Diff: src/cppcache/include/geode/Struct.hpp --- @@ -152,9 +152,7 @@ class CPPCACHE_EXPORT Struct : public Serializable { Struct();

[GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class

Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/107#discussion_r126028200 --- Diff: src/cppcache/integration-test/testThinClientRemoteQuerySS.cpp --- @@ -56,59 +57,63 @@ const wchar_t* checkNullString(const wchar_t* str) {

Re: Review Request 60629: GEODE-3129 - Added error messages to protobuf protocol

> On July 6, 2017, 8:45 p.m., Udo Kohlmeyer wrote: > > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java > > Line 67 (original), 68 (patched) > > > > > > Why do we have

[GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class

GitHub user echobravopapa opened a pull request: https://github.com/apache/geode-native/pull/107 GEODE-3019: Refactor Struct class - Using std::string now - this also addresses GEODE-3020, the map now used standard types You can merge this pull request into a Git

Re: Review Request 60629: GEODE-3129 - Added error messages to protobuf protocol

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60629/#review179796 ---

Build failed in Jenkins: Geode-nightly-flaky #57

See -- [...truncated 99.41 KB...] Download https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-core/1.2.0.RELEASE/spring-plugin-core-1.2.0.RELEASE.pom Download

Review Request 60688: GEODE-1279: rename tests with old bug system numbers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60688/ --- Review request for geode, Jared Stewart and Patrick Rhomberg. Bugs: GEODE-1279

Jenkins build is back to normal : Geode-release-flaky #23

See

[GitHub] geode pull request #601: GEODE-3117: fix Gateway authentication with legacy ...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/601 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Build failed in Jenkins: Geode-nightly #888

See Changes: [kmiller] GEODE-2991 Add man page for gfsh destroy gateway-sender [upthewaterspout] GEODE-3167: Added commons-validator dependency to modify_war script and --

Failed: jinmeiliao/geode#7 (refactor-week2-day3 - 93bf746)

Build Update for jinmeiliao/geode - Build: #7 Status: Failed Duration: 22 minutes and 29 seconds Commit: 93bf746 (refactor-week2-day3) Author: Jinmei Liao Message: spotless View the changeset:

[GitHub] geode-native issue #106: GEODE-2891 connect-timeout violation in C++ Native ...

Github user gregt5259 commented on the issue: https://github.com/apache/geode-native/pull/106 In my mind we talk about the some kind of redesign rather than about correct change: the original design is based de-facto exactly on using ‘magic numbers’; configurable measurements

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/#review179794 --- One small change that might be helpful is to note the version -

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/#review179793 --- Ship it! Ship It! - Jared Stewart On July 6, 2017, 4:03

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/ --- (Updated July 6, 2017, 4:03 p.m.) Review request for geode, Emily Yeh, Jared

Re: Review Request 60666: geode-3166: remove the uncalled getCredential method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60666/#review179785 --- For the record, and as discussed offline, I think 1-arg method

[GitHub] geode-native issue #106: GEODE-2891 connect-timeout violation in C++ Native ...

Github user pivotal-jbarrett commented on the issue: https://github.com/apache/geode-native/pull/106 @gregt5259 This is a solution to the problem but not the solution we as committers are comfortable committing as it directly conflicts with the correct change, which is to use type

Build failed in Jenkins: Geode-release #74

See Changes: [bschuchardt] Revert "Revert "GEODE-3139 remove current artifacts from classpath of -- [...truncated 644.38 KB...] at

[GitHub] geode-native issue #106: GEODE-2891 connect-timeout violation in C++ Native ...

Github user gregt5259 commented on the issue: https://github.com/apache/geode-native/pull/106 Did I understood correct that there are no issues found during the code review in the reviewed code? Probably the decision regarding the accepting of the pull request doesn’t depend in

Review Request 60678: GEODE-3151 Configuration Parameter Based Registration Of internal Region over JMX

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60678/ --- Review request for geode and Barry Oglesby. Bugs: GEODE-3151

Jenkins build is back to normal : Geode-nightly-flaky #56

See