Re: Review Request 61143: GEODE-3310 Set target node in TXStateProxy during TXFailover if necessary

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61143/#review181515 --- Ship it! Ship It! - Darrel Schneider On July 26, 2017, 10:37

Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Pat

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #628 was SUCCESSFUL (with 1987 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #628 was successful. --- Scheduled 1989 tests in total. https://build.spring.io/browse/SGF-NAG-628/ -- This

[GitHub] geode pull request #647: GEODE-3271: Refactor WanCommands

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/647 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] geode pull request #652: Geode-2971: Introduce ExitCode to resolve inconsist...

Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/652#discussion_r129713345 --- Diff: geode-assembly/src/test/java/org/apache/geode/management/internal/cli/shell/GfshExitCodeStatusCommandsDUnitTest.java --- @@ -0,0 +1,396 @@ +/*

[GitHub] geode pull request #652: Geode-2971: Introduce ExitCode to resolve inconsist...

Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/652#discussion_r129712861 --- Diff: geode-assembly/src/test/java/org/apache/geode/management/internal/cli/shell/GfshExitCodeStatusCommandsDUnitTest.java --- @@ -0,0 +1,396 @@ +/*

[GitHub] geode pull request #652: Geode-2971: Introduce ExitCode to resolve inconsist...

Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/652#discussion_r129713502 --- Diff: geode-assembly/src/test/java/org/apache/geode/management/internal/cli/shell/GfshExitCodeStatusCommandsDUnitTest.java --- @@ -0,0 +1,396 @@ +/*

[GitHub] geode pull request #652: Geode-2971: Introduce ExitCode to resolve inconsist...

Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/652#discussion_r129712972 --- Diff: geode-assembly/src/test/java/org/apache/geode/management/internal/cli/shell/GfshExitCodeStatusCommandsDUnitTest.java --- @@ -0,0 +1,396 @@ +/*

[GitHub] geode pull request #652: Geode-2971: Introduce ExitCode to resolve inconsist...

Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/652#discussion_r129712729 --- Diff: geode-assembly/src/test/java/org/apache/geode/management/internal/cli/shell/GfshExitCodeStatusCommandsDUnitTest.java --- @@ -0,0 +1,396 @@ +/*

[GitHub] geode pull request #652: Geode-2971: Introduce ExitCode to resolve inconsist...

Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/652#discussion_r129714136 --- Diff: geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java --- @@ -102,35 +107,52 @@ protected ProcessBuilder toProcessBuil

[GitHub] geode pull request #580: GEODE-2936: Refactoring OrderByComparator

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/580 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] geode pull request #653: GEODE-3290: Removed effectively-dead classes Filter...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/653 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] geode pull request #650: GEODE-3253: Refactoring ClientCommands and related ...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/650 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] geode pull request #580: GEODE-2936: Refactoring OrderByComparator

Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/580#discussion_r129695770 --- Diff: geode-core/src/test/java/org/apache/geode/cache/query/internal/OrderByComparatorJUnitTest.java --- @@ -173,36 +157,54 @@ public void testUnsupport

[GitHub] geode pull request #580: GEODE-2936: Refactoring OrderByComparator

Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/580#discussion_r129693040 --- Diff: geode-core/src/test/java/org/apache/geode/cache/query/internal/OrderByComparatorJUnitTest.java --- @@ -173,36 +157,54 @@ public void testUnsupport

[GitHub] geode pull request #580: GEODE-2936: Refactoring OrderByComparator

Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/580#discussion_r129693128 --- Diff: geode-core/src/test/java/org/apache/geode/cache/query/internal/OrderByComparatorJUnitTest.java --- @@ -173,36 +157,54 @@ public void testUnsupport

[GitHub] geode-native pull request #113: (no ticket) Capitalize C# client member func...

Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] geode-native issue #113: (no ticket) Capitalize C# client member functions

Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/113 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/657#discussion_r129689404 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java --- @@ -279,26 +280,29 @@ protected void acceptConnection(Socke

[GitHub] geode pull request #450: GEODE-2632: create ClientCachePutBench

Github user kirklund closed the pull request at: https://github.com/apache/geode/pull/450 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] geode issue #657: GEODE-3286: Failing to cleanup connections from Connection...

Github user WireBaron commented on the issue: https://github.com/apache/geode/pull/657 Pushed a new version with some method renames. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/657#discussion_r129684574 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java --- @@ -279,26 +280,29 @@ protected void acceptConnection(Socket sock)

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/657#discussion_r129683975 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java --- @@ -1322,6 +1328,14 @@ private void createBatchSendBuffer() {

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/657#discussion_r129683563 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java --- @@ -568,6 +568,12 @@ protected Connection(ConnectionTable t, Socket soc

Re: Review Request 61143: GEODE-3310 Set target node in TXStateProxy during TXFailover if necessary

> On July 26, 2017, 8:11 p.m., Nick Reich wrote: > > All my comments are nits and only suggestions / thoughts and not barriers to accepting this review and shipping it. - Nick --- This is an automatically generated e-mail. To reply, vi

Re: Review Request 61143: GEODE-3310 Set target node in TXStateProxy during TXFailover if necessary

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61143/#review181480 --- geode-core/src/main/java/org/apache/geode/internal/cache/tier/soc

[GitHub] geode pull request #659: GEODE-3308: Lucene rolling upgrade and backwards co...

Github user nabarunnag commented on a diff in the pull request: https://github.com/apache/geode/pull/659#discussion_r129679647 --- Diff: geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneSearchWithRollingUpgradeDUnit.java --- @@ -0,0 +1,1044 @@ +/* + * License

[GitHub] geode pull request #652: Geode-2971: Introduce ExitCode to resolve inconsist...

Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/652#discussion_r129673457 --- Diff: geode-core/src/main/java/org/apache/geode/internal/ExitCode.java --- @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] geode pull request #659: GEODE-3308: Lucene rolling upgrade and backwards co...

Github user ladyVader commented on a diff in the pull request: https://github.com/apache/geode/pull/659#discussion_r129672503 --- Diff: geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneSearchWithRollingUpgradeDUnit.java --- @@ -0,0 +1,1044 @@ +/* + * Licensed

Re: JIRA Assignment Permissions Request

Hello Anthony, I forgot to include that, sorry. My username is jujoramos. Cheers. On Wed 26 Jul 2017 at 18:25, Anthony Baker wrote: > Welcome! What is your JIRA username? > > Anthony > > > On Jul 26, 2017, at 3:43 AM, Ju@N wrote: > > > > Hello team, > > > > Can I get permissions to assign Geo

[GitHub] geode issue #659: GEODE-3308: Lucene rolling upgrade and backwards compatibi...

Github user nabarunnag commented on the issue: https://github.com/apache/geode/pull/659 * These tests were ported from RollingUpgradeDUnitTest and RollingUpgrade2DUnitTest * Instead of put and get verification, it is now lucent query result size verification Potential Rev

[GitHub] geode pull request #659: GEODE-3308: Lucene rolling upgrade and backwards co...

GitHub user nabarunnag opened a pull request: https://github.com/apache/geode/pull/659 GEODE-3308: Lucene rolling upgrade and backwards compatibility tests … …added Thank you for submitting a contribution to Apache Geode. In order to streamline the review

Jenkins build is back to normal : Geode-nightly-flaky #76

See

[GitHub] geode issue #652: Geode-2971: Introduce ExitCode to resolve inconsistency of...

Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/652 @jaredjstewart I don't know why I didn't think to put my questions here instead of imbedding them in my code, just to be removed later. I clearly wasn't on my A-game. 1. In my additio

[GitHub] geode pull request #652: Geode-2971: Introduce ExitCode to resolve inconsist...

Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/652#discussion_r129656012 --- Diff: geode-core/src/main/java/org/apache/geode/internal/ExitCode.java --- @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/651#discussion_r129654481 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java --- @@ -639,29 +639,34 @@ public Result compactO

[GitHub] geode pull request #643: GEODE-3192,GEODE-3229: Change API and implementatio...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/643#discussion_r129649690 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java --- @@ -53,10 +52,10 @@

[GitHub] geode pull request #651: GEODE-3230: Cleaning up unused (Cli)Strings

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/651#discussion_r129647633 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java --- @@ -639,29 +639,34 @@ public Result com

[GitHub] geode pull request #652: Geode-2971: Introduce ExitCode to resolve inconsist...

Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/652#discussion_r129647221 --- Diff: geode-assembly/src/test/java/org/apache/geode/management/internal/cli/shell/GfshExitCodeStatusCommandsDUnitTest.java --- @@ -0,0 +1,396 @@ +

[GitHub] geode pull request #652: Geode-2971: Introduce ExitCode to resolve inconsist...

Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/geode/pull/652#discussion_r129646761 --- Diff: geode-core/src/main/java/org/apache/geode/internal/ExitCode.java --- @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/657#discussion_r129640056 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java --- @@ -279,26 +280,29 @@ protected void acceptConnection(Socket s

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/657#discussion_r129639921 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java --- @@ -1322,6 +1328,14 @@ private void createBatchSendBuffer() {

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/657#discussion_r129640243 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java --- @@ -568,6 +568,12 @@ protected Connection(ConnectionTable t, Socket

[GitHub] geode pull request #657: GEODE-3286: Failing to cleanup connections from Con...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/657#discussion_r129645767 --- Diff: geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java --- @@ -1322,6 +1328,14 @@ private void createBatchSendBuffer() {

[GitHub] geode issue #652: Geode-2971: Introduce ExitCode to resolve inconsistency of...

Github user jaredjstewart commented on the issue: https://github.com/apache/geode/pull/652 To answer one of your `//TODO` questions, I think `gfsh help` should return a normal exit code. Can you collect the other questions you have and post them in this PR? It will be much easier to

Review Request 61143: GEODE-3310 Set target node in TXStateProxy during TXFailover if necessary

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61143/ --- Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, an

Re: JIRA Assignment Permissions Request

Welcome! What is your JIRA username? Anthony > On Jul 26, 2017, at 3:43 AM, Ju@N wrote: > > Hello team, > > Can I get permissions to assign Geode Tickets to myself in JIRA?. > Cheers. > > -- > Ju@N

JIRA Assignment Permissions Request

Hello team, Can I get permissions to assign Geode Tickets to myself in JIRA?. Cheers. -- Ju@N

Build failed in Jenkins: Geode-nightly #907

See Changes: [bschuchardt] GEODE-3175 backward-compatibility tests fail with bad classpath [bschuchardt] GEODE-3175 backward-compatibility tests fail with bad classpath [Anil] GEODE-3115 Added changes to check for

[GitHub] geode pull request #474: GEODE-2788: Add official Socket timeout parameter w...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/474 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] geode pull request #634: Feature/geode 3175

Github user bschuchardt closed the pull request at: https://github.com/apache/geode/pull/634 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #649: GEODE-2997: Change new protocol GetAllResponse.

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/649#discussion_r129628663 --- Diff: geode-protobuf/src/main/proto/clientProtocol.proto --- @@ -66,7 +66,7 @@ message Response { RemoveAllResponse removeAllResponse =

[GitHub] geode pull request #656: GEODE-3312 Update doc gfsh list members output

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/656 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] geode pull request #649: GEODE-2997: Change new protocol GetAllResponse.

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/649#discussion_r129626464 --- Diff: geode-protobuf/src/main/proto/basicTypes.proto --- @@ -62,4 +62,14 @@ message Region { message Server { string url = 1;

[GitHub] geode pull request #649: GEODE-2997: Change new protocol GetAllResponse.

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/649#discussion_r129626228 --- Diff: geode-protobuf/src/main/proto/clientProtocol.proto --- @@ -66,7 +66,7 @@ message Response { RemoveAllResponse removeAllResponse =

[GitHub] geode pull request #609: GEODE-2886 : sent IllegalStateException instead of ...

Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/609#discussion_r129624935 --- Diff: geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java --- @@ -290,6 +295,24 @@ public void queryJsonObject() t