Geode unit tests completed in 'develop/DistributedTest' with non-zero exit code

Pipeline results can be found at: Concourse: https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/54

Build failed in Jenkins: Geode-nightly-flaky #199

See Changes: [bschuchardt] GEODE-4163 clean up DistributionManager code [dbarnes] GEODE-4175 User Guide: gfsh doc example for creating a hash index does [jdeppe] GEODE-4097 allow to take geode-core jar from c

Build failed in Jenkins: Geode-nightly #1057

See Changes: [github] GEODE-4110: rename LocatorServerStartupRule to ClusterStartupRule [github] GEODE-3764 Documented fix for "idle expiration will happen even if the -- [.

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #781 was SUCCESSFUL (with 2324 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #781 was successful. --- Scheduled 2326 tests in total. https://build.spring.io/browse/SGF-NAG-781/ -- This

Re: PRs should always include tests

Xiaojian, are you describing a situation where we change implementation because we already have a failing test that somehow got merged in? On Fri, Dec 29, 2017 at 2:20 PM, Xiaojian Zhou wrote: > How about the code change is already covered by existing tests? > > Not to reduce test coverage seems

Re: PRs should always include tests

How about the code change is already covered by existing tests? Not to reduce test coverage seems a more reasonable standard. On Fri, Dec 29, 2017 at 2:07 PM, Udo Kohlmeyer wrote: > +1 > > > > On 12/29/17 12:05, Kirk Lund wrote: > >> I think we all need to be very consistent in requiring tests

Re: PRs should always include tests

+1 On 12/29/17 12:05, Kirk Lund wrote: I think we all need to be very consistent in requiring tests with all PRs. This goes for committer as well as non-committer contributions. A test would both confirm the existence of the bug in the first place and then confirm the fix. Without such a test,

Re: PRs should always include tests

👍🏻 On Fri, Dec 29, 2017 at 12:51 PM, Jacob Barrett wrote: > +1 > > > On Dec 29, 2017, at 12:05 PM, Kirk Lund wrote: > > > > I think we all need to be very consistent in requiring tests with all > PRs. > > This goes for committer as well as non-committer contributions. > > > > A test would both

Re: PRs should always include tests

+1 > On Dec 29, 2017, at 12:05 PM, Kirk Lund wrote: > > I think we all need to be very consistent in requiring tests with all PRs. > This goes for committer as well as non-committer contributions. > > A test would both confirm the existence of the bug in the first place and > then confirm the f

PRs should always include tests

I think we all need to be very consistent in requiring tests with all PRs. This goes for committer as well as non-committer contributions. A test would both confirm the existence of the bug in the first place and then confirm the fix. Without such a test, any developer could come along later, modi

Geode unit tests completed in 'develop/FlakyTest' with non-zero exit code

Pipeline results can be found at: Concourse: https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/FlakyTest/builds/74

Re: Apache Geode repos

You got them all. > On Dec 28, 2017, at 6:19 PM, Kirk Lund wrote: > > Do we have any other repos besides the following? > > geode-examples.git > geode.git > geode-native.git > geode-site.git > > The gitbox jira comment changes should now be completed on all of the above. > > Thanks, > Kirk