Re: [Proposal] Gfsh Command Feature Flag Annotation

2018-03-21 Thread Swapnil Bawaskar
This is a great start, however, there may be features that only add options to gfsh commands rather than adding gfsh commands themselves, we should accommodate those as and when we encounter them. Udo, I like the idea of having a more generic solution for feature flagging, however, if a feature

Re: [Proposal] Gfsh Command Feature Flag Annotation

2018-03-21 Thread Swapnil Bawaskar
I like @Disabled too. On Mon, Mar 19, 2018 at 12:02 PM Michael William Dodge wrote: > I kind of like @Disabled instead. > > Sarge > > > On 19 Mar, 2018, at 11:58, Udo Kohlmeyer wrote: > > > > I wonder if this proposal could not be extended to the greater

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #863 was SUCCESSFUL (with 2379 tests)

2018-03-21 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #863 was successful. --- Scheduled 2381 tests in total. https://build.spring.io/browse/SGF-NAG-863/ -- This

Re: GEODE Jira Access

2018-03-21 Thread Dan Smith
Hi Michael - What's your JIRA username? If you don't have one, please go ahead and create an account. -Dan On Wed, Mar 21, 2018 at 3:27 PM, Michael Oleske wrote: > Hi all, > > I'd like to be able to update GEODE Jira to reflect what I'm working on, so > was hoping to get

GEODE Jira Access

2018-03-21 Thread Michael Oleske
Hi all, I'd like to be able to update GEODE Jira to reflect what I'm working on, so was hoping to get access. Thanks! michael Michael Oleske Software Engineer Pivotal - Santa Monica

Re: [VOTE] Apache Geode 1.5.0 RC1

2018-03-21 Thread Dan Smith
+1 Run geode-release-check. Verified no MD5 files in the distribution. -Dan On Wed, Mar 21, 2018 at 11:57 AM, Anthony Baker wrote: > +1 > > - verified signatures and checksums > - checked source release for binaries > - basic gfsh testing > - ran all the examples > >

Re: Recreate Cache -- is it possible?

2018-03-21 Thread Jinmei Liao
Sounds like this is a slippery slope. I reworked the strategy: instead of calling cache.close, I only issue a call to the locator to get the cluster configuration again and do a reload of the properties and cacheXml. Here is the PR for this approach: https://github.com/apache/geode/pull/1656

Re: Recreate Cache -- is it possible?

2018-03-21 Thread Kirk Lund
The non-daemon thread in a process launched with ServerLauncher is looping in waitOnServer. When you close the Cache, that loop exits and the ServerLauncher process exits. As Bruce pointed you, JUnit and the DUnit VMs have other non-daemon threads. You might need to alter

Geode unit tests completed in 'develop/DistributedTest' with non-zero exit code

2018-03-21 Thread apachegeodeci
Pipeline results can be found at: Concourse: https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/216

Re: [VOTE] Apache Geode 1.5.0 RC1

2018-03-21 Thread Anthony Baker
+1 - verified signatures and checksums - checked source release for binaries - basic gfsh testing - ran all the examples Anthony > On Mar 20, 2018, at 3:09 PM, Swapnil Bawaskar wrote: > > This is the first release candidate for Apache Geode, version 1.5.0. > Thanks to

Re: Recreate Cache -- is it possible?

2018-03-21 Thread Swapnil Bawaskar
Does this mean auto-reconnect is broken as well? On Wed, Mar 21, 2018 at 10:28 AM Jinmei Liao wrote: > Bruce: this sounds like the root cause of the differences between the dunit > test and reall app test. > > On Wed, Mar 21, 2018 at 10:22 AM, Bruce Schuchardt

Re: [DISCUSS] New List for Commit and CI Emails

2018-03-21 Thread Galen O'Sullivan
Yeah, I think I'm sending myself convinced by Swapnil's argument. How about muting the "nightly build succeeded" email? On Wed, Mar 21, 2018 at 9:58 AM, Sean Goller wrote: > Concourse sends mail whenever a job fails. > > On Wed, Mar 21, 2018 at 9:49 AM, Swapnil Bawaskar

Re: [VOTE] Apache Geode 1.5.0 RC1

2018-03-21 Thread Anthony Baker
Yep, the build inserts the username (in this case the release manager) into the version properties file. Anthony > On Mar 21, 2018, at 10:20 AM, Jens Deppe wrote: > > Is it normal for the build id to contain an actual username. As in: > > Build-Date: 2018-03-20 11:43:49

Re: [DISCUSS] gradle checks for test categories.

2018-03-21 Thread Anthony Baker
We could always have a backstop job that executes uncategorized tests…? Anthony > On Mar 21, 2018, at 10:29 AM, Nabarun Nag wrote: > > Yes, Jens. The new module level categorization like LuceneTests, WanTests. > I am worried that a test may be checked in but it is never

Re: [DISCUSS] gradle checks for test categories.

2018-03-21 Thread Nabarun Nag
Yes, Jens. The new module level categorization like LuceneTests, WanTests. I am worried that a test may be checked in but it is never executed as a part of module category test pipelines because we missed to add the module category to the test. Regards Naba On Wed, Mar 21, 2018 at 10:14 AM Jens

Re: Recreate Cache -- is it possible?

2018-03-21 Thread Jinmei Liao
Bruce: this sounds like the root cause of the differences between the dunit test and reall app test. On Wed, Mar 21, 2018 at 10:22 AM, Bruce Schuchardt wrote: > It's likely that the JVM is exiting because the AcceptorImpl thread is the > only non-daemon thread and it is

Re: Recreate Cache -- is it possible?

2018-03-21 Thread Jinmei Liao
Kirk: good call. I will see if I can add an interface method to the InternalCache. On Wed, Mar 21, 2018 at 10:13 AM, Kirk Lund wrote: > I'm actively working to remove direct usage of GemFireCacheImpl from all of > our code. Is there a reason you have to directly use

Re: Recreate Cache -- is it possible?

2018-03-21 Thread Bruce Schuchardt
It's likely that the JVM is exiting because the AcceptorImpl thread is the only non-daemon thread and it is stopped when the cache is closed.  DUnit JVMs have a non-daemon main() thread that keeps them alive. On 3/21/18 9:48 AM, Jinmei Liao wrote: We would like to allow users to import a new

Geode unit tests completed in 'develop/IntegrationTest' with non-zero exit code

2018-03-21 Thread apachegeodeci
Pipeline results can be found at: Concourse: https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/IntegrationTest/builds/299

Re: [VOTE] Apache Geode 1.5.0 RC1

2018-03-21 Thread Jens Deppe
Is it normal for the build id to contain an actual username. As in: Build-Date: 2018-03-20 11:43:49 -0700 Build-Id: *sbawaskar* 0 Build-Java-Version: 1.8.0_121 Build-Platform: Mac OS X 10.13.3 x86_64 Product-Name: Apache Geode Product-Version: 1.5.0 Source-Date: 2018-03-19 10:31:04

Re: [DISCUSS] gradle checks for test categories.

2018-03-21 Thread Jens Deppe
The build already fails if a test is added without @Category. Do you mean it should fail if the test also does not have one of these newer categories? --Jens On Wed, Mar 21, 2018 at 9:51 AM, Nabarun Nag wrote: > Hi, > > As we have now categorized our tests to categories like

Re: Recreate Cache -- is it possible?

2018-03-21 Thread Kirk Lund
I'm actively working to remove direct usage of GemFireCacheImpl from all of our code. Is there a reason you have to directly use GemFireCacheImpl? This is going to add one more thing that I have to change. Maybe the VM exit is happening because you've forked a new VM with ServerLauncher or

Re: Recreate Cache -- is it possible?

2018-03-21 Thread Jinmei Liao
Great, how do we trigger cache.close indicating auto-reconnect? On Wed, Mar 21, 2018 at 10:08 AM, Anilkumar Gingade wrote: > Instead of adding new feature; can we address the issue with VM exit. The > auto-reconnect feature does cache close without exiting the VM. > >

Re: Recreate Cache -- is it possible?

2018-03-21 Thread Anilkumar Gingade
Instead of adding new feature; can we address the issue with VM exit. The auto-reconnect feature does cache close without exiting the VM. -Anil. On Wed, Mar 21, 2018 at 9:48 AM, Jinmei Liao wrote: > We would like to allow users to import a new set of cluster configuration

Re: [DISCUSS] New List for Commit and CI Emails

2018-03-21 Thread Sean Goller
Concourse sends mail whenever a job fails. On Wed, Mar 21, 2018 at 9:49 AM, Swapnil Bawaskar wrote: > I know travis is already configured to send emails only when the build > breaks and then when it is fixed. Is concourse configured the same? > > On Wed, Mar 21, 2018 at

[DISCUSS] gradle checks for test categories.

2018-03-21 Thread Nabarun Nag
Hi, As we have now categorized our tests to categories like LuceneTests, WanTests, OQLQueriesTests, should we modify our gradle script to fail the build if a new test class was added without a test category. This will prevent test classes to be added without a fine level test category by mistake.

Re: [DISCUSS] New List for Commit and CI Emails

2018-03-21 Thread Swapnil Bawaskar
I know travis is already configured to send emails only when the build breaks and then when it is fixed. Is concourse configured the same? On Wed, Mar 21, 2018 at 9:38 AM Patrick Rhomberg wrote: > I'm with Swapnil on this one. I think the way we make it less noisy is to >

Recreate Cache -- is it possible?

2018-03-21 Thread Jinmei Liao
We would like to allow users to import a new set of cluster configuration with running servers as long as we make sure these servers are vanilla servers (servers that are just started with nothing in it). Now since the servers are already up, caches are already created, we will need to re-create

Re: [DISCUSS] New List for Commit and CI Emails

2018-03-21 Thread Patrick Rhomberg
I'm with Swapnil on this one. I think the way we make it less noisy is to take the time to fix the failing tests. I suppose we could split the difference and give the CI emails a, say, daily cadence. No news is good news, or else it gives you all the failures in the last 24 hours. Don't know

Re: [VOTE] Apache Geode 1.5.0 RC1

2018-03-21 Thread Dave Barnes
+1 User Guide builds correctly from source, javadocs look up-to-date On Wed, Mar 21, 2018 at 8:27 AM, Jens Deppe wrote: > +1 - basic gfsh functionality looks good on Windows. > > On Tue, Mar 20, 2018 at 5:07 PM, Anthony Baker wrote: > > > md5 generation is

Re: [VOTE] Apache Geode 1.5.0 RC1

2018-03-21 Thread Jens Deppe
+1 - basic gfsh functionality looks good on Windows. On Tue, Mar 20, 2018 at 5:07 PM, Anthony Baker wrote: > md5 generation is already removed from geode, just need to do this for > geode-examples. > > Anthony > > > > On Mar 20, 2018, at 3:30 PM, Swapnil Bawaskar

Re: [DISCUSS] New List for Commit and CI Emails

2018-03-21 Thread Jacob Barrett
It’s sad that the most frequent spammer... e... I mean mailer is the new CI process. If we aren’t going to send it elsewhere how can we make it less noisy? -Jake > On Mar 20, 2018, at 8:37 PM, Dan Smith wrote: > > I was curious about the stats for bot vs. humans on the