RE: [Proposal] Back-port doc fixes to support/1.13

2020-07-22 Thread Dick Cavender
+1 -Original Message- From: Owen Nichols Sent: Wednesday, July 22, 2020 4:59 PM To: dev@geode.apache.org Subject: Re: [Proposal] Back-port doc fixes to support/1.13 +1 On July 22, 2020 at 3:43:16 PM PDT, Jinmei Liao wrote: +1 On Jul 22, 2020 3:39 PM, Dave Barnes wrote: I propose

Re: [Proposal] Back-port doc fixes to support/1.13

2020-07-22 Thread Owen Nichols
+1 On July 22, 2020 at 3:43:16 PM PDT, Jinmei Liao wrote: +1 On Jul 22, 2020 3:39 PM, Dave Barnes wrote: I propose back-porting the following doc updates to Geode support/1.13 (and 1.12, while we're at it): - GEODE-2113: User Guide - p2p.HANDSHAKE_POOL_SIZE is obsolete, remove from docs

Re: [Proposal] Back-port doc fixes to support/1.13

2020-07-22 Thread Jinmei Liao
+1 On Jul 22, 2020 3:39 PM, Dave Barnes wrote: I propose back-porting the following doc updates to Geode support/1.13 (and 1.12, while we're at it): - GEODE-2113: User Guide - p2p.HANDSHAKE_POOL_SIZE is obsolete, remove from docs (code fixed in 1.9.0, docs fixed in 1.14.0) - GEODE-7628: Block

[Proposal] Back-port doc fixes to support/1.13

2020-07-22 Thread Dave Barnes
I propose back-porting the following doc updates to Geode support/1.13 (and 1.12, while we're at it): - GEODE-2113: User Guide - p2p.HANDSHAKE_POOL_SIZE is obsolete, remove from docs (code fixed in 1.9.0, docs fixed in 1.14.0) - GEODE-7628: Block jmx mbean creation when no security manager is

Re: [PROPOSAL] Cherry pic GEODE-8331 to support branches

2020-07-22 Thread Dave Barnes
Please go ahead, Jinmei. Thanks for your contribution. On Wed, Jul 22, 2020 at 3:11 PM Dick Cavender wrote: > +1 > > -Original Message- > From: Anilkumar Gingade > Sent: Wednesday, July 22, 2020 2:44 PM > To: dev@geode.apache.org > Subject: Re: [PROPOSAL] Cherry pic GEODE-8331 to

RE: [PROPOSAL] Cherry pic GEODE-8331 to support branches

2020-07-22 Thread Dick Cavender
+1 -Original Message- From: Anilkumar Gingade Sent: Wednesday, July 22, 2020 2:44 PM To: dev@geode.apache.org Subject: Re: [PROPOSAL] Cherry pic GEODE-8331 to support branches +1 This will provide a consistent experience our end user from 1.10 release version. On 7/22/20, 2:23 PM,

Re: [PROPOSAL] Cherry pic GEODE-8331 to support branches

2020-07-22 Thread Anilkumar Gingade
+1 This will provide a consistent experience our end user from 1.10 release version. On 7/22/20, 2:23 PM, "Jinmei Liao" wrote: I would like to propose to cherry pick GEODE-8331: allow GFSH to connect to other versions of cluster (#5375) to support branches up to 1.10. This would allow

Re: [PROPOSAL] Cherry pic GEODE-8331 to support branches

2020-07-22 Thread Owen Nichols
+ I reviewed this fix and it looks good to me. The previous logic of locking gfsh to only work with the same minor version of the server needlessly makes upgrades a pain, and is unnecessary as most gfsh commands have not changed in recent releases, so only erroring when there is a real

[PROPOSAL] Cherry pic GEODE-8331 to support branches

2020-07-22 Thread Jinmei Liao
I would like to propose to cherry pick GEODE-8331: allow GFSH to connect to other versions of cluster (#5375) to support branches up to 1.10. This would allow gfsh to connect to other versions of cluster and provide better error messages when command is not support by the connected cluster.