Re: CODEOWNERS? (was Re: Pending PR reviews)

2022-06-29 Thread Patrick Johnson
+1 for getting rid of CODEOWNERS. > On Jun 29, 2022, at 9:33 AM, Anthony Baker wrote: > > ⚠ External Email > > I realize that this is a thread hijack, but hopefully a useful one. I’ve seen > several requests for timely reviews in recent months. I think that the > CODEOWNERS goals were

[PROPOSAL] RFC for migrating from springfox to springdoc

2022-05-05 Thread Patrick Johnson
Hello devs! Please review this RFC: https://cwiki.apache.org/confluence/display/GEODE/Migration+from+springfox+to+springdoc on migrating from springfox to springdoc for our swagger needs and provide any feedback you have. Review period until Friday, May 13th. —Patrick Johnson

Re: Proposal: Cutting 1.15 Release branch Tuesday, 25 January

2022-01-21 Thread Patrick Johnson
+1 for cutting. My team has nothing we intend to put out in 1.15. From: Anilkumar Gingade Sent: Friday, January 21, 2022 9:00:09 AM To: dev@geode.apache.org Subject: Re: Proposal: Cutting 1.15 Release branch Tuesday, 25 January > and remaining work is on

Re: @TestOnly or @VisibleForTesting

2021-11-04 Thread Patrick Johnson
I agree with Eric. Maybe rather than standardizing on one, we should stop adding anymore @VisibleForTesting or @TestOnly to the codebase. Possibly deprecate @VisibleForTesting. > On Nov 4, 2021, at 3:30 PM, Eric Zoerner wrote: > > My opinion is that @VisibleForTesting is a code smell and

Re: August Community Meeting

2021-07-29 Thread Patrick Johnson
+1 works for me. > On Jul 29, 2021, at 11:00 AM, Alexander Murmann wrote: > > Hi Geode community, > > Next week's August 4th is the first Wednesday in August. Usually that would > be the day that we have our community meeting. Many of our community members > work on Apache Geode as part of

Re: [DISCUSS] - Creation of new Apache Geode Github repo for Gradle Plugin

2021-07-20 Thread Patrick Johnson
I think that's a great idea. Having the plugin in a separate repo will also make the plugin more easily testable than if it were in buildSrc. +1 From: Udo Kohlmeyer Sent: Tuesday, July 20, 2021 6:55:04 PM To: geode Subject: [DISCUSS] - Creation of new Apache

Re: Cleaning up the codebase - use curly braces everywhere

2021-05-27 Thread Patrick Johnson
+1. Also really like Naba's idea of incorporating this into spotless. On May 27, 2021, at 10:46 AM, Raymond Ingles mailto:ring...@vmware.com>> wrote: +1 Sounds like a good idea. Since always using curly braces is part of the style guide, fixing this makes sense. The only possible additional

Re: [VOTE] Requiring final keyword on every parameter and local variable

2021-04-14 Thread Patrick Johnson
-1 for requiring final for all method parameters. While I have nothing against using final here, I don’t think it’s worth mandating and would be better left up to the individual and the specific circumstance. On Apr 14, 2021, at 4:33 PM, Jason Huynh mailto:jhu...@vmware.com>> wrote: Yeah,

Re: [DISCUSS] RFC - Add option to allow newer Geode clients to connect to older Geode servers

2021-01-22 Thread Patrick Johnson
It sounds like you intend to test which versions are compatible with each other and maintain a list the client can use to reject the setting of force-version when set to an incompatible version. If that’s the case, why not just have the handshake look at that list and automatically connect with

Re: [DISCUSS] One more 1.13 change

2020-09-28 Thread Patrick Johnson
+1 > On Sep 28, 2020, at 12:21 PM, Dan Smith wrote: > > Hi, > > I'd like to backport this change to support/1.13 as well > > GEODE-8522: Switching exception log back to debug - >

Re: [VOTE] Apache Geode 1.13.0.RC1

2020-09-08 Thread Patrick Johnson
+1 What I did: - Built from source - Ran unit tests - Built Spring Data Geode using 1.13 - Ran the Spring Data Geode unit tests using 1.13 - Ran the Spring Data Geode examples using 1.13 On Sep 8, 2020, at 5:02 PM, John Blum mailto:jb...@vmware.com>> wrote: +1 Built Spring Data for Apache

Re: [PROPOSAL] Backport GEODE-8423 to support/1.13

2020-08-12 Thread Patrick Johnson
+1 > On Aug 12, 2020, at 8:59 AM, Sarah Abbey wrote: > > The documentation for the Redis API for Geode that will currently be > published for 1.13 is not accurate and needs to be updated so potential users > searching for information about Redis API for Geode will get accurate > information.

Request wiki access

2020-08-03 Thread Patrick Johnson
Hi, Can someone grant me write access to the Apache Geode wiki? My user name is jpatrick, same as my email address. Thanks, Patrick Johnson

Re: [Proposal] - RFC etiquette

2020-07-09 Thread Patrick Johnson
+1 > On Jul 9, 2020, at 1:18 PM, Udo Kohlmeyer wrote: > > Hi there Geode Dev's > > I would like to propose the following changes to the RFC process that we have > in place at the moment. > > 1. All submitted RFC’s will provide a minimum 2 week review period. This is > to allow the

Proposal to bring GEODE-8068 to support/1.13

2020-05-08 Thread Patrick Johnson
I’d like to bring GEODE-8068 to support/1.13. This commit reverts two prior commits (GEODE-8033 and GEODE-8044). GEODE-8033 and GEODE-8044 introduced an experimental feature that is useless in its current state and has already been redesigned, so there is no reason for it to go out with 1.13.

Re: Reconfiguring our notifications and more

2020-04-21 Thread Patrick Johnson
+1 On Apr 21, 2020, at 8:55 AM, Robert Houghton mailto:rhough...@pivotal.io>> wrote: +1 On Tue, Apr 21, 2020, 08:54 Anthony Baker mailto:aba...@pivotal.io>> wrote: I’d like a quick round of feedback so we can stop the dev@ spamming [1]. ASF has implemented a cool way to give projects

Re: [PROPOSAL] Include fix for GEODE-7763 into release 1.12.0

2020-03-18 Thread Patrick Johnson
+1 On 3/18/20, 11:50 AM, "Dan Smith" wrote: +1 On Wed, Mar 18, 2020 at 11:41 AM Jason Huynh wrote: > Hello Dev list, > > I'd like to include a fix for GEODE-7763 in release 1.12.0. > The change removes the call to exportValue, preventing a serialization,

Re: [DISCUSSION] Bumping dependency versions for 1.12

2020-02-11 Thread Patrick Johnson
+1 On 2/11/20, 8:42 AM, "Udo Kohlmeyer" wrote: Hi there, I wonder if this might be a little late in the game, but would we consider bumping some of the dependency versions for 1.12? Off the top of my head, Spring from 5.2.1 to 5.2.3 --Udo

Re: [Vote] Include GEODE-7752 into 1.12

2020-02-05 Thread Patrick Johnson
+1 On 2/5/20, 1:53 PM, "Udo Kohlmeyer" wrote: Hi there Geode dev, I would like to request that GEODE-7752 (7028f601680fee3f57cbdff63951128d7180ca13) gets included into 1.12. This piece of code is a refactor of work done in GEODE-7715. This refactor specializes

Re: [VOTE] Inclusion of GEODE-7531 into 1.11

2019-12-17 Thread Patrick Johnson
+1 > On Dec 17, 2019, at 3:01 PM, Owen Nichols wrote: > > +1 > >> On Dec 17, 2019, at 2:57 PM, Udo Kohlmeyer wrote: >> >> Hi there Apache Devs. >> >> I can we please vote on the inclusion of GEODE-7531. This issue is to fix an >> bug which assumes that all `Pool` objects are of type

Re: [VOTE] Inclusion of GEODE-7159 into 1.11

2019-12-17 Thread Patrick Johnson
+1 > On Dec 17, 2019, at 2:59 PM, Owen Nichols wrote: > > +1 > >> On Dec 17, 2019, at 2:58 PM, Udo Kohlmeyer wrote: >> >> Hi there Apache Devs. >> >> I can we please vote on the inclusion of GEODE-7159. This issue is to fix an >> bug which assumes that all `Pool` objects are of type

Re: New geode-gfsh module

2019-12-06 Thread Patrick Johnson
Our goal wasn’t to make gfsh standalone, but a couple people have asked about it already. It’s not currently planned as far as I know, though maybe it will be in the future. > On Dec 6, 2019, at 10:00 AM, Jacob Barrett wrote: > > > >> On Dec 6, 2019, at 9:43 AM, Jens Deppe wrote: >> >>

Re: Permission to assign tickets in Jira

2019-12-03 Thread Patrick Johnson
Thanks Dan! > On Dec 3, 2019, at 4:11 PM, Dan Smith wrote: > > Done! > > -Dan > > On Tue, Dec 3, 2019 at 3:38 PM Patrick Johnson wrote: > >> Hi all, >> >> Could someone grant me permission to assign tickets to myself in the Geode &g

Permission to assign tickets in Jira

2019-12-03 Thread Patrick Johnson
Hi all, Could someone grant me permission to assign tickets to myself in the Geode Jira? My Jira username is pjohnson. -- Thanks, Patrick Johnson

Re: Adding GEODE-7412 to 1.11 release

2019-11-08 Thread Patrick Johnson
+1 > On Nov 8, 2019, at 10:56 AM, Udo Kohlmeyer wrote: > > Hi there Geode Dev, > > I would like to request that we add > https://issues.apache.org/jira/browse/GEODE-7412 > to the 1.11 release. > > This change is a build change that has

[DISCUSS] Geode Redis Adapter

2019-10-24 Thread Patrick Johnson
I noticed that Geodes Redis Adapter needs some work, but doesn't seem to have gotten much attention recently. In its current state, it is confusing for users looking to run their Redis clients against Geode. What do you think about moving it to a branch until we make it better?

Request Jira access

2018-07-26 Thread Patrick Johnson
Hello, I'd like access to The Geode Jira. My Jira user name is yozaner1324. Thank you, Patrick Johnson