[GitHub] geode pull request #753: GEODE-3283: Expose parallel import and export in gf...

2017-09-01 Thread agingade
Github user agingade commented on a diff in the pull request: https://github.com/apache/geode/pull/753#discussion_r136644610 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ImportDataFunction.java --- @@ -40,9 +40,13 @@ public void execute

[GitHub] geode pull request #753: GEODE-3283: Expose parallel import and export in gf...

2017-09-01 Thread agingade
Github user agingade commented on a diff in the pull request: https://github.com/apache/geode/pull/753#discussion_r136644394 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ImportDataFunction.java --- @@ -40,9 +40,13 @@ public void execute

[GitHub] geode pull request #753: GEODE-3283: Expose parallel import and export in gf...

2017-09-01 Thread agingade
Github user agingade commented on a diff in the pull request: https://github.com/apache/geode/pull/753#discussion_r136640863 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/snapshot/RegionSnapshotServiceImpl.java --- @@ -342,6 +342,7 @@ private void

[GitHub] geode issue #585: GEODE-3091: remove empty method

2017-06-19 Thread agingade
Github user agingade commented on the issue: https://github.com/apache/geode/pull/585 The changes looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] geode pull request #477: GEODE-2398: fix oplog corruption in overflow oplogs

2017-04-24 Thread agingade
Github user agingade commented on a diff in the pull request: https://github.com/apache/geode/pull/477#discussion_r113087379 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/OverflowOplog.java --- @@ -724,8 +727,31 @@ public final void flush() throws IOException