Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/739#discussion_r135899858
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
---
@@ -50,26 +53,52
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/325
@zmyer could you please confirm that this PR is still relevant. If not I
will close it CoB tomorrow ( 25 Aug)
---
If your project is set up for it, you can reply to this email and have your
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/245
@doribd @fdaniel7 could you please close this PR if it is not required
anymore.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/742
@pivotal-amurmann no files should have been moved. Only class import
locations have changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/742
@galen-pivotal @bschuchardt @pivotal-amurmann @WireBaron @hiteshk25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user kohlmu-pivotal opened a pull request:
https://github.com/apache/geode/pull/742
GEODE-3473: Initial commit of the internal package renaming refactor.
Changing the protobuf file refactor first.
Thank you for submitting a contribution to Apache Geode
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/739#discussion_r135055785
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
---
@@ -50,26 +53,52
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/739#discussion_r135055386
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
---
@@ -50,26 +53,52
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/737#discussion_r134895876
--- Diff: geode-protobuf/src/main/proto/region_API.proto ---
@@ -58,6 +58,7 @@ message GetAllRequest {
message GetAllResponse
GitHub user kohlmu-pivotal opened a pull request:
https://github.com/apache/geode/pull/737
GEODE-3503: Removal of Codec classes left behind.
Added tests to test the remaining JSONCodec.
Thank you for submitting a contribution to Apache Geode.
In order to streamline
Github user kohlmu-pivotal closed the pull request at:
https://github.com/apache/geode/pull/736
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user kohlmu-pivotal opened a pull request:
https://github.com/apache/geode/pull/736
GEODE-3503: Removal of Codec classes left behind.
Added tests to test the remaining JSONCodec.
Thank you for submitting a contribution to Apache Geode.
In order to streamline
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134514607
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java
---
@@ -50,51 +37,23
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/702#discussion_r134328545
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/net/SocketCloser.java ---
@@ -96,46 +99,55 @@ public int getMaxThreads
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/719#discussion_r134050811
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java
---
@@ -40,20 +42,28 @@ public void
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/719#discussion_r134051130
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java
---
@@ -40,20 +42,28 @@ public void
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134053987
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/InvalidExecutionContextException.java
---
@@ -0,0 +1,33
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134006399
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
---
@@ -334,42 +342,46 @@ protected void run
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134006932
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134007584
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/InvalidExecutionContextException.java
---
@@ -0,0 +1,33
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134007044
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134005525
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
---
@@ -143,11 +150,12 @@
public
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/717
@aravindmusigumpula could you please explain why this feature is required
and why the member now has to adhere to his neighbor's member-timeout.
What problem is this change addressing
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133782267
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java
---
@@ -0,0 +1,64
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133783618
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java
---
@@ -0,0 +1,64
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133780406
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java
---
@@ -50,51 +37,19
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133778667
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
---
@@ -392,7 +388,7 @@ public void
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133781367
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandlerJUnitTest.java
---
@@ -32,75
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133778013
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133778501
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
---
@@ -392,7 +388,7 @@ public void
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133779835
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java
---
@@ -50,51 +37,19
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133774197
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
---
@@ -334,42 +342,46 @@ protected void run
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133775965
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java
---
@@ -0,0 +1,64
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133775201
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
---
@@ -334,42 +342,46 @@ protected void run
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133775860
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java
---
@@ -0,0 +1,64
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133775690
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java ---
@@ -76,7 +76,9 @@
*/
public interface
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/702#discussion_r133353995
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java ---
@@ -929,10 +929,6 @@ protected void removeEndpoint
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/702#discussion_r133255222
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/net/SocketCloser.java ---
@@ -96,46 +99,55 @@ public int getMaxThreads
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/702#discussion_r133238599
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/net/SocketCloser.java ---
@@ -96,46 +99,55 @@ public int getMaxThreads
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/702#discussion_r133238417
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/net/SocketCloser.java ---
@@ -144,35 +156,22 @@ private boolean isClosed
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/649
@galen-pivotal is this PR active anymore?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/702#discussion_r133113689
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/net/SocketCloser.java ---
@@ -96,46 +99,55 @@ public int getMaxThreads
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/707#discussion_r132735527
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
---
@@ -63,6 +65,31 @@ private static
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/707#discussion_r132735728
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
---
@@ -72,9 +99,15 @@ public static
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/707#discussion_r132737475
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfig.java
---
@@ -2433,6 +2433,25 @@
String
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/707#discussion_r132737182
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java
---
@@ -1378,6 +1379,18 @@
*/
String NAME
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/707#discussion_r132738771
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
---
@@ -63,6 +65,31 @@ private static
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/707#discussion_r132738100
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/NoOpStreamAuthenticator.java
---
@@ -0,0 +1,43
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/702
@bschuchardt @dschneider-pivotal is on the review of this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/702
@bschuchardt @galen-pivotal @hiteshk25 @pivotal-amurmann
@dschneider-pivotal @WireBaron @kirklund
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user kohlmu-pivotal opened a pull request:
https://github.com/apache/geode/pull/702
GEODE-3416: Reduce synchronization blockages in SocketCloser.
Remove synchronization blocks around HashMap. Replace that implementation
with simpler ThreadPool that is not unbounded
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/682
@hiteshk25 @bschuchardt @pivotal-amurmann @WireBaron
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user kohlmu-pivotal opened a pull request:
https://github.com/apache/geode/pull/682
GEODE-3393: One-way SSL authentication fails with FileNotFoundException for
$USER_HOME/.keystore
Thank you for submitting a contribution to Apache Geode.
In order to streamline
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/676#discussion_r130928395
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandlerJUnitTest.java
---
@@ -95,8 +97,8
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/676#discussion_r130928974
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtocolErrorCode.java
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/657#discussion_r129879726
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java ---
@@ -1322,6 +1328,14 @@ private void createBatchSendBuffer
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/649#discussion_r128848930
--- Diff: geode-protobuf/src/main/proto/basicTypes.proto ---
@@ -62,4 +62,14 @@ message Region {
message Server {
string url = 1
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/649#discussion_r128847166
--- Diff: geode-protobuf/src/main/proto/clientProtocol.proto ---
@@ -66,7 +66,7 @@ message Response {
RemoveAllResponse removeAllResponse
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128814031
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128567505
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
---
@@ -67,30 +68,27
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128386349
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java
---
@@ -124,20 +128,19
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128386432
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java
---
@@ -99,23 +105,21
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128388403
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
---
@@ -35,10 +37,9
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128387458
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationContext.java
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128386591
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java
---
@@ -64,11 +72,10
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r128038401
--- Diff: geode-protobuf/src/main/proto/basicTypes.proto ---
@@ -52,7 +52,12 @@ message CallbackArguments {
message Region {
--- End
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127761196
--- Diff: geode-protobuf/src/main/proto/region_API.proto ---
@@ -102,4 +102,14 @@ message GetRegionNamesRequest {
message
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/633
@hiteshk25 @pivotal-amurmann
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/633#discussion_r127540044
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
---
@@ -68,9 +56,8 @@ protected
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127294137
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
---
@@ -278,6 +278,31 @@ public void
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127294096
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
---
@@ -133,21 +134,38
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127289532
--- Diff: geode-protobuf/src/main/proto/basicTypes.proto ---
@@ -52,7 +52,12 @@ message CallbackArguments {
message Region {
string
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127289486
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
---
@@ -278,6 +278,31 @@ public void
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127289396
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/RemoveRequestOperationHandler.java
---
@@ -33,7 +33,7
GitHub user kohlmu-pivotal opened a pull request:
https://github.com/apache/geode/pull/630
GEODE-3141: GetRegion Operation implemented
Added OperationHandlerJUnitTest.java as parents class of all
OperationHandler tests.
General clean up of all `public static final` fields
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/621
Yes, there was a PR related to this, but it was deleted and then this one
created. In addition, there is/was a review in apache reviewboard since Jul,3
---
If your project is set up
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/325
Is this PR still open or relevant? If not, could we please close this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/474
@masaki-yamakawa I'm running precheckin. If it passes I'll merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/404
@yhilem @ggreen @bbaynes, there is currently a feature branch
https://github.com/apache/geode/tree/feature/GEODE-2444, which started
splitting the Redis Adapter into its own module.
I
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/483#discussion_r116248082
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
---
@@ -109,6 +110,7 @@ public void
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/462#discussion_r112304411
--- Diff: geode-docs/tools_modules/gfsh/command-pages/start.html.md.erb ---
@@ -398,6 +400,17 @@ See Overview of
cluster-config
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/450#discussion_r111093862
--- Diff:
geode-core/src/jmh/java/org/apache/geode/internal/cache/tier/sockets/command/ClientCachePutBench.java
---
@@ -0,0 +1,199
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/404
I like the fact that we are now dealing with collections on a single
machine, rather than all the elements spread distributed. Would you possibly
have some perf metrics in relation to larger
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/313#discussion_r94819019
--- Diff:
geode-core/src/test/java/org/apache/geode/cache30/ReconnectDUnitTest.java ---
@@ -534,41 +532,35 @@ public Object call() throws
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/305
I doubt that FixedPRSinglehopDUnitTest::primaryBucketsOnServer provides any
benefit over FixedPRSinglehopDUnitTest.primaryBucketsOnServer()
---
If your project is set up for it, you can reply
85 matches
Mail list logo
