GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/116
GEODE-3439: Split ThinClientRegionInterestTestsN into mulitple tests â¦
â¦to avoid random failures.
You can merge this pull request into a Git repository by running:
$ git
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/114
This was merged without auto-close comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/115
@dgkimura https://issues.apache.org/jira/browse/GEODE-3432
Anything else you don't like?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/115
@dgkimura Those files actually need to be redone in a way more closely
aligned with other CMake find modules. I would leave them alone for now and fix
later.
---
If your project
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/115#discussion_r132769880
--- Diff: CMakeLists.txt ---
@@ -242,7 +242,7 @@ add_subdirectory(dhimpl)
add_subdirectory(sqliteimpl)
add_subdirectory(tests
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/115
@dgkimura which CMake find modules are you referring to?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/115
GEODE-3165: Reogranized sources relative to the root for better CMake
⦠IDE integration.
- Moved src/docs to docs/api.
- Moved src/* to root.
- Fixup paths in CMake
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/114
Please fix up commit messages
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/111
Just a test PR
Please ignore this while we test PR CI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pivotal-jbarrett/geode
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r127312259
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -78,13 +78,12 @@ int32_t StructSetImpl::getFieldIndex(const char*
fieldname
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r127278256
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -66,8 +66,8 @@ SelectResultsIterator StructSetImpl::getIterator() {
return
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r127278443
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -66,8 +66,8 @@ SelectResultsIterator StructSetImpl::getIterator() {
return
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r127278631
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -78,13 +78,12 @@ int32_t StructSetImpl::getFieldIndex(const char*
fieldname
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r126792525
--- Diff: src/cppcache/src/StructSetImpl.cpp ---
@@ -78,13 +78,11 @@ int32_t StructSetImpl::getFieldIndex(const char*
fieldname
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r126792435
--- Diff: src/cppcache/src/Struct.cpp ---
@@ -96,16 +99,16 @@ Serializable* Struct::fromData(DataInput& input) {
re
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/102
@mhansonp you have conflicts, can you rebase and force push.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/110#discussion_r126254300
--- Diff:
docs/geode-native-docs/introduction/client-configurations.html.md.erb ---
@@ -157,7 +157,7 @@ The following libraries are external
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/110#discussion_r126254216
--- Diff:
docs/geode-native-docs/introduction/client-configurations.html.md.erb ---
@@ -157,7 +157,7 @@ The following libraries are external
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/102
@mhansonp please follow up or close this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r126116586
--- Diff: src/cppcache/integration-test/testThinClientRemoteQuerySS.cpp ---
@@ -56,59 +57,63 @@ const wchar_t* checkNullString(const wchar_t
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/107#discussion_r126115701
--- Diff: src/cppcache/include/geode/Struct.hpp ---
@@ -138,7 +138,7 @@ class CPPCACHE_EXPORT Struct : public Serializable {
* Returns
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/108#discussion_r126114762
--- Diff: docs/geode-native-docs/security/sslclientserver.html.md.erb ---
@@ -42,17 +42,17 @@ To install OpenSSL:
2. Extract the archive
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/108#discussion_r126113664
--- Diff:
docs/geode-native-docs/introduction/client-configurations.html.md.erb ---
@@ -157,7 +157,7 @@ The following libraries are external
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/108#discussion_r126114295
--- Diff: docs/geode-native-docs/introduction/quickstart.html.md.erb ---
@@ -53,7 +53,7 @@ for the latest Java version for your operating
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/108#discussion_r126114552
--- Diff: docs/geode-native-docs/security/sslclientserver.html.md.erb ---
@@ -27,7 +27,7 @@ The open-source OpenSSL toolkit provides a full
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/106
@gregt5259 This is a solution to the problem but not the solution we as
committers are comfortable committing as it directly conflicts with the correct
change, which is to use type
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/106
@echobravopapa the branching scheme only applies to committers working
directly with the Geode repositories. Non-committers use pull requests which
render the branching/girflow
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/105
@gregt5259 please close this pull request since you opened #106.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/105
> I suggest to fix the issue by defining handshake pseudo message within
the range probably defined for such pseudo messages by original design i.e.:
> typede
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/105#discussion_r125184790
--- Diff: src/cppcache/src/TcrConnection.cpp ---
@@ -318,7 +318,9 @@ bool TcrConnection::InitTcrConnection(
LOGFINE("Attem
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/105#discussion_r125184798
--- Diff: src/cppcache/src/TcrConnection.cpp ---
@@ -318,7 +318,9 @@ bool TcrConnection::InitTcrConnection(
LOGFINE("Attem
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/105#discussion_r125184917
--- Diff: src/cppcache/src/TcrConnection.cpp ---
@@ -703,15 +717,21 @@ inline ConnErrType TcrConnection::sendData(uint32_t&
timeS
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/105#discussion_r125184965
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -44,6 +44,8 @@
#include
#include
+//
--- End diff --
Clean
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/105#discussion_r125184959
--- Diff: src/cppcache/src/TcrMessage.hpp ---
@@ -171,7 +173,8 @@ class CPPCACHE_EXPORT TcrMessage {
GET_DURABLE_CQS_DATA_ERROR = 106
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/104
Please open a JIRA and include it in your commit message.
GEODE-1234: blah blah
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/104
It looks like your reverts were to undo changes to .gitignore. I'd suggest
not building from within the source tree at all. If you do there is an ignore
already for "build"
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/103#discussion_r123866557
--- Diff: src/tests/cpp/fwklib/GsRandom.cpp ---
@@ -18,60 +18,16 @@
#include "GsRandom.hpp"
#include
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/103
GEODE-2525: Removes MersenneTwister sources.
Can I get a quick review before I merge.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/102#discussion_r121248442
--- Diff: src/CMakeLists.txt ---
@@ -17,6 +17,15 @@ project(nativeclient)
list(APPEND CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/99
GEODE-2741: Remove custom shared painter and replace with std::shared_ptr.
Tests pass on Linux, Windows, Solaris and Mac.
Please review.
You can merge this pull request
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/95
@masaki-yamakawa For future reference, please rebase your branch before
pull requests and include the `GEODE-XX: ` prefix in your first line commit
statement.
---
If your project
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/95#discussion_r115026056
--- Diff: README.md ---
@@ -24,3 +24,33 @@ Native Client applications can be written in these
client technologies:
* [C++](https
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/95#discussion_r115007123
--- Diff: README.md ---
@@ -24,3 +24,33 @@ Native Client applications can be written in these
client technologies:
* [C++](https
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/90
You shouldn't merge develop into your feature branch. You should rebase
your feature branch on develop. This creates a much cleaner merge of the
feature back into develop when approved
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/74#discussion_r108006315
--- Diff: src/cppcache/src/ThinClientRegion.cpp ---
@@ -3350,7 +3350,8 @@ bool ThinClientRegion::executeFunctionSH(
HashMapT
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/74#discussion_r108006539
--- Diff: src/cppcache/src/ThinClientRegion.hpp ---
@@ -407,17 +407,21 @@ class ChunkedFunctionExecutionResponse : public
TcrChunkedResult
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/74#discussion_r108006150
--- Diff: src/cppcache/src/ThinClientPoolDM.hpp ---
@@ -463,7 +463,8 @@ class FunctionExecution : public PooledWork {
void
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/74#discussion_r108006001
--- Diff: src/cppcache/src/ThinClientPoolDM.cpp ---
@@ -609,7 +609,8 @@ GfErrType ThinClientPoolDM::sendRequestToAllServers(
HostAsm
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/64#discussion_r107045279
--- Diff:
docs/geode-native-docs/continuous-querying/3-native-client-cq-api.html.md.erb
---
@@ -21,9 +21,10 @@ limitations under the License
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/64#discussion_r107040822
--- Diff:
docs/geode-native-docs/continuous-querying/3-native-client-cq-api.html.md.erb
---
@@ -21,9 +21,10 @@ limitations under the License
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/53#discussion_r107039971
--- Diff: src/docs/win_index.html ---
@@ -19,21 +19,21 @@
- Pivotal GemFire Native Client Documentation
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/53#discussion_r106998634
--- Diff: src/docs/win_index.html ---
@@ -19,21 +19,21 @@
- Pivotal GemFire Native Client Documentation
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106930234
--- Diff:
src/cppcache/integration-test/testThinClientPoolExecuteFunction.cpp ---
@@ -1158,9 +1160,10 @@ DUNIT_TASK_DEFINITION(CLIENT1
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106930126
--- Diff:
src/cppcache/integration-test/testThinClientPoolExecuteFunction.cpp ---
@@ -1506,48 +1353,10 @@ void runFunctionExecution(bool
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106929867
--- Diff:
src/clicache/integration-test/ThinClientFunctionExecutionTestsN.cs ---
@@ -959,7 +959,7 @@ public void ExecuteFETimeOut
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/63#discussion_r106929690
--- Diff:
src/clicache/integration-test/ThinClientAppDomainFunctionExecutionTests.cs ---
@@ -0,0 +1,282
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/61
I will go ahead and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/54
@dgkimura I will pull this and work on some of the tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/54
@dgkimura It will give the CI something to chew on to prove that this
message actually works with the server now. ;)
---
If your project is set up for it, you can reply to this email
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/54
@dgkimura I would suggest getting a few of those integration tests updated
to test this. They were marked flaky a long time ago when the tests ran through
several iterations
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/48#discussion_r104816808
--- Diff: src/cppcache/include/geode/DataOutput.hpp ---
@@ -378,9 +378,8 @@ class CPPCACHE_EXPORT DataOutput {
*/
inline void
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/42
@dgkimura You need to remove the C++ parser and Antlr from the LICENSE and
dist/LICENSE files too.
---
If your project is set up for it, you can reply to this email and have your
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/44
@PivotalSarge can you rebase your branch off of develop. We backed out all
those C++11 changes and now they are showing up in your pull.
---
If your project is set up for it, you can
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/44
@PivotalSarge looks like some unit tests are failing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103359636
--- Diff: src/cppcache/src/CqQueryVsdStats.cpp ---
@@ -20,43 +20,38 @@
#include "CqQueryVsdStats.hpp"
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/37#discussion_r103355539
--- Diff: src/cppcache/src/statistics/AtomicStatisticsImpl.cpp ---
@@ -330,7 +329,13 @@ double AtomicStatisticsImpl::_incDouble(int32_t
offset
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/37#discussion_r103355323
--- Diff: src/cppcache/include/geode/SharedBase.hpp ---
@@ -56,11 +57,12 @@ class CPPCACHE_EXPORT SharedBase {
protected
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/37#discussion_r103354398
--- Diff: src/cppcache/include/geode/CacheStatistics.hpp ---
@@ -102,8 +102,8 @@ class CPPCACHE_EXPORT CacheStatistics : public
SharedBase
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103353683
--- Diff: src/cppcache/src/LRUEntriesMap.cpp ---
@@ -20,6 +20,9 @@
#include "MapSegment.hpp"
#include &quo
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103353607
--- Diff: src/cppcache/src/MapSegment.cpp ---
@@ -316,16 +320,16 @@ GfErrType MapSegment::remove(const CacheableKeyPtr&
key, Cacheabl
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103353568
--- Diff: src/cppcache/src/LRUList.hpp ---
@@ -20,32 +20,32 @@
* limitations under the License.
*/
+#include
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103353360
--- Diff: src/cppcache/src/LRUList.cpp ---
@@ -96,33 +102,38 @@ void LRUList<TEntry,
TCreateEntry>::getLRUEntry(LRUListEntryPtr&a
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103353400
--- Diff: src/cppcache/src/MapSegment.cpp ---
@@ -19,18 +19,22 @@
#include "TrackedMapEntry.hpp"
#include "Reg
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103352845
--- Diff: src/cppcache/src/LRUList.cpp ---
@@ -15,12 +15,18 @@
* limitations under the License.
*/
#include "LRULis
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103352781
--- Diff: src/cppcache/src/CqQueryVsdStats.cpp ---
@@ -108,21 +98,21 @@ CqQueryStatType::CqQueryStatType
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103352237
--- Diff: src/cppcache/integration-test/testSpinLock.cpp ---
@@ -20,48 +20,44 @@
#include "fw_dunit.hpp"
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103352019
--- Diff: src/cppcache/src/MapSegment.hpp ---
@@ -164,9 +166,9 @@ class CPPCACHE_EXPORT MapSegment {
m_entryFactory->newMapEntry(
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103351894
--- Diff: src/cppcache/src/MapSegment.hpp ---
@@ -164,9 +166,9 @@ class CPPCACHE_EXPORT MapSegment {
m_entryFactory->newMapEntry(
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103351757
--- Diff: src/cppcache/src/MapSegment.hpp ---
@@ -41,6 +40,9 @@
#include
#include "TombstoneList.hpp"
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103351422
--- Diff: src/tests/cpp/security/Security.cpp ---
@@ -1014,12 +1016,15 @@ int32_t Security::doEntryOperations
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103350612
--- Diff: src/cppcache/src/LRUEntriesMap.cpp ---
@@ -297,7 +295,7 @@ GfErrType LRUEntriesMap::put(const CacheableKeyPtr&
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/36#discussion_r103350610
--- Diff: src/tests/cpp/security/Security.cpp ---
@@ -41,16 +41,18 @@
#include "security/CredentialGenerato
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/40
@PivotalSarge
> Nice fix of the broken window of catching exceptions by value.
If you enable `clang-tidy` you will see plenty of them. I am cleaning up
lots of these
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/40
@PivotalSarge
> Why the switch to ACE_OS::localtime() from localtime()?
`localtime` AKA POSIX `localtime` is not thread safe. `ACE_OS::localtime`
wraps the platf
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/38
GEODE-2549: Delete unused files.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pivotal-jbarrett/geode-native
feature/GEODE
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/37
GEODE-2531: Replace HostAsm::atomic with std::atomic.
Focus on commit c3411fd since the others are from pull #36.
Replaces the HostAsm::atomic* functions and ACE::Atomic
GitHub user pivotal-jbarrett opened a pull request:
https://github.com/apache/geode-native/pull/36
GEODE-2494: Replace SpinLock with spinlock_mutex.
Replaces our non-standard SpinLock with spinlock_mutex that implements the
C++11 standard BasicLockable. Where applicable the spin
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103054588
--- Diff: src/cppcache/integration-test/BuiltinCacheableWrappers.hpp ---
@@ -23,7 +23,7 @@
#include "CacheableWrapper.hpp"
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103054617
--- Diff: src/cppcache/src/CacheableBuiltins.cpp ---
@@ -19,7 +19,7 @@
#include
extern "C" {
-#include
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/33
@PivotalSarge CMakeList.txt.in is there to build Antlr with CMake rather
than the very complicated and broken build process it ships with.
---
If your project is set up for it, you
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103031314
--- Diff: src/tests/cpp/fwklib/Timer.hpp ---
@@ -28,18 +28,18 @@
#ifdef _WIN32
-#include
-#include
-#include
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103009272
--- Diff: src/cppcache/test/ByteArray.cpp ---
@@ -20,7 +20,7 @@
#include "config.h"
#ifdef _MACOSX
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103005713
--- Diff: src/cppcache/src/statistics/HostStatHelperWin.hpp ---
@@ -27,10 +27,10 @@
#include
#include
-#include
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103004805
--- Diff: src/cppcache/test/ByteArray.cpp ---
@@ -20,7 +20,7 @@
#include "config.h"
#ifdef _MACOSX
--
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103005160
--- Diff: src/tests/cpp/fwklib/TaskClient.cpp ---
@@ -20,12 +20,12 @@
#include "fwklib/FwkLog.hpp"
#include "fwk
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103005494
--- Diff: src/tests/cpp/security/XmlAuthzCredentialGenerator.hpp ---
@@ -27,7 +27,7 @@
#include
#include
--- End diff
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103004766
--- Diff: src/cppcache/test/ByteArray.cpp ---
@@ -20,7 +20,7 @@
#include "config.h"
#ifdef _MACOSX
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/32#discussion_r103005369
--- Diff: src/tests/cpp/security/PkcsAuthInit.cpp ---
@@ -19,7 +19,7 @@
#include
#include
#include
-#include "st
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/27
@dgkimura I think the GitHub UI would work better if the Geode repo was
actually hosted in GitHub but since this is a mirror it causes some strange
behaviors with pull requests
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/27
A rebase would have been preferable to a merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
1 - 100 of 180 matches
Mail list logo
