Github user gregt5259 commented on the issue:
https://github.com/apache/geode-native/pull/106
Pull request is closed after passing of all checks and marked as resolved
in Jira GEODE-2891 with resolution "Won't fix" as following:
GEODE-2891 - connect-timeout violation in C++ Native
Github user gregt5259 commented on the issue:
https://github.com/apache/geode-native/pull/106
In my mind we talk about the some kind of redesign rather than about
correct change: the original design is based de-facto exactly on using âmagic
numbersâ; configurable measurements
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/106
@gregt5259 This is a solution to the problem but not the solution we as
committers are comfortable committing as it directly conflicts with the correct
change, which is to use type
Github user gregt5259 commented on the issue:
https://github.com/apache/geode-native/pull/106
Did I understood correct that there are no issues found during the code
review in the reviewed code? Probably the decision regarding the accepting of
the pull request doesnât depend in
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/106
@pivotal-jbarrett fair enough on the branching point, I think the rest is
still a valid ask
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user pivotal-jbarrett commented on the issue:
https://github.com/apache/geode-native/pull/106
@echobravopapa the branching scheme only applies to committers working
directly with the Geode repositories. Non-committers use pull requests which
render the branching/girflow
Github user echobravopapa commented on the issue:
https://github.com/apache/geode-native/pull/106
@gregt5259 a couple quick items of feedback that need to be addressed
before this is reviewed:
- please squash your commits, this cleans up the diffs for everyone to
better
