[GitHub] geode-native pull request #48: GEODE-2578: Remove 64 KiB limit on query stri...

Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/48#discussion_r105204008 --- Diff: src/cppcache/include/geode/DataOutput.hpp --- @@ -378,9 +378,8 @@ class CPPCACHE_EXPORT DataOutput { */ inline void

[GitHub] geode-native pull request #48: GEODE-2578: Remove 64 KiB limit on query stri...

Github user PivotalSarge commented on a diff in the pull request: https://github.com/apache/geode-native/pull/48#discussion_r104836958 --- Diff: src/cppcache/include/geode/DataOutput.hpp --- @@ -378,9 +378,8 @@ class CPPCACHE_EXPORT DataOutput { */ inline void

[GitHub] geode-native pull request #48: GEODE-2578: Remove 64 KiB limit on query stri...

Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/48#discussion_r104816808 --- Diff: src/cppcache/include/geode/DataOutput.hpp --- @@ -378,9 +378,8 @@ class CPPCACHE_EXPORT DataOutput { */ inline void

[GitHub] geode-native pull request #48: GEODE-2578: Remove 64 KiB limit on query stri...

Github user PivotalSarge commented on a diff in the pull request: https://github.com/apache/geode-native/pull/48#discussion_r104769132 --- Diff: src/cppcache/test/DataOutputTest.cpp --- @@ -305,15 +305,9 @@ TEST_F(DataOutputTest, TestCursorAdvance) {

[GitHub] geode-native pull request #48: GEODE-2578: Remove 64 KiB limit on query stri...

Github user PivotalSarge commented on a diff in the pull request: https://github.com/apache/geode-native/pull/48#discussion_r104768886 --- Diff: src/cppcache/include/geode/DataOutput.hpp --- @@ -378,9 +378,8 @@ class CPPCACHE_EXPORT DataOutput { */ inline void

[GitHub] geode-native pull request #48: GEODE-2578: Remove 64 KiB limit on query stri...

Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/48#discussion_r104759431 --- Diff: src/cppcache/src/TcrMessage.hpp --- @@ -555,7 +555,7 @@ class CPPCACHE_EXPORT TcrMessage { const

[GitHub] geode-native pull request #48: GEODE-2578: Remove 64 KiB limit on query stri...

Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/48#discussion_r104766406 --- Diff: src/cppcache/include/geode/DataOutput.hpp --- @@ -378,9 +378,8 @@ class CPPCACHE_EXPORT DataOutput { */ inline void

[GitHub] geode-native pull request #48: GEODE-2578: Remove 64 KiB limit on query stri...

Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/48#discussion_r104766552 --- Diff: src/cppcache/test/DataOutputTest.cpp --- @@ -305,15 +305,9 @@ TEST_F(DataOutputTest, TestCursorAdvance) {

[GitHub] geode-native pull request #48: GEODE-2578: Remove 64 KiB limit on query stri...

Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/48#discussion_r104759602 --- Diff: src/cppcache/src/TcrMessage.cpp --- @@ -756,8 +756,8 @@ void TcrMessage::writeRegionPart(const std::string& regionName) {

[GitHub] geode-native pull request #48: GEODE-2578: Remove 64 KiB limit on query stri...

Github user echobravopapa commented on a diff in the pull request: https://github.com/apache/geode-native/pull/48#discussion_r104768254 --- Diff: src/cppcache/test/TcrMessage_unittest.cpp --- @@ -559,3 +560,66 @@ TEST_F(TcrMessageTest, testConstructorEXECUTE_FUNCTION) {

[GitHub] geode-native pull request #48: GEODE-2578: Remove 64 KiB limit on query stri...

GitHub user PivotalSarge opened a pull request: https://github.com/apache/geode-native/pull/48 GEODE-2578: Remove 64 KiB limit on query strings. - Remove artificial cap of 65535 for query string length by using 32 bits for the length of query strings in