Re: Review Request 55736: GEODE-2328: Refactor add Field methods to reduce the duplicates

2017-02-01 Thread Udo Kohlmeyer
> On Jan. 31, 2017, 11:43 p.m., Bruce Schuchardt wrote: > > The only thing that concerns me about this change-set is the > > auto-boxing/unboxing that's going on with the new method. The old code > > didn't do that. > > Hitesh Khamesra wrote: > This also concerns me. > > Galen

Re: Review Request 55736: GEODE-2328: Refactor add Field methods to reduce the duplicates

2017-02-01 Thread Udo Kohlmeyer
> On Jan. 31, 2017, 11:43 p.m., Bruce Schuchardt wrote: > > The only thing that concerns me about this change-set is the > > auto-boxing/unboxing that's going on with the new method. The old code > > didn't do that. > > Hitesh Khamesra wrote: > This also concerns me. > > Galen

Re: Review Request 55736: GEODE-2328: Refactor add Field methods to reduce the duplicates

2017-02-01 Thread Galen O'Sullivan
> On Jan. 31, 2017, 11:43 p.m., Bruce Schuchardt wrote: > > The only thing that concerns me about this change-set is the > > auto-boxing/unboxing that's going on with the new method. The old code > > didn't do that. > > Hitesh Khamesra wrote: > This also concerns me. Don't `writeData`

Re: Review Request 55736: GEODE-2328: Refactor add Field methods to reduce the duplicates

2017-02-01 Thread Galen O'Sullivan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55736/#review163747 --- Ship it! Hooray for deleting code! Ship it! - Galen

Re: Review Request 55736: GEODE-2328: Refactor add Field methods to reduce the duplicates

2017-01-31 Thread Hitesh Khamesra
> On Jan. 31, 2017, 11:43 p.m., Bruce Schuchardt wrote: > > The only thing that concerns me about this change-set is the > > auto-boxing/unboxing that's going on with the new method. The old code > > didn't do that. This also concerns me. - Hitesh

Re: Review Request 55736: GEODE-2328: Refactor add Field methods to reduce the duplicates

2017-01-31 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55736/#review163741 --- The only thing that concerns me about this change-set is the

Re: Review Request 55736: GEODE-2328: Refactor add Field methods to reduce the duplicates

2017-01-20 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55736/ --- (Updated Jan. 20, 2017, 4:50 p.m.) Review request for geode, Bruce Schuchardt,

Review Request 55736: GEODE-2328: Refactor add Field methods to reduce the duplicates

2017-01-19 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55736/ --- Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Hitesh