Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/719
@metatype We need the `StreamAuthenticator` to receive and send
(Protobuf-encoded) messages containing the credentials that get passed to the
`SecurityManager`. I would think that ideally it&#
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/739#discussion_r135351811
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
---
@@ -50,26 +53,52
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/739
Rebased on develop.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/730
@PurelyApplied I think you can also close and reopen a PR to restart Travis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/739
rebased on develop again, fixed a test to use the new
MessageExecutionContext.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/746
@bschuchardt try closing and reopening; I think that will make Travis
restart.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/392
[GEODE-2414] Ignore a consistently failing test.
This test only seems to be failing on Linux. I haven't figured out the
cause yet. Ignore it until I have time to fix it properly.
Yo
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/392
@kirklund I'm not a committer; you're welcome to commit this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/368
@kirklund no problem, the change is what counts. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/349
merged in cd2291102744f4bb1b8bb5170e7388b31295ef6f
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user galen-pivotal closed the pull request at:
https://github.com/apache/geode/pull/349
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/359
Merged in a61c55b9b0d4fffc70a1502f06cbca59098c9418
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user galen-pivotal closed the pull request at:
https://github.com/apache/geode/pull/359
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/398
Split the redis adapter into its own package
Under this PR, the redis adapter is moved to its own source root, and
registered as a service.
We're intending to make this a fe
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/398#discussion_r101354013
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/GeodeRedisService.java ---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/398#discussion_r101353985
--- Diff:
geode-redis/src/test/java/org/apache/geode/redis/AuthJUnitTest.java ---
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/398#discussion_r101354076
--- Diff:
geode-redis/src/test/java/org/apache/geode/redis/AuthJUnitTest.java ---
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/398
@metatype The import ordering is the rather unfortunate result of
IntelliJ's import cleanup.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/398#discussion_r101374277
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
---
@@ -1330,21 +1360,12 @@ private void startMemcachedServer
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/399
Minor non-functional changes in response to PR comments.
@bschuchardt
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/galen-pivotal
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/398#discussion_r101388584
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
---
@@ -1330,21 +1360,12 @@ private void startMemcachedServer
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/398#discussion_r101388974
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
---
@@ -1330,21 +1360,12 @@ private void startMemcachedServer
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/400
Add geode-redis to assembly.
This makes starting a server with Redis actually work, at least on my
machine.
You can merge this pull request into a Git repository by running:
$ git pull
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/398#discussion_r101401136
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java
---
@@ -1330,21 +1360,12 @@ private void startMemcachedServer
Github user galen-pivotal closed the pull request at:
https://github.com/apache/geode/pull/398
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/398
We're now running this as a feature branch for the current round of Redis
work, `feature/GEODE-2444`. I'm going to close this PR for now.
---
If your project is set up for it, you ca
Github user galen-pivotal closed the pull request at:
https://github.com/apache/geode/pull/400
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/400
It doesn't look like it, but this has been merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user galen-pivotal reopened a pull request:
https://github.com/apache/geode/pull/400
Add geode-redis to assembly.
This makes starting a server with Redis actually work, at least on my
machine.
You can merge this pull request into a Git repository by running:
$ git pull
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/402#discussion_r101873819
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionManagerDUnitTest.java
---
@@ -159,77 +159,74 @@ public void
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/402#discussion_r102345903
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionManagerDUnitTest.java
---
@@ -159,77 +159,74 @@ public void
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/402#discussion_r102345774
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionManagerDUnitTest.java
---
@@ -159,77 +159,74 @@ public void
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/402#discussion_r102345794
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionManagerDUnitTest.java
---
@@ -159,77 +159,74 @@ public void
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/402#discussion_r102357674
--- Diff:
geode-core/src/test/java/org/apache/geode/distributed/internal/DistributionManagerDUnitTest.java
---
@@ -159,77 +159,74 @@ public void
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/404
@ggreen
Is there any reason we need to create objects rather than just storing
under the given string?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r104031973
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -442,9 +502,10 @@ protected void checkDataType
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r104041266
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -442,9 +502,10 @@ protected void checkDataType
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r104041093
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HDelExecutor.java
---
@@ -40,25 +38,25 @@ public void executeCommand
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r104059948
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HashInterpreter.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/412#discussion_r104258182
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
---
@@ -360,6 +360,13 @@ private void processRequest
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/412#discussion_r104258974
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
---
@@ -77,9 +77,9 @@
*
* This
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r104549703
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HashInterpreter.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105048647
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SIsMemberExecutor.java
---
@@ -40,23 +42,35 @@ public void
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105008897
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/ExecutionHandlerContext.java
---
@@ -235,6 +242,8 @@ private void
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105060205
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SRandMemberExecutor.java
---
@@ -42,9 +42,8 @@ public void
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105010443
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -187,8 +215,18 @@ public boolean removeKey
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105053042
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SMoveExecutor.java
---
@@ -45,30 +48,44 @@ public void executeCommand
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105009858
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -95,18 +98,38 @@ public RegionProvider(Region
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r104552749
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HashExecutor.java
---
@@ -75,14 +96,76
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105059140
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SPopExecutor.java
---
@@ -36,24 +37,26 @@ public void executeCommand
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105061296
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SetOpExecutor.java
---
@@ -47,23 +44,23 @@ public void executeCommand
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105008854
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/ExecutionHandlerContext.java
---
@@ -135,8 +135,14 @@ private void writeToChannel
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105060019
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SRandMemberExecutor.java
---
@@ -42,9 +42,8 @@ public void
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105046939
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SMembersExecutor.java
---
@@ -39,16 +39,18 @@ public void
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105010837
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -289,7 +331,9 @@ public void
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105510564
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HSetExecutor.java
---
@@ -55,9 +69,11 @@ public void executeCommand
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/426
GEODE-2660 Add @Experimental to the Redis adapter.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/galen-pivotal/incubator-geode
feature
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/426
@hiteshk25 @kirklund @upthewaterspout @bschuchardt
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/426
I can't merge as I'm not a committer; would someone else be so kind,
assuming these changes look good?
---
If your project is set up for it, you can reply to this email and have
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/426
@upthewaterspout okay, you'd just put it on GeodeRedisServer?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/426
@bschuchardt want to merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/426
@bschuchardt This is just the experimental annotation, not changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/426
@bschuchardt Check it out again; I force-pushed with just the annotation on
GeodeRedisServer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/437
GEODE-2653: Fix testRemoveMember and remove FlakyTest.
And do some cleanup while I'm here:
* Change Mockito's `any` to `isA`.
* Replace some `Thread.sleep()` calls with
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/437
@bschuchardt this is https://reviews.apache.org/r/58155/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/441
Fix a repetition in the README.
and update numbers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/galen-pivotal/geode fix-README
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/441
I'm not a committer, so someone else will have to push this for me.
@kohlmu-pivotal ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/404
@ggreen, I haven't had a lot of time to look at this lately. It looks like
you checked in some classes in the latest commit; we shouldn't have classes
checked into the repository.
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/404
@ggreen If you can clean up the history from where my PR was merged this
will be much easier to review. In general, even though we've added the
`@Experimental` tag, I would like the PR
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/450
This will set the same keys to the same values each iteration, because. I
ran a benchmark last night with a benchmark that used only 99 values, but I
didn't see a significant diffe
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/450
Do you know why I get so many of these messages when I run the benchmark?
```
Encountered duplicate path
"javassist/bytecode/annotation/ArrayMemberValue.class" during copy
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/450#discussion_r112005377
--- Diff:
geode-core/src/jmh/java/org/apache/geode/internal/cache/tier/sockets/command/ClientCachePutBench.java
---
@@ -0,0 +1,233
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/450#discussion_r112005541
--- Diff:
geode-core/src/jmh/java/org/apache/geode/internal/cache/tier/sockets/command/ClientCachePutBench.java
---
@@ -0,0 +1,233
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/450#discussion_r112004128
--- Diff:
geode-core/src/jmh/java/org/apache/geode/internal/cache/tier/sockets/command/ClientCachePutBench.java
---
@@ -0,0 +1,233
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/437
@kohlmu-pivotal
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/305
[GEODE-1923] Fix a test race condition.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/galen-pivotal/incubator-geode
feature/GEODE-1923
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/305#discussion_r91569800
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/FixedPRSinglehopDUnitTest.java
---
@@ -293,18 +295,24 @@ public void
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/306
[GEODE-2191] Test randomized string serialization/deserialization.
I added this test partly as an exercise in getting used to the Geode
codebase, and partly because I'd like to see
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/306
@kirklund I disagree. We expect string serialization to work reliably on
*all* inputs, and since we can't test all of them, we may as well test a bunch
picked at random. If we fail,
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/313
[GEODE-1407] Change a FlakyTest to distributedTest.
* remove `FlakyTest` from `ReconnectDUnitTest.testReconnectALocator`.
* use Awaitility instead of Wait.
This test doesn't
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/305#discussion_r94657673
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/FixedPRSinglehopDUnitTest.java
---
@@ -293,18 +294,23 @@ public void
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/305#discussion_r94660604
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/FixedPRSinglehopDUnitTest.java
---
@@ -293,18 +294,23 @@ public void
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/305
@kohlmu-pivotal I just think it's a bit cleaner syntactically; there's no
other real benefit.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/313#discussion_r94888520
--- Diff:
geode-core/src/test/java/org/apache/geode/cache30/ReconnectDUnitTest.java ---
@@ -534,41 +532,35 @@ public Object call() throws CacheException
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/305
@kohlmu-pivotal Could you merge this for me please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/337
[GEODE-2295] Add constructors for LocatorCancelException
and update one place where it's used.
You can merge this pull request into a Git repository by running:
$ git pull
Github user galen-pivotal closed the pull request at:
https://github.com/apache/geode/pull/337
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/337
Moving to review board.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/349
[GEODE-2324] fixes to AcceptorImpl.close()
If the thread is interrupted during closing, just continue to shut down
what we can.
* Catch InterruptedException so cleanup continues
Github user galen-pivotal closed the pull request at:
https://github.com/apache/geode/pull/313
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/313
Merged after rebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/359
[GEODE-2295] Add constructors for `LocatorCancelException`.
[GEODE-2295] Add constructors for `LocatorCancelException`.
You can merge this pull request into a Git repository by running
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/360
[GEODE-1793] Fix a flaky test, clean up SSL tests.
* Use less code.
* Get random port numbers a bit more robustly.
* Check to make sure that locator2 has died at the end.
You can merge
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/368
[GEODE-2381] make complex enums not look terrible.
* Change the style XML file to insert a line break after each constant
of an enum.
There may be a better way to do this and
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/368
@jaredjstewart you know more about this than I do.
Do you know why we decided to go with the Eclipse formatter rather than
[Google's java formatter](https://github.com/google/google
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/368
I don't really understand what the `48` means, but it's used elsewhere and
looks something like "put everything on its own line".
---
If your project is set up for it, y
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/382
GEODE-2414: mark a failing test as flaky.
This is just a temporary fix for CI until we can diagnose the issue.
@kohlmu-pivotal @hiteshk25
You can merge this pull request into a Git
GitHub user galen-pivotal opened a pull request:
https://github.com/apache/geode/pull/383
GEODE-2206: Add junit-quickcheck to geode-core.
* Rewrite a data serialization test to use junit-quickcheck.
You can merge this pull request into a Git repository by running:
$ git pull
Github user galen-pivotal commented on the issue:
https://github.com/apache/geode/pull/383
@scmbuildguy : done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/383#discussion_r99265598
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/InternalDataSerializerQuickcheckStringTest.java
---
@@ -0,0 +1,63
101 - 200 of 201 matches
Mail list logo
