Re: Review Request 41419: reverting change to ClientProxyMembershipID

2015-12-16 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41419/ --- (Updated Dec. 16, 2015, 8:14 p.m.) Review request for geode and Jianxia Chen.

[GitHub] incubator-geode pull request: GEODE-680: Chunk refactoring encount...

2015-12-16 Thread sboorlagadda
GitHub user sboorlagadda opened a pull request: https://github.com/apache/incubator-geode/pull/61 GEODE-680: Chunk refactoring encountered while writing unit tests. 1) Promoted constant fields to default access level. 2) Modified getAddressForReading to delegate to

Re: Review Request 41466: GEODE-680: Chunk refactoring encountered while writing unit tests.

2015-12-16 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41466/#review110763 --- Ship it! Ship It! - Darrel Schneider On Dec. 16, 2015, 1:08

Review Request 41481: GEODE-660: Fixing inconsistencies and reliance on randomness in TableBuilderJUnitTest

2015-12-16 Thread Jens Deppe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41481/ --- Review request for geode and Kirk Lund. Repository: geode Description

Re: Review Request 41492: GEODE-681: Measuring event queue size without using the stat for gfsh

2015-12-16 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41492/#review110915 ---

Re: Review Request 41492: GEODE-681: Measuring event queue size without using the stat for gfsh

2015-12-16 Thread Ashvin A
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41492/#review110907 --- Ship it! Looks good. I am wondering if a unit tests for the

Re: Review Request 41481: GEODE-660: Fixing inconsistencies and reliance on randomness in TableBuilderJUnitTest

2015-12-16 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41481/#review110820 --- I recommend introducing PowerMock on dev@geode before committing

Review Request 41492: GEODE-581: Measuring event queue size without using the stat for gfsh

2015-12-16 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41492/ --- Review request for geode, Ashvin A and xiaojian zhou. Repository: geode