[GitHub] incubator-geode issue #235: GEODE-1818: Bug37377DUnitTest passes with NPE su...

2016-08-31 Thread upthewaterspout
Github user upthewaterspout commented on the issue: https://github.com/apache/incubator-geode/pull/235 It would be nice to rename this test to something other than Bug37377DUnitTest, since no one knows what that means. --- If your project is set up for it, you can reply to this email

[GitHub] incubator-geode issue #235: GEODE-1818: Bug37377DUnitTest passes with NPE su...

2016-08-31 Thread dschneider-pivotal
Github user dschneider-pivotal commented on the issue: https://github.com/apache/incubator-geode/pull/235 this looks good. I will pull it in --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

Re: Review Request 51567: should save the reference of serverlocation in case it was destroyed by another thread

2016-08-31 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51567/#review147508 --- Ship it! Ship It! - Dan Smith On Aug. 31, 2016, 11:49 p.m.,

Review Request 51567: should save the reference of serverlocation in case it was destroyed by another thread

2016-08-31 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51567/ --- Review request for geode and Dan Smith. Bugs: GEODE-1833 https://issues.apa

Re: Review Request 51549: GEODE-1809: Improve error handling

2016-08-31 Thread Dick Cavender
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51549/#review147504 --- Ship it! Wow, that's alot of bullet-proofing in a negected port

Re: Review Request 51547: refactor the luceneIndex and repoManager to use index reference, and add FSDirectory support

2016-08-31 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51547/#review147502 --- Fix it, then Ship it! geode-lucene/src/test/java/com/gemstone/

Re: Review Request 51559: GEODE-1818: Bug37377DUnitTest passes with NPE suspect strings in log

2016-08-31 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51559/#review147496 --- geode-core/src/test/java/com/gemstone/gemfire/internal/cache/Bug3

[GitHub] incubator-geode pull request #235: GEODE-1818: Bug37377DUnitTest passes with...

2016-08-31 Thread gemzdude
GitHub user gemzdude opened a pull request: https://github.com/apache/incubator-geode/pull/235 GEODE-1818: Bug37377DUnitTest passes with NPE suspect strings in log This is an older test which had experienced some severe "code rot". Modified code to conform to current product

Re: Build failed in Jenkins: Geode-nightly #577

2016-08-31 Thread William Markito
Looks like our build was running on H5 machine which seems to be the same faulty one that caused Geode-release to fail many times... I've added that machine to the exclusion list and kicked another build, let's see how that goes. Thanks On Wed, Aug 31, 2016 at 8:06 AM, Apache Jenkins Server < je

Re: Review Request 51559: GEODE-1818: Bug37377DUnitTest passes with NPE suspect strings in log

2016-08-31 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51559/#review147461 --- Ship it! Ship It! - Darrel Schneider On Aug. 31, 2016, 11:31

Review Request 51559: GEODE-1818: Bug37377DUnitTest passes with NPE suspect strings in log

2016-08-31 Thread Scott Jewell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51559/ --- Review request for geode, Darrel Schneider and Ken Howe. Repository: geode De

Re: Review Request 51465: GEODE-1128: Cleaned up some of the colocation logging test

2016-08-31 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51465/#review147455 --- Ship it! Ship It! - Darrel Schneider On Aug. 31, 2016, 9:53

Re: Review Request 51465: GEODE-1128: Cleaned up some of the colocation logging test

2016-08-31 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51465/ --- (Updated Aug. 31, 2016, 4:53 p.m.) Review request for geode, anilkumar gingade,

Build failed in Jenkins: Geode-nightly #577

2016-08-31 Thread Apache Jenkins Server
See Changes: [upthewaterspout] GEODE-1830: Use event, not entry, to check for a tombstone -- [...truncated 511 lines...] Caused by: java.net.ConnectException: Connection refused at sun.nio.c