Re: Nightly Build still failing with BindExceptions

I suspect many of these BindExceptions are caused by the test itself trying to use the same port twice, rather than something else on the box grabbing a port. I do think the long term solution is to get rid of AvailablePort. But maybe in the short term we could change it to not pick a random numbe

Re: securing geode components

Udo, Kirk - this makes sense and thanks for the discussion to help clarify the issue. Regarding GEODE-1648, does it make sense to do at all? That is, what if role-based access control is either ON | OFF instead of per component. If we allow disabling RBAC for certain components, wouldn’t that

Re: M3 is out - New release manager for 1.0 ?

I can take on this task for 1.0 On Thu, Sep 8, 2016 at 4:20 PM, William Markito wrote: > With M3 out and all the discussions we're having around what's needed for > 1.0, I think we should continue the rotation of release managers and get a > new volunteer for 1.0. > > As part of this conversatio

M3 is out - New release manager for 1.0 ?

With M3 out and all the discussions we're having around what's needed for 1.0, I think we should continue the rotation of release managers and get a new volunteer for 1.0. As part of this conversation we should also discuss the scope and roadmap for 1.0 and could use the thread [1] for M3 as a sta

Re: securing geode components

+1 overall with some feedback... 1) I think the list is reasonable with a few nitpicks below 2) If these are Channels and not Components, then I would probably name it SecurableChannels or SecurableCommunicationChannels or whatever. 3) I'd prefer HTTP be renamed to Web or other non-protocol word

Re: json-path-assert for json related unit tests

I think we were using the version of Jackson that was tied to the version of Swagger we were using. In our pre-gradle build, we were pulling in Jackson from directories for Swagger on gcm/where. If we upgrade Jackson and Spring, then we should check our versions of Swagger (do we have automated te

Review Request 51750: GEODE-1873: Updating geode session module to support Tomcat 7.0.70

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51750/ --- Review request for geode, Barry Oglesby, William Markito, and nabarun nag. Repo

Review Request 51734: GEODE-1864: CompactMapRangeIndex not updating old keys properly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51734/ --- Review request for geode, Barry Oglesby and nabarun nag. Repository: geode De

Review Request 51735: GEODE-1840: Certain map queries combine OR predicates into an AND junction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51735/ --- Review request for geode, Barry Oglesby and nabarun nag. Repository: geode De

Re: Review Request 51696: GEODE-1777 CI failure: RestAPIsOnMembersFunctionExecutionDUnitTest.testFunctionExecutionEOnSelectedMembers[

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51696/#review148270 --- Ship it! Ship It! - Udo Kohlmeyer On Sept. 7, 2016, 4:25 p.m

Re: Review Request 51728: GEODE-1570: upgrade spring libraries and fix tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51728/#review148269 --- Ship it! Ship It! - Udo Kohlmeyer On Sept. 8, 2016, 3:45 p.m

upgrading Spring libraries and dependent jars

Hi, I've created a review to upgrade the spring security libraries and its dependencies: https://reviews.apache.org/r/51728/ This will affect a bunch of packaged jars and also trigger changes in the license and notice files. My question is whether we should hold off this upgrade after GEODE1.0 i

Re: Review Request 51728: GEODE-1570: upgrade spring libraries and fix tests

> On Sept. 8, 2016, 8:49 p.m., Anthony Baker wrote: > > -1 Need to update LICENSE files (both in root and in geode-assembly) with > > version changes. Can you also describe how the library updates are needed > > for the security work? I couldn't make that connection from the JIRA. > > Jinmei

Re: securing geode components

As GEODE-420 deals with SSL comms configuration and GEODE-1648 with Authentication&Authorization I think we need to be careful in what is feasible and what is logical. For SSL comms it was decided that the following components are relevant [1]

Re: Review Request 51728: GEODE-1570: upgrade spring libraries and fix tests

> On Sept. 8, 2016, 8:49 p.m., Anthony Baker wrote: > > -1 Need to update LICENSE files (both in root and in geode-assembly) with > > version changes. Can you also describe how the library updates are needed > > for the security work? I couldn't make that connection from the JIRA. We are spr

Re: Review Request 51728: GEODE-1570: upgrade spring libraries and fix tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51728/#review148254 --- -1 Need to update LICENSE files (both in root and in geode-assembl

Re: securing geode components

I see that 'locator' is not represented in your proposed component list. The addition of 'locator' was one of the key points in the new SSL implementation[1]. Where would it fall in the Security components list (Management?), and would this work for SSL? [1] https://cwiki.apache.org/confluence/dis

Re: Review Request 51728: GEODE-1570: upgrade spring libraries and fix tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51728/#review148244 --- geode-assembly/src/test/resources/expected_jars.txt

securing geode components

GEODE-1648 and GEODE-420 are both trying to add geode properties to secure only some components. GEODE-1648 is intending to add a property named "security-enabled-components" that will allow users to turn off authentication/authorization for some components GEODE-420 is intending to add a property

Re: json-path-assert for json related unit tests

I just made a change to upgrade jackson and scala module to 2.8.2 On Thu, Sep 8, 2016 at 12:30 PM, Anthony Baker wrote: > Speaking of jackson, anyone know why we’re not using v2.2.0 for the scala > module? This is a dependency of geode-web-api. > > jackson.version = 2.2.0 > jackson-module-scala

Review Request 51741: [GEODE-1817] Prepare for 'release quality' publishing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51741/ --- Review request for geode, Anthony Baker and Dan Smith. Repository: geode Desc

Re: json-path-assert for json related unit tests

Speaking of jackson, anyone know why we’re not using v2.2.0 for the scala module? This is a dependency of geode-web-api. jackson.version = 2.2.0 jackson-module-scala_2.10.version = 2.1.5 Anthony > On Sep 8, 2016, at 10:32 AM, John Blum wrote: > > +1 to standardizing Geode on Jackson for JSO

Re: Review Request 51696: GEODE-1777 CI failure: RestAPIsOnMembersFunctionExecutionDUnitTest.testFunctionExecutionEOnSelectedMembers[

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51696/#review148237 --- Ship it! We might also want to change the settings in gradle/te

Re: json-path-assert for json related unit tests

+1 to standardizing Geode on Jackson for JSON processing. +1 to using JsonPath/json-path-assert for testing interactions in Geode on JSON docs. On Thu, Sep 8, 2016 at 10:22 AM, Kirk Lund wrote: > Yes, we should change all json parsing code to use jackson. However, we > still need to write unit

Re: json-path-assert for json related unit tests

Yes, we should change all json parsing code to use jackson. However, we still need to write unit tests and that's what json-path-assert is for. I've researched all of the ways to perform json assertions for unit tests and test-path-assert is currently the best. It's from com.jayway same as Awaitili

Re: json-path-assert for json related unit tests

Can we get rid of TypedJson in favor of some standard json libraries? On Thu, Sep 8, 2016 at 9:56 AM, Kirk Lund wrote: > To support fixing up unit tests that involve json, I'd like to add in a > dependency on com.jayway.jsonpath:json-path-assert. > > We already have a dependency on com.jayway.js

json-path-assert for json related unit tests

To support fixing up unit tests that involve json, I'd like to add in a dependency on com.jayway.jsonpath:json-path-assert. We already have a dependency on com.jayway.jsonpath:json-path (for spring-hateoas). json-path-assert basically adds some new Hamcrest matchers for clean assertions involving

Re: Review Request 51728: GEODE-1570: upgrade spring libraries and fix tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51728/#review148206 --- Ship it! Ship It! - Dan Smith On Sept. 8, 2016, 3:45 p.m., J

Re: Build failed in Jenkins: Geode-spark-connector #68

Looks like our scala build is looking for a snapshot geode version that doesn't exist any more. I'll fix it. -Dan On Thu, Sep 8, 2016 at 8:06 AM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See > >

Re: Review Request 51728: GEODE-1570: upgrade spring libraries and fix tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51728/#review148197 --- Ship it! Ship It! - Kirk Lund On Sept. 8, 2016, 3:45 p.m., J

Review Request 51728: GEODE-1570: upgrade spring libraries and fix tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51728/ --- Review request for geode, Kevin Duling, Kirk Lund, Udo Kohlmeyer, and Dan Smith.

Build failed in Jenkins: Geode-spark-connector #68

See -- [...truncated 833 lines...] M[info] Resolving org.scala-sbt#main;0.13.6 ... M[info] Resolving org.scala-sbt#actions;0.13.6 ... M[[0