Re: Log related test failures in GEODE

2016-10-04 Thread Kirk Lund
There were some logging changes that went in today. Not sure why the regex is failing to match now but we'll revert the changes tomorrow. -Kirk On Tuesday, October 4, 2016, Nabarun Nag wrote: >- The following tests are failing on precheck as well as in IntelliJ >Tests : >- >Cust

Log related test failures in GEODE

2016-10-04 Thread Nabarun Nag
- The following tests are failing on precheck as well as in IntelliJ Tests : - CustomConfigWithCacheIntegrationTest

Re: Review Request 52271: GEODE-1938: Big Snapshot File Read Exception via SnapshotReader API

2016-10-04 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52271/ --- (Updated Oct. 5, 2016, 12:36 a.m.) Review request for geode, Anthony Baker, Bru

[GitHub] incubator-geode pull request #253: GEODE-136: Fix possible NullPointerExcept...

2016-10-04 Thread kjduling
GitHub user kjduling opened a pull request: https://github.com/apache/incubator-geode/pull/253 GEODE-136: Fix possible NullPointerException in GetRegionsFunction Addresses an unlikely but possible NPE. Removes use of a deprecated interface. Introduces a missing unit test. Yo

Re: CI bugs

2016-10-04 Thread Udo Kohlmeyer
+1 On 5/10/2016 6:28 AM, Nabarun Nag wrote: Hi, I removed the flaky tags from the test in the WAN module. I went through the commits and made sure they had indeed removed the pauses. Please do let me know if I have missed something. Or if these these tickets should still be marked flaky. Par

[GitHub] incubator-geode issue #252: GEODE-136: Fix possible NullPointerException in ...

2016-10-04 Thread kjduling
Github user kjduling commented on the issue: https://github.com/apache/incubator-geode/pull/252 That doesn't look right... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-geode pull request #252: GEODE-136: Fix possible NullPointerExcept...

2016-10-04 Thread kjduling
Github user kjduling closed the pull request at: https://github.com/apache/incubator-geode/pull/252 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] incubator-geode pull request #252: GEODE-136: Fix possible NullPointerExcept...

2016-10-04 Thread kjduling
GitHub user kjduling opened a pull request: https://github.com/apache/incubator-geode/pull/252 GEODE-136: Fix possible NullPointerException in GetRegionsFunction You can merge this pull request into a Git repository by running: $ git pull https://github.com/kjduling/incubator-

Re: Review Request 52525: GEODE-1902: add ACCEPT and DENY tests for GEODE_VERBOSE and GEMFIRE_VERBOSE

2016-10-04 Thread Kirk Lund
> On Oct. 4, 2016, 8:57 p.m., Kevin Duling wrote: > > Some things to consider: > > * * Your teardown code is identical to the teardown code in > > CustomConfigWithLogServiceIntegrationTest. > > * Your preassertions are repeated in createConfigFile. > > * You've tested for ACCEPT and DENY. Is th

Re: Review Request 52525: GEODE-1902: add ACCEPT and DENY tests for GEODE_VERBOSE and GEMFIRE_VERBOSE

2016-10-04 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52525/#review151390 --- Ship it! Some things to consider: * * Your teardown code is ide

Re: Review Request 52524: GEODE-1927 backward compatibility support

2016-10-04 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52524/#review151388 --- Ship it! Ship It! - Hitesh Khamesra On Oct. 4, 2016, 7:36 p.

Re: Review Request 52525: GEODE-1902: add ACCEPT and DENY tests for GEODE_VERBOSE and GEMFIRE_VERBOSE

2016-10-04 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52525/#review151380 --- Ship it! Ship It! - Jinmei Liao On Oct. 4, 2016, 8:23 p.m.,

Review Request 52525: GEODE-1902: add ACCEPT and DENY tests for GEODE_VERBOSE and GEMFIRE_VERBOSE

2016-10-04 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52525/ --- Review request for geode and Kevin Duling. Bugs: GEODE-1902 https://issues.

[GitHub] incubator-geode pull request #247: Feature/geode 1902

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/247 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Review Request 52524: GEODE-1927 backward compatibility support

2016-10-04 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52524/ --- Review request for geode, Hitesh Khamesra and Udo Kohlmeyer. Bugs: GEODE-1927

Re: CI bugs

2016-10-04 Thread Kirk Lund
That's awesome. Thanks Nabarun! On Tue, Oct 4, 2016 at 12:28 PM, Nabarun Nag wrote: > Hi, > > I removed the flaky tags from the test in the WAN module. I went through > the commits and made sure they had indeed removed the pauses. > > Please do let me know if I have missed something. Or if thes

Re: CI bugs

2016-10-04 Thread Nabarun Nag
Hi, I removed the flaky tags from the test in the WAN module. I went through the commits and made sure they had indeed removed the pauses. Please do let me know if I have missed something. Or if these these tickets should still be marked flaky. ParallelGatewaySenderOperationsDUnitTest: GEODE-933

Re: Limiting scope for Geode 1.0

2016-10-04 Thread Anthony Baker
I’d like merge 8929e93bd129b303aae8f9e1b13daf3c3991d1a4 to the release branch. It contains only test changes. Sound reasonable? Also in that vein, what do you think about not running flakyTest in the Jenkins release job [1]. That would give us a clearer picture of test results and quality on

Re: Limiting scope for Geode 1.0

2016-10-04 Thread Swapnil Bawaskar
This sounds like feature creep, but based on this thread: http://markmail.org/message/fwfslt2s7yl7mqm4 do we want to target GEODE-1952 for 1.0? On Sat, Oct 1, 2016 at 12:30 AM, Swapnil Bawaskar wrote: > Thanks for the offer Anthony, > I tagged G

Re: CI bugs

2016-10-04 Thread Anthony Baker
Hi Nabarun, I think we crossed wires. In 8929e93bd129b303aae8f9e1b13daf3c3991d1a4 I added @flaky to a few bugs you just marked as resolved: GEODE-1148 GEODE-1364 GEODE-1384 GEODE-1448 Could you remove the @flaky annotation from these tests? Thanks, Anthony > On Oct 1, 2016, at 5:09 PM, Anth

Re: buildSrc prevents geode-core:test

2016-10-04 Thread Kirk Lund
Unfortunately, the --tests syntax works for UnitTests but not IntegrationTests (which are run via the integrationTest task). For some reason it hangs. I'd really like our Gradle gurus to figure out a single, common syntax that works for running one test in any of our categories. Anyone know why th

Re: CI bugs

2016-10-04 Thread Swapnil Bawaskar
+1 On Tue, Oct 4, 2016 at 10:58 AM, John Blum wrote: > +1 > > On Tue, Oct 4, 2016 at 10:11 AM, Kirk Lund wrote: > > > Please don't close flaky tickets or remove FlakyTest category unless you > > know of a specific commit revision that makes some timing changes to the > > test. Unless you replac

Re: CI bugs

2016-10-04 Thread John Blum
+1 On Tue, Oct 4, 2016 at 10:11 AM, Kirk Lund wrote: > Please don't close flaky tickets or remove FlakyTest category unless you > know of a specific commit revision that makes some timing changes to the > test. Unless you replace all the Thread.sleeps with await() calls it's > going to fail agai

Re: Geode docs: location of donated source files

2016-10-04 Thread Dave Barnes
Thanks, everyone, for the clarifications. I consolidated the doc donation files under a single directory called 'geode-docs' on branch feature/GEODE-1952. On Mon, Oct 3, 2016 at 11:26 AM, Dave Barnes wrote: > That sounds like the end result I was hoping for. > > On Mon, Oct 3, 2016 at 10:05 AM,

[GitHub] incubator-geode issue #250: Feature/geode 1948

2016-10-04 Thread kjduling
Github user kjduling commented on the issue: https://github.com/apache/incubator-geode/pull/250 Restarting this task, closing this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] incubator-geode pull request #250: Feature/geode 1948

2016-10-04 Thread kjduling
Github user kjduling closed the pull request at: https://github.com/apache/incubator-geode/pull/250 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

Re: CI bugs

2016-10-04 Thread Kirk Lund
Please don't close flaky tickets or remove FlakyTest category unless you know of a specific commit revision that makes some timing changes to the test. Unless you replace all the Thread.sleeps with await() calls it's going to fail again when GC occurs during the test. Just because a test doesn't fa

Re: How to change log level

2016-10-04 Thread Goutam Tadi
Thanks for the info. On Tue, Oct 4, 2016 at 9:53 AM John Blum wrote: > Hi Goutam- > > > Can we change it through gemfire.properties ? > > No > > However, you can use the *Gfsh* 'alter runtime' command, for instance... > > gfsh>alter runtime --log-level=config > > If you just want to change a spe

Re: How to change log level

2016-10-04 Thread John Blum
Hi Goutam- > Can we change it through gemfire.properties ? No However, you can use the *Gfsh* 'alter runtime' command, for instance... gfsh>alter runtime --log-level=config If you just want to change a specific members log-level then... gfsh>alter runtime --log-level=config --member=Server1

Re: Review Request 52518: GEODE-1963: Add lucene xsd to website

2016-10-04 Thread Joey McAllister
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52518/#review151350 --- Ship it! Ship It! - Joey McAllister On Oct. 4, 2016, 4:37 p.

Review Request 52518: GEODE-1963: Add lucene xsd to website

2016-10-04 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52518/ --- Review request for geode, Joey McAllister, William Markito, and Dan Smith. Repo

Re: Review Request 52518: GEODE-1963: Add lucene xsd to website

2016-10-04 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52518/#review151348 --- Ship it! It's a little unfortunate to have two copies of these

How to change log level

2016-10-04 Thread Goutam Tadi
Hi Community, How can one change the "log-level" of servers (already running) in geode cluster. Can we change it through gemfire.properties ? Thanks, Goutam Tadi. -- Regards, *Goutam Tadi.*

[GitHub] incubator-geode pull request #250: Feature/geode 1948

2016-10-04 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/250#discussion_r81788504 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java --- @@ -156,7 +166,14 @@ protected static Properties loadGe