Re: Deprecate DynamicRegionFactory

2016-10-11 Thread John Blum
+1 - forget deprecated; delete it. On Tue, Oct 11, 2016 at 8:22 PM, Udo Kohlmeyer wrote: > +1 - I see no real benefit for this. > > > > On 12/10/16 1:10 pm, William Markito wrote: > >> +1 - We always discouraged people using dynamic regions >> >> On Tue, Oct 11, 2016 at 4:33 PM, Dan Smith wrot

Re: Deprecate DynamicRegionFactory

2016-10-11 Thread Udo Kohlmeyer
+1 - I see no real benefit for this. On 12/10/16 1:10 pm, William Markito wrote: +1 - We always discouraged people using dynamic regions On Tue, Oct 11, 2016 at 4:33 PM, Dan Smith wrote: I'd like to reopen the discussion about deprecating DynamicRegionFactory. This is some old crufty code

Re: Deprecate DynamicRegionFactory

2016-10-11 Thread Jinmei Liao
+1 drop it if we don't want people to use it. On Tue, Oct 11, 2016 at 8:15 PM, Kirk Lund wrote: > +1 drop it as a bug with no need for replacement (or in favor of using a > function) > > On Tuesday, October 11, 2016, William Markito wrote: > > > +1 - We always discouraged people using dynamic

Re: Deprecate DynamicRegionFactory

2016-10-11 Thread Kirk Lund
+1 drop it as a bug with no need for replacement (or in favor of using a function) On Tuesday, October 11, 2016, William Markito wrote: > +1 - We always discouraged people using dynamic regions > > On Tue, Oct 11, 2016 at 4:33 PM, Dan Smith > wrote: > > > I'd like to reopen the discussion abou

Re: Review Request 52751: GEODE-1986: correctly set the flag indicating if cluster configuration service is running or not on a locator.

2016-10-11 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52751/ --- (Updated Oct. 12, 2016, 2:21 a.m.) Review request for geode, Jared Stewart, Joh

Re: Deprecate DynamicRegionFactory

2016-10-11 Thread William Markito
+1 - We always discouraged people using dynamic regions On Tue, Oct 11, 2016 at 4:33 PM, Dan Smith wrote: > I'd like to reopen the discussion about deprecating > DynamicRegionFactory. This is some old crufty code I don't think we > want anyone to use. I see we had a ticket to deprecated it > (G

Re: Using Fix Version on JIRA

2016-10-11 Thread William Markito
Thanks Swap, that sounds good. The missing part now is people using the Fix Version on the tickets before marking them as resolved. On Tue, Oct 11, 2016 at 3:38 PM, Swapnil Bawaskar wrote: > Hi William, please refer to this thread for how this should work for 1.0: > http://markmail.org/message/

Re: Review Request 52742: GEODE-1979: refactor tests using LocatorServerConfigurationRule

2016-10-11 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52742/ --- (Updated Oct. 12, 2016, 1:11 a.m.) Review request for geode, Jared Stewart, Kev

Re: Review Request 52742: GEODE-1979: refactor tests using LocatorServerConfigurationRule

2016-10-11 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52742/ --- (Updated Oct. 12, 2016, 1:10 a.m.) Review request for geode, Jared Stewart, Kev

[GitHub] incubator-geode pull request #257: Feature/geode 1952

2016-10-11 Thread joeymcallister
GitHub user joeymcallister opened a pull request: https://github.com/apache/incubator-geode/pull/257 Feature/geode 1952 Adds `geode-book` directory for building the end-user documentation from the content in the `geode-docs` directory. Updates the `geode-docs` README for building t

Review Request 52759: GEODE-1991: Removing sleeps from HARegionQueueJUnitTest

2016-10-11 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52759/ --- Review request for geode, nabarun nag and xiaojian zhou. Repository: geode De

Re: Review Request 52750: GEODE-1985: Check for index expression reevalaution using a time window

2016-10-11 Thread Dan Smith
> On Oct. 11, 2016, 10:11 p.m., Jason Huynh wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java, > > line 371 > > > > > > Was this intended for this diff? Ah, that was supposed

Deprecate DynamicRegionFactory

2016-10-11 Thread Dan Smith
I'd like to reopen the discussion about deprecating DynamicRegionFactory. This is some old crufty code I don't think we want anyone to use. I see we had a ticket to deprecated it (GEODE-388), but we chose not to do it because we don't have an alternative API to create regions from the client (GEODE

Spring Data Geode 1.0.0.APACHE-GEODE-INCUBATING-M3 Released!

2016-10-11 Thread John Blum
Now, many Moons overdue, and for that, I apologize to both the Spring and Apache Geode communities for the delay, however, I am extremely pleased to officially announce the release of *Spring Data Geode* with support for Apache Geode 1.0.0-incubating.M3. Bits in Maven Central [1]. *So, why should

Re: Using Fix Version on JIRA

2016-10-11 Thread Swapnil Bawaskar
Hi William, please refer to this thread for how this should work for 1.0: http://markmail.org/message/lmxtps7clvyphpg2 On Mon, Oct 10, 2016 at 10:02 PM, William Markito wrote: > This may sound like a simple and not really important, but it's key to > track issues and which release the fix is par

[GitHub] incubator-geode pull request #256: Feature/geode 1532

2016-10-11 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/256#discussion_r82900400 --- Diff: geode-pulse/src/main/webapp/WEB-INF/spring-security.xml --- @@ -20,15 +20,14 @@ xmlns:context="http://www.springframework.org/sch

[GitHub] incubator-geode pull request #256: Feature/geode 1532

2016-10-11 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/256#discussion_r82900331 --- Diff: geode-pulse/build.gradle --- @@ -68,6 +68,11 @@ dependencies { testCompile project(':geode-core') testCompile files(project

Re: Review Request 52750: GEODE-1985: Check for index expression reevalaution using a time window

2016-10-11 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52750/#review152219 --- Fix it, then Ship it! geode-core/src/main/java/org/apache/geod

Review Request 52750: GEODE-1985: Check for index expression reevalaution using a time window

2016-10-11 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52750/ --- Review request for geode, Jason Huynh and nabarun nag. Repository: geode Desc

Review Request 52751: GEODE-1986: correctly set the flag indicating if cluster configuration service is running or not on a locator.

2016-10-11 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52751/ --- Review request for geode, Jared Stewart, John Blum, Kevin Duling, and Kirk Lund.

Re: Review Request 52725: GEODE-1801: Amended Logic to increment nonSingleHopsCount

2016-10-11 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52725/ --- (Updated Oct. 11, 2016, 8:37 p.m.) Review request for geode, Bruce Schuchardt a

Re: Review Request 52725: GEODE-1801: Amended Logic to increment nonSingleHopsCount

2016-10-11 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52725/#review152162 --- I think it is very important not to do reformatting with other fix

Re: Review Request 52575: GEODE-1962: increment notQueuedConflated stat is peeked object is unresolvable from off heap

2016-10-11 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52575/#review152160 --- Ship it! Ship It! - Dan Smith On Oct. 5, 2016, 9:28 p.m., Ja

Re: Review Request 52724: GEODE-1570: improve rest security framework

2016-10-11 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52724/#review152154 --- Ship it! I like the new annotations! The controllers can be cl

Review Request 52742: GEODE-1979: refactor tests using LocatorServerConfigurationRule

2016-10-11 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52742/ --- Review request for geode. Repository: geode Description --- GEODE-1979:

[GitHub] incubator-geode pull request #256: Feature/geode 1532

2016-10-11 Thread jaredjstewart
GitHub user jaredjstewart opened a pull request: https://github.com/apache/incubator-geode/pull/256 Feature/geode 1532 GEODE-999: Convert pulse uiTests to phantomJS. GEODE-1966: Prevent unauthorized users from viewing pulseVersion details. GEODE-1532: Fix Pulse clickjacking v

Jenkins build is back to normal : Geode-release #33

2016-10-11 Thread Apache Jenkins Server
See