pimped PlaceholdersTest

Hi folks! I've switched the PlaceholdersTest from using the internal Placeholders class to the official API. While doing so I figured that we should not yet add this functionality at all. But first we should discuss this through with mp and ConfigJSR. The reason is that variable replacement is

Re: [VOTE] Release JWT Auth 1.0.0

Le dim. 3 juin 2018 21:36, Mark Struberg a écrit : > Yes, John please also read my review. I've looked at the same classes as > well and compared them The only thing which is the same is indeed the > signature. So this is fine as it seems to be a rewrite. But of course I'd > also remove it in the

Re: Move Geronimo MP Config from SVN to GITBOX

No vote but seems there is a consensus too otherwise somebody would/should have complained since last discussion Le dim. 3 juin 2018 21:39, Mark Struberg a écrit : > Was there any vote? > > Can you call a vote plz? > > LieGrue, > strub > > > Am 02.06.2018 um 22:50 schrieb Jean-Louis MONTEIRO : >

Re: Move Geronimo MP Config from SVN to GITBOX

Was there any vote? Can you call a vote plz? LieGrue, strub > Am 02.06.2018 um 22:50 schrieb Jean-Louis MONTEIRO : > > How long has the vote been up for? > > Le samedi 2 juin 2018, Romain Manni-Bucau a écrit : > Dont think there is much risk and worse case we can still use svn, right? > > Le

Re: [VOTE] Release JWT Auth 1.0.0

Yes, John please also read my review. I've looked at the same classes as well and compared them The only thing which is the same is indeed the signature. So this is fine as it seems to be a rewrite. But of course I'd also remove it in the future to ensure we really use the same API. Otoh the re

Re: [VOTE] Release JWT Auth 1.0.0

The copied code is very localized, from memory I copied the claim enum (mainly to guarantee the ordinal). Except that it is mainly a normal API rewrite. Think a diff should show that it is not just copied. Also the javadoc is 100% from scratch. Romain Manni-Bucau @rmannibucau

Re: Is JWT Auth Portable?

We don't test it right. Originally I didn't want to go through N modules for that or N profiles we or contributors forget to run. Have in my TODO list an item to add the ability to use one dependency set per execution to surefire (I think today you need to list all artifacts cause it is not trans

Re: [VOTE] Release JWT Auth 1.0.0

It looks like you imported code from Eclipse, but changed the headers to indicate it's licensed to the ASF. On Sun, Jun 3, 2018 at 11:29 AM Romain Manni-Bucau wrote: > @John: what's the questionably part? > > > Romain Manni-Bucau > @rmannibucau | Blog >

Re: Is JWT Auth Portable?

Ok, but that indicates we don't know if this is portable right? On Sun, Jun 3, 2018 at 11:28 AM Romain Manni-Bucau wrote: > Hi John, > > Meecrowave and OWB (this one just set until next Meecrowave is upgraded > due to an OWB bug) are in scope *test*. > There is nothing linked to them in the impl

Re: [VOTE] Release JWT Auth 1.0.0

@John: what's the questionably part? Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book

Re: Is JWT Auth Portable?

Hi John, Meecrowave and OWB (this one just set until next Meecrowave is upgraded due to an OWB bug) are in scope *test*. There is nothing linked to them in the impl and got some feedback it works on any server implementing CDI (AFAIK it runs on weld and TomEE 8 OOTB, didnt test others). Romain Ma

Re: [VOTE] Release JWT Auth 1.0.0

-1 since there's questionably licensed files in https://github.com/apache/geronimo-jwt-auth/tree/master/geronimo-microprofile-jwt-auth-spec/src/main/java/org/eclipse/microprofile On Sun, Jun 3, 2018 at 3:44 AM Romain Manni-Bucau wrote: > Up + FYI we pass the tck 1.1 so no need to do another vot

Is JWT Auth Portable?

I saw that the JWT Auth project only uses OWB and Meecrowave. It does not have tests against Weld, which makes me think its not portable. Why is it a part of Geronimo then?

Re: [VOTE] Release JWT Auth 1.0.0

Up + FYI we pass the tck 1.1 so no need to do another vote just to change TCK version since we dont deliver them and are compliant, yeah :) Romain Manni-Bucau @rmannibucau | Blog | Old Blog |

[GitHub] rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things

rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things URL: https://github.com/apache/geronimo-jwt-auth/pull/2#discussion_r192568355 ## File path: geronimo-jwt-auth-impl/src/test/resources/tck.xml ## @@ -40,8 +40,6 @@

[GitHub] rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things

rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things URL: https://github.com/apache/geronimo-jwt-auth/pull/2#discussion_r192568355 ## File path: geronimo-jwt-auth-impl/src/test/resources/tck.xml ## @@ -40,8 +40,6 @@

[GitHub] rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things

rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things URL: https://github.com/apache/geronimo-jwt-auth/pull/2#discussion_r192568348 ## File path: geronimo-jwt-auth-impl/src/main/java/org/apache/geronimo/microprofile/impl/jwtauth/