Re: OpenEJB PK issue

2005-12-16 Thread Manu George
Hi Gianny,     I am not much familiar to the open-ejb/tranql codebase . But I plan to get a lot more familiar to it. I have put in a fix for the issue though I am not sure how appropriate it is as I am yet to get a complete picture of the working of openejb/tranQL. The JIRA issue is htt

Re: OpenEJB PK issue

2005-12-15 Thread Gianny Damour
Hi Manu, Once again, thanks for your debugging! I had a look to the DD and I have identified why the itests showing this specifc case are working for us and not for you: basically in our test, we have a OTM relationship between a CMP with a simple PK on the one-side and a CMP with a compound

OpenEJB PK issue

2005-12-15 Thread Manu George
Hi Gianny,     I put in a dirty hack and got my app working. The problem I was facing was in the  private LinkedHashMap createCMPFieldAccessors(SQLQueryBuilder queryBuilder, LinkedHashMap cmrFieldAccessor) throws QueryException { method in CMPContainerBuilder Here there is a   if (nul

Re: OpenEJB PK issue

2005-12-14 Thread Gianny Damour
You are right! And thanks for reviewing my commits :) Indeed, buildFaultHandler is still creating the wrong type of IdentityDefiner. I thought that all dependencies on the various IdentityDefiner implementations were removed from OpenEJB thanks to the introduction of IdentityDefinerBuilder; ob

OpenEJB PK issue

2005-12-14 Thread Manu George
Hi Gianny,     Was just seeing the fix you made. 1 question on that. In CMPContainerBuilder there are 2 methods private FaultHandler buildFaultHandler(SQLQueryBuilder queryBuilder, EJB definingEJB, CMRField field, int slot, boolean prefetch) throws QueryException and  private Linked