Re: svn commit: r724558 - in /geronimo/server/trunk: ./ plugingroups/javaee5-jetty/ plugingroups/javaee5-jetty/src/main/history/ plugingroups/javaee5-tomcat/ plugingroups/javaee5-tomcat/src/main/histo

2008-12-09 Thread Jarek Gawor
If we are switching to activemq5 why do we need this ${activemqString} substitution? Jarek On Mon, Dec 8, 2008 at 6:59 PM, [EMAIL PROTECTED] wrote: Author: djencks Date: Mon Dec 8 15:59:58 2008 New Revision: 724558 URL: http://svn.apache.org/viewvc?rev=724558view=rev Log: GERONIMO-4337

Re: svn commit: r724558 - in /geronimo/server/trunk: ./ plugingroups/javaee5-jetty/ plugingroups/javaee5-jetty/src/main/history/ plugingroups/javaee5-tomcat/ plugingroups/javaee5-tomcat/src/main/histo

2008-12-09 Thread Donald Woods
One of 2 good questions... The ${activemqString} was put in there by Jencks, so I just kept using it, but it should probably be removed. Also, I don't like the renaming to activemq5-* for our modules/cars, as now both our Samples and user apps will have to be updated to use the new CAR

Re: svn commit: r724558 - in /geronimo/server/trunk: ./ plugingroups/javaee5-jetty/ plugingroups/javaee5-jetty/src/main/history/ plugingroups/javaee5-tomcat/ plugingroups/javaee5-tomcat/src/main/histo

2008-12-09 Thread Jason Dillon
Why do we need 2 sets of activemq modules? If the new ones work, then lets just use them. --jason On Dec 9, 2008, at 9:26 PM, Donald Woods wrote: One of 2 good questions... The ${activemqString} was put in there by Jencks, so I just kept using it, but it should probably be removed.

Re: svn commit: r724558 - in /geronimo/server/trunk: ./ plugingroups/javaee5-jetty/ plugingroups/javaee5-jetty/src/main/history/ plugingroups/javaee5-tomcat/ plugingroups/javaee5-tomcat/src/main/histo

2008-12-09 Thread Joe Bohn
Donald Woods wrote: One of 2 good questions... The ${activemqString} was put in there by Jencks, so I just kept using it, but it should probably be removed. Also, I don't like the renaming to activemq5-* for our modules/cars, as now both our Samples and user apps will have to be updated to

Re: svn commit: r724558 - in /geronimo/server/trunk: ./ plugingroups/javaee5-jetty/ plugingroups/javaee5-jetty/src/main/history/ plugingroups/javaee5-tomcat/ plugingroups/javaee5-tomcat/src/main/histo

2008-12-09 Thread Donald Woods
The old AMQ4 modules just haven't been removed yet (David just made the switch to AMQ5 yesterday...) I'll work on it today. -Donald Jason Dillon wrote: Why do we need 2 sets of activemq modules? If the new ones work, then lets just use them. --jason On Dec 9, 2008, at 9:26 PM, Donald

Re: svn commit: r724558 - in /geronimo/server/trunk: ./ plugingroups/javaee5-jetty/ plugingroups/javaee5-jetty/src/main/history/ plugingroups/javaee5-tomcat/ plugingroups/javaee5-tomcat/src/main/histo

2008-12-09 Thread Donald Woods
Cool. I have trunk building again with my latest commits (using the activemq5-* named modules), so now I'll go remove the old AMQ4 modules and rename the AMQ5 ones back to the old names, so we don't break Samples and user apps. (And I'll also update the TCK porting files.) -Donald Joe

Re: svn commit: r724558 - in /geronimo/server/trunk: ./ plugingroups/javaee5-jetty/ plugingroups/javaee5-jetty/src/main/history/ plugingroups/javaee5-tomcat/ plugingroups/javaee5-tomcat/src/main/histo

2008-12-09 Thread Jason Warner
Donald, you said it build for you? I get the following error when I try to build. org.apache.maven.reactor.MavenExecutionException: Could not find the model file '/Users/jason/trunk/plugins/activemq5'. for project unknown at org.apache.maven.DefaultMaven.getProjects(DefaultMaven.java:378)

Re: svn commit: r724558 - in /geronimo/server/trunk: ./ plugingroups/javaee5-jetty/ plugingroups/javaee5-jetty/src/main/history/ plugingroups/javaee5-tomcat/ plugingroups/javaee5-tomcat/src/main/histo

2008-12-09 Thread Donald Woods
It was working for about 30 mins (Rev724709 thru 724732). Looks like you caught it in the middle of the activemq5 -- activemq renames after I had the old layout working. I think all of the renames are in as of Rev724760, but my local build is still running... -Donald Jason Warner wrote:

Re: svn commit: r724558 - in /geronimo/server/trunk: ./ plugingroups/javaee5-jetty/ plugingroups/javaee5-jetty/src/main/history/ plugingroups/javaee5-tomcat/ plugingroups/javaee5-tomcat/src/main/histo

2008-12-09 Thread Jason Warner
You are correct. I'm just an eager beaver. It's building fine now so far. On Tue, Dec 9, 2008 at 10:43 AM, Donald Woods [EMAIL PROTECTED] wrote: It was working for about 30 mins (Rev724709 thru 724732). Looks like you caught it in the middle of the activemq5 -- activemq renames after I

Re: svn commit: r724558 - in /geronimo/server/trunk: ./ plugingroups/javaee5-jetty/ plugingroups/javaee5-jetty/src/main/history/ plugingroups/javaee5-tomcat/ plugingroups/javaee5-tomcat/src/main/histo

2008-12-09 Thread David Jencks
On Dec 9, 2008, at 6:26 AM, Donald Woods wrote: One of 2 good questions... The ${activemqString} was put in there by Jencks, so I just kept using it, but it should probably be removed. Also, I don't like the renaming to activemq5-* for our modules/cars, as now both our Samples and user

Re: svn commit: r724558 - in /geronimo/server/trunk: ./ plugingroups/javaee5-jetty/ plugingroups/javaee5-jetty/src/main/history/ plugingroups/javaee5-tomcat/ plugingroups/javaee5-tomcat/src/main/histo

2008-12-09 Thread Donald Woods
I don't agree with changing module/config names just to denote we're using a newer version of a depend. It had immediate impacts on Daytrader, Samples and any Users' app that had to refer to server plugins as a depend, like - In daytrader/trunk - daytrader-jetty/pom.xml -

Re: svn commit: r724558 - in /geronimo/server/trunk: ./ plugingroups/javaee5-jetty/ plugingroups/javaee5-jetty/src/main/history/ plugingroups/javaee5-tomcat/ plugingroups/javaee5-tomcat/src/main/histo

2008-12-09 Thread Donald Woods
Sorry, but can you create a patch from your existing plugins/activemq5 dir, then rename the dir to something like activemq5.save, svn up, edit the patch file to change the dir names from activemq5 to activemq and then apply the patch to the renamed dirs? Maybe that will keep you from a lot of