Re: Review Request: Create BinaryCombiner ands specialized message store for it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7975/#review13385 --- Ship it! +1, thanks Maja! Please make sure 'mvn clean install' work

Re: Review Request: Create BinaryCombiner ands specialized message store for it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7975/ --- (Updated Nov. 13, 2012, 4:40 a.m.) Review request for giraph. Changes ---

Re: Review Request: Create BinaryCombiner ands specialized message store for it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7975/#review13375 --- This is almost ready to go. Looks great, although I will need to get

Re: Review Request: Create BinaryCombiner ands specialized message store for it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7975/ --- (Updated Nov. 12, 2012, 6:39 p.m.) Review request for giraph. Changes ---

Re: Review Request: Create BinaryCombiner ands specialized message store for it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7975/#review13307 --- I don't have a super strong preference, but to me it seems like we sh

Re: Review Request: Create BinaryCombiner ands specialized message store for it

> On Nov. 9, 2012, 1:59 a.m., Alessandro Presta wrote: > > http://svn.apache.org/repos/asf/giraph/trunk/giraph/src/main/java/org/apache/giraph/graph/BinaryCombiner.java, > > line 47 > > > > > > Do we have evidence that

Re: Review Request: Create BinaryCombiner ands specialized message store for it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7975/ --- (Updated Nov. 9, 2012, 10:34 p.m.) Review request for giraph. Changes ---

Re: Review Request: Create BinaryCombiner ands specialized message store for it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7975/#review13277 --- The empty interface solution works, but it may be confusing for the u

Re: Review Request: Create BinaryCombiner ands specialized message store for it

> On Nov. 9, 2012, 1:59 a.m., Alessandro Presta wrote: > > The results look good. How does the no-combiner version fare in these same > > benchmarks? > > > > Frankly, at this point I would just go for one combiner interface (the > > binary one). > > No need to use it in the disk-backed message

Re: Review Request: Create BinaryCombiner ands specialized message store for it

> On Nov. 9, 2012, 1:59 a.m., Alessandro Presta wrote: > > The results look good. How does the no-combiner version fare in these same > > benchmarks? > > > > Frankly, at this point I would just go for one combiner interface (the > > binary one). > > No need to use it in the disk-backed message

Re: Review Request: Create BinaryCombiner ands specialized message store for it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7975/#review13268 --- The results look good. How does the no-combiner version fare in these

Re: Review Request: Create BinaryCombiner ands specialized message store for it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7975/ --- (Updated Nov. 9, 2012, 1:44 a.m.) Review request for giraph. Changes ---

Re: Review Request: Create BinaryCombiner ands specialized message store for it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7975/#review13263 --- This patch is not finished, one thing I wanted to hear your input on

Review Request: Create BinaryCombiner ands specialized message store for it

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7975/ --- Review request for giraph. Description --- Current combiner interface is ve