Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

phet commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586776782 ## gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java: ## @@ -244,9 +250,10 @@ public void createTopologySpec() { }

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

phet commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586776782 ## gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java: ## @@ -244,9 +250,10 @@ public void createTopologySpec() { }

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

arjun4084346 commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586760198 ## gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java: ## @@ -244,9 +250,10 @@ public void createTopologySpec()

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

phet commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586737313 ## gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java: ## @@ -219,8 +199,6 @@ private AddSpecResponse

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

phet commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586737313 ## gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java: ## @@ -219,8 +199,6 @@ private AddSpecResponse

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

phet commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586737313 ## gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java: ## @@ -219,8 +199,6 @@ private AddSpecResponse

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

phet commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586730784 ## gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java: ## @@ -244,9 +250,10 @@ public void createTopologySpec() { }

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

phet commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586730784 ## gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java: ## @@ -244,9 +250,10 @@ public void createTopologySpec() { }

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

phet commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586726855 ## gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java: ## @@ -114,6 +119,8 @@ public void setup() throws Exception {

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

arjun4084346 commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586719870 ## gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java: ## @@ -219,8 +199,6 @@ private AddSpecResponse

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

arjun4084346 commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586717102 ## gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java: ## @@ -244,9 +250,10 @@ public void createTopologySpec()

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

arjun4084346 commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586706509 ## gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java: ## @@ -114,6 +119,8 @@ public void setup() throws

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

phet commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586649678 ## gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java: ## @@ -244,9 +250,10 @@ public void createTopologySpec() { }

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

phet commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586649678 ## gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java: ## @@ -244,9 +250,10 @@ public void createTopologySpec() { }

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

phet commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586640513 ## gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java: ## @@ -114,6 +119,8 @@ public void setup() throws Exception {

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

arjun4084346 commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586634905 ## gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java: ## @@ -73,12 +74,12 @@ public class

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

umustafi commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586537330 ## gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java: ## @@ -73,12 +74,12 @@ public class

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

umustafi commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586473269 ## gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java: ## @@ -73,12 +74,12 @@ public class

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

arjun4084346 commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1585928924 ## gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java: ## @@ -73,12 +74,12 @@ public class

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

arjun4084346 commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1585928379 ## gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java: ## @@ -97,35 +97,13 @@ public abstract class

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

umustafi commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1583972758 ## gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java: ## @@ -73,12 +74,12 @@ public class

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

Will-Lo commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1583251020 ## gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java: ## @@ -97,35 +97,13 @@ public abstract class