Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/61#issuecomment-221799177
Thanks @lewismc @djkevincr ! This looks much more to what we needed :D
Awesome work!
---
If your project is set up for it, you can reply to this email and have your
rep
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/61#issuecomment-221791522
Thank you @djkevincr if you could
1) name your commit message and hence Github issue after the Jira ticket,
it means the Github hooks work perfectly.
2) Squash your
Github user asfgit closed the pull request at:
https://github.com/apache/gora/pull/61
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/61#issuecomment-221270919
I am +1 for this patch. Any comments @renato2099
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user djkevincr commented on the pull request:
https://github.com/apache/gora/pull/61#issuecomment-221264044
@lewismc +1 I have removed all the changes I did to Persistent
class/compiler as per the @renato2099 review. I added some changes to
deleteByQuery(Query query) and getPe
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/61#issuecomment-221259954
We need to ensure that the additions to the persistent class/compiler do
not render data which has already been written useless!
---
If your project is set up for it, you
Github user djkevincr commented on the pull request:
https://github.com/apache/gora/pull/61#issuecomment-221124233
@lewismc @renato2099 Is there anything which I could help here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user djkevincr commented on the pull request:
https://github.com/apache/gora/pull/61#issuecomment-215446689
@renato2099 +1, I also agree with your concerns. However I had to make some
changes to MemStore getPersistent(T obj, String[] fields) to work as expected.
I have further
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/61#issuecomment-215258302
it's pretty cool stuff @djkevincr ! But I think we need to go over it. My
main concern is the addition of the clearField method to the Persistent class.
Two main thought
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/61#issuecomment-215107783
@renato2099 any comments here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user djkevincr commented on the pull request:
https://github.com/apache/gora/pull/61#issuecomment-214959860
@lewismc Thanks for the hints, will make sure those are followed from next
time. Please review and let me know if there any concerns.
---
If your project is set up for i
Github user lewismc commented on the pull request:
https://github.com/apache/gora/pull/61#issuecomment-214878365
@djkevincr thanks for this PR.
Some hints; when you open an issue here and make your commit message, if
you are able to make the JIRA issue and Commit message the same,
GitHub user djkevincr opened a pull request:
https://github.com/apache/gora/pull/61
GORA_447 NPE Fix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/djkevincr/gora GORA_225
Alternatively you can review and apply these changes as
13 matches
Mail list logo
