[jira] [Commented] (GORA-666) Add support for the Kudu datastore in GoraExplorer

2020-10-30 Thread Alfonso Nishikawa (Jira)
. Thank you, [~arqgabyortiz]! > Add support for the Kudu datastore in GoraExplorer > -- > > Key: GORA-666 > URL: https://issues.apache.org/jira/browse/GORA-666 > Project: Apache Gora >

[jira] [Resolved] (GORA-666) Add support for the Kudu datastore in GoraExplorer

2020-10-30 Thread Alfonso Nishikawa (Jira)
[ https://issues.apache.org/jira/browse/GORA-666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alfonso Nishikawa resolved GORA-666. Resolution: Fixed > Add support for the Kudu datastore in GoraExplo

[jira] [Updated] (GORA-666) Add support for the Kudu datastore in GoraExplorer

2020-10-30 Thread Alfonso Nishikawa (Jira)
[ https://issues.apache.org/jira/browse/GORA-666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alfonso Nishikawa updated GORA-666: --- Fix Version/s: 1.0 > Add support for the Kudu datastore in GoraExplo

[jira] [Resolved] (GORA-557) Add support for MongoDB to GoraExplorer

2020-10-30 Thread Alfonso Nishikawa (Jira)
[ https://issues.apache.org/jira/browse/GORA-557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alfonso Nishikawa resolved GORA-557. Resolution: Fixed > Add support for MongoDB to GoraExplo

[jira] [Commented] (GORA-557) Add support for MongoDB to GoraExplorer

2020-10-30 Thread Alfonso Nishikawa (Jira)
. Thank you, [~mariia.podorvanova]! > Add support for MongoDB to GoraExplorer > --- > > Key: GORA-557 > URL: https://issues.apache.org/jira/browse/GORA-557 > Project: Apache Gora > Is

[jira] [Updated] (GORA-557) Add support for MongoDB to GoraExplorer

2020-10-30 Thread Alfonso Nishikawa (Jira)
[ https://issues.apache.org/jira/browse/GORA-557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alfonso Nishikawa updated GORA-557: --- Fix Version/s: 1.0 > Add support for MongoDB to GoraExplo

[jira] [Commented] (GORA-665) Add support for the Ignite datastore in GoraExplorer

2020-10-30 Thread Alfonso Nishikawa (Jira)
Add support for the Ignite datastore in GoraExplorer > > > Key: GORA-665 > URL: https://issues.apache.org/jira/browse/GORA-665 > Project: Apache Gora > Issue Type: New Feature >

[jira] [Resolved] (GORA-665) Add support for the Ignite datastore in GoraExplorer

2020-10-30 Thread Alfonso Nishikawa (Jira)
[ https://issues.apache.org/jira/browse/GORA-665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alfonso Nishikawa resolved GORA-665. Resolution: Fixed > Add support for the Ignite datastore in GoraExplo

[jira] [Updated] (GORA-665) Add support for the Ignite datastore in GoraExplorer

2020-10-30 Thread Alfonso Nishikawa (Jira)
[ https://issues.apache.org/jira/browse/GORA-665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alfonso Nishikawa updated GORA-665: --- Fix Version/s: 1.0 > Add support for the Ignite datastore in GoraExplo

[GitHub] [gora] jhnmora000 commented on a change in pull request #231: GORA-557 Add support for MongoDB to GoraExplorer

2020-10-29 Thread GitBox
jhnmora000 commented on a change in pull request #231: URL: https://github.com/apache/gora/pull/231#discussion_r514816245 ## File path: gora-mongodb/src/main/java/org/apache/gora/mongodb/store/MongoStoreMetadataAnalyzer.java ## @@ -0,0 +1,67 @@ +/** + * Licensed to the Apache

[GitHub] [gora] jhnmora000 commented on a change in pull request #232: Add support for the Kudu datastore in GoraExplorer

2020-10-29 Thread GitBox
jhnmora000 commented on a change in pull request #232: URL: https://github.com/apache/gora/pull/232#discussion_r514782899 ## File path: gora-kudu/pom.xml ## @@ -93,7 +93,7 @@ org.apache.maven.plugins maven-surefire-plugin - true +

[GitHub] [gora] alfonsonishikawa commented on a change in pull request #228: [GORA-665] - Add support for the Ignite datastore in GoraExplorer

2020-10-29 Thread GitBox
alfonsonishikawa commented on a change in pull request #228: URL: https://github.com/apache/gora/pull/228#discussion_r514614524 ## File path: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteTableMetadata.java ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache

[GitHub] [gora] alfonsonishikawa commented on a change in pull request #232: Add support for the Kudu datastore in GoraExplorer

2020-10-29 Thread GitBox
alfonsonishikawa commented on a change in pull request #232: URL: https://github.com/apache/gora/pull/232#discussion_r514616517 ## File path: gora-kudu/src/main/java/org/apache/gora/kudu/store/KuduStoreMetadataAnalyzer.java ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache

[GitHub] [gora] alfonsonishikawa commented on pull request #231: GORA-557 Add support for MongoDB to GoraExplorer

2020-10-29 Thread GitBox
alfonsonishikawa commented on pull request #231: URL: https://github.com/apache/gora/pull/231#issuecomment-719069057 Oh! And we would need a test for MongoStoreMetadataAnalyzer :S This is an automated message from the Apache

[GitHub] [gora] mgov88 opened a new pull request #232: Add support for the Kudu datastore in GoraExplorer

2020-10-29 Thread GitBox
mgov88 opened a new pull request #232: URL: https://github.com/apache/gora/pull/232 Add metadata analyzer feature in KUDU for GoraExplorer support. This is an automated message from the Apache Git Service. To respond

[GitHub] [gora] alfonsonishikawa commented on pull request #231: GORA-557 Add support for MongoDB to GoraExplorer

2020-10-29 Thread GitBox
alfonsonishikawa commented on pull request #231: URL: https://github.com/apache/gora/pull/231#issuecomment-719066358 > Since MongoDB has collections instead of tables and these collections do not necessarily have a schema, I decided to use random collection document's key set. I

[GitHub] [gora] alfonsonishikawa removed a comment on pull request #231: GORA-557 Add support for MongoDB to GoraExplorer

2020-10-29 Thread GitBox
alfonsonishikawa removed a comment on pull request #231: URL: https://github.com/apache/gora/pull/231#issuecomment-719065268 This pull request looks good to me. If no one comments anything I will merge it tomorrow. This is

[GitHub] [gora] alfonsonishikawa commented on pull request #231: GORA-557 Add support for MongoDB to GoraExplorer

2020-10-29 Thread GitBox
alfonsonishikawa commented on pull request #231: URL: https://github.com/apache/gora/pull/231#issuecomment-719065268 This pull request looks good to me. If no one comments anything I will merge it tomorrow. This is an

[GitHub] [gora] mgov88 commented on pull request #228: [GORA-665] - Add support for the Ignite datastore in GoraExplorer

2020-10-29 Thread GitBox
mgov88 commented on pull request #228: URL: https://github.com/apache/gora/pull/228#issuecomment-718981167 @alfonsonishikawa I developed the Metadata Analyzer feature and a test, I had to update the ignite version, I can not find the schema information of the tables in the older version.

[GitHub] [gora] podorvanova opened a new pull request #231: GORA-557 Add support for MongoDB to GoraExplorer

2020-10-29 Thread GitBox
podorvanova opened a new pull request #231: URL: https://github.com/apache/gora/pull/231 Since MongoDB has collections instead of tables and these collections do not necessarily have a schema, I decided to use random collection document's key set.

[GitHub] [gora] alfonsonishikawa commented on pull request #228: [GORA-665] - Add support for the Ignite datastore in GoraExplorer

2020-10-28 Thread GitBox
alfonsonishikawa commented on pull request #228: URL: https://github.com/apache/gora/pull/228#issuecomment-718213725 @mgov88 I find we will need the metadata analyzer for Ignite too to have fully support of the features related to GoraExplorer. Thank you

[GitHub] [gora] mgov88 commented on pull request #228: [GORA-665] - Add support for the Ignite datastore in GoraExplorer

2020-10-28 Thread GitBox
mgov88 commented on pull request #228: URL: https://github.com/apache/gora/pull/228#issuecomment-718227118 @alfonsonishikawa Hi, I took a look of HBase metadata analyzer

[GitHub] [gora] alfonsonishikawa edited a comment on pull request #228: [GORA-665] - Add support for the Ignite datastore in GoraExplorer

2020-10-28 Thread GitBox
alfonsonishikawa edited a comment on pull request #228: URL: https://github.com/apache/gora/pull/228#issuecomment-718234821 > @alfonsonishikawa Hi, I took a look of HBase metadata analyzer

[GitHub] [gora] alfonsonishikawa commented on pull request #228: [GORA-665] - Add support for the Ignite datastore in GoraExplorer

2020-10-28 Thread GitBox
alfonsonishikawa commented on pull request #228: URL: https://github.com/apache/gora/pull/228#issuecomment-718235012 Oh! And the primary key! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [gora] alfonsonishikawa commented on pull request #228: [GORA-665] - Add support for the Ignite datastore in GoraExplorer

2020-10-28 Thread GitBox
alfonsonishikawa commented on pull request #228: URL: https://github.com/apache/gora/pull/228#issuecomment-718234821 > @alfonsonishikawa Hi, I took a look of HBase metadata analyzer

[jira] [Assigned] (GORA-665) Add support for the Ignite datastore in GoraExplorer

2020-10-28 Thread Alfonso Nishikawa (Jira)
[ https://issues.apache.org/jira/browse/GORA-665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alfonso Nishikawa reassigned GORA-665: -- Assignee: Gaby Ortiz > Add support for the Ignite datastore in GoraExplo

[jira] [Assigned] (GORA-666) Add support for the Kudu datastore in GoraExplorer

2020-10-28 Thread Alfonso Nishikawa (Jira)
[ https://issues.apache.org/jira/browse/GORA-666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alfonso Nishikawa reassigned GORA-666: -- Assignee: Gaby Ortiz > Add support for the Kudu datastore in GoraExplo

[jira] [Commented] (GORA-557) Add support for MongoDB to GoraExplorer

2020-10-27 Thread Alfonso Nishikawa (Jira)
about the metadata analyzer: https://translate.google.com/translate?sl=es=en=https://redmine.nishilua.com/projects/goraexplorer/wiki/Obtenci%25C3%25B3n_de_metadatos_de_las_BBDD_nativas (I Googletranslated it from Spanish). One of the constructors of DataStoreMetadataFactory receives a Properties

[jira] [Commented] (GORA-557) Add support for MongoDB to GoraExplorer

2020-10-27 Thread Mariia Podorvanova (Jira)
are configured when creating a connection, but I am struggling to find how to access properties from MongoStoreDataAnalyzer. Do you know how I can access them? > Add support for MongoDB to GoraExplorer > --- > > Key: GORA-557 >

[jira] [Commented] (GORA-557) Add support for MongoDB to GoraExplorer

2020-10-27 Thread Alfonso Nishikawa (Jira)
as "the second task of the ticket"? The second bullet point or "A plus would be implement the support in GoraExplorer so it will be possible to manage MongoDB data visually"? If it is the "blahblahblah data visually", when creating a connection there is a "hadoop

[jira] [Commented] (GORA-666) Add support for the Kudu datastore in GoraExplorer

2020-10-27 Thread Gaby Ortiz (Jira)
will try to implement the missing feature.     > Add support for the Kudu datastore in GoraExplorer > -- > > Key: GORA-666 > URL: https://issues.apache.org/jira/browse/GORA-666 > Pr

[jira] [Commented] (GORA-557) Add support for MongoDB to GoraExplorer

2020-10-27 Thread Mariia Podorvanova (Jira)
the second task of the ticket. I do not quite get how does the configuration in Gora Explorer work. Hadoop configuration is being used for HBaseStore, is it expected of me to also use Hadoop configuration to open connection with MongoDB?  > Add support for MongoDB to GoraExplo

[jira] [Commented] (GORA-666) Add support for the Kudu datastore in GoraExplorer

2020-10-26 Thread Alfonso Nishikawa (Jira)
for Gora Kudu support. There are some classes that retrieve native information from the underlying datastore that at this moment only is implemented for HBase. Kudu is missing that feature. GoraExplorer uses that native information to help creating mappings with a Wizard (and it is specific for each

[jira] [Commented] (GORA-665) Add support for the Ignite datastore in GoraExplorer

2020-10-25 Thread John Mora (Jira)
 [~carlosrmng] developed the Ignite datastore, maybe he can check the changes you made. Best, John > Add support for the Ignite datastore in GoraExplorer > > > Key: GORA-665 > URL: https://issues.

[jira] [Commented] (GORA-666) Add support for the Kudu datastore in GoraExplorer

2020-10-25 Thread John Mora (Jira)
was not aware of that. I think  [~alfonso.nishikawa] knows more about Gora Explorer than I do. Alfonso, is the support for Kudu complete? > Add support for the Kudu datastore in GoraExplorer > -- > > Key: GORA-666 >

[jira] [Commented] (GORA-665) Add support for the Ignite datastore in GoraExplorer

2020-10-24 Thread Gaby Ortiz (Jira)
[ https://issues.apache.org/jira/browse/GORA-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220236#comment-17220236 ] Gaby Ortiz commented on GORA-665: - HI. I took a look to the last datastore added to GoraExplorer : KUDU

[GitHub] [gora] mgov88 opened a new pull request #228: [GORA-665] - Add support for the Ignite datastore in GoraExplorer

2020-10-24 Thread GitBox
mgov88 opened a new pull request #228: URL: https://github.com/apache/gora/pull/228 To add support for Apache Ignite in Gora Explorer the mapping XML must be read from gora.mapping in the same way as is implemented in the Kudu datastore.

[jira] [Commented] (GORA-666) Add support for the Kudu datastore in GoraExplorer

2020-10-24 Thread Gaby Ortiz (Jira)
is available in the Connectors list, are there pending tasks for a complete support?.   > Add support for the Kudu datastore in GoraExplorer > -- > > Key: GORA-666 > URL: https://issues.apache.org/jira/

Re: Accessing GoraExplorer

2020-10-21 Thread Alfonso Nishikawa
Hi, Nilothpal. Write me to alfonso.nishik...@gmail.com with your IP and I remove the firewall rules. The past week I updated te firewall rules and it seems they are too much restrictive :S Thank you! :) Best regards, Alfonso Nishikawa El mié., 21 oct. 2020 a las 4:28, Nilothpal Pillai (<

Accessing GoraExplorer

2020-10-20 Thread Nilothpal Pillai
Hi, I'm unable to access https://www.goraexplorer.com. The link times out and never loads. Can someone please help me out? Thank you. -- Nilothpal Pillai Chennai, Tamil Nadu, India

[jira] [Commented] (GORA-557) Add support for MongoDB to GoraExplorer

2020-10-19 Thread Alfonso Nishikawa (Jira)
believe there was some misunderstanding in GORA-271. Let's put this on hold until we clarify it. > Add support for MongoDB to GoraExplorer > --- > > Key: GORA-557 > URL: https://issues.apache.org/jira/

[jira] [Commented] (GORA-557) Add support for MongoDB to GoraExplorer

2020-10-18 Thread Mariia Podorvanova (Jira)
properties in MongoStore? The ticket seems quite old, and the changes I described above were made after the ticket creation. > Add support for MongoDB to GoraExplorer > --- > > Key: GORA-557 > URL: https://issues.apache.

[jira] [Commented] (GORA-557) Add support for MongoDB to GoraExplorer

2020-10-15 Thread Alfonso Nishikawa (Jira)
Add support for MongoDB to GoraExplorer > --- > > Key: GORA-557 > URL: https://issues.apache.org/jira/browse/GORA-557 > Project: Apache Gora > Issue Type: Improvement >

[jira] [Assigned] (GORA-557) Add support for MongoDB to GoraExplorer

2020-10-15 Thread Alfonso Nishikawa (Jira)
[ https://issues.apache.org/jira/browse/GORA-557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alfonso Nishikawa reassigned GORA-557: -- Assignee: Mariia Podorvanova > Add support for MongoDB to GoraExplo

[jira] [Commented] (GORA-557) Add support for MongoDB to GoraExplorer

2020-10-13 Thread Mariia Podorvanova (Jira)
internship Dec 2020 program. I have started working on this issue. > Add support for MongoDB to GoraExplorer > --- > > Key: GORA-557 > URL: https://issues.apache.org/jira/browse/GORA-557 > Project: Apache Gor

[jira] [Created] (GORA-666) Add support for the Kudu datastore in GoraExplorer

2020-10-12 Thread John Mora (Jira)
John Mora created GORA-666: -- Summary: Add support for the Kudu datastore in GoraExplorer Key: GORA-666 URL: https://issues.apache.org/jira/browse/GORA-666 Project: Apache Gora Issue Type: New

[jira] [Created] (GORA-665) Add support for the Ignite datastore in GoraExplorer

2020-10-12 Thread John Mora (Jira)
John Mora created GORA-665: -- Summary: Add support for the Ignite datastore in GoraExplorer Key: GORA-665 URL: https://issues.apache.org/jira/browse/GORA-665 Project: Apache Gora Issue Type: New

Re: Add GoraExplorer at Related Projects section

2019-09-06 Thread Alfonso Nishikawa
Hi! Done! Added GoraExplorer to the Related Projects :) Thank you!! Best Regards, Alfonso Nishikawa El jue., 5 sept. 2019 a las 15:30, carlos muñoz () escribió: > Hi, > > +1 > > Cheers, > Carlos > > El jue., 5 sept. 2019 a las 6:34, Cihad Guzel () > escribió: &

Re: Add GoraExplorer at Related Projects section

2019-09-05 Thread carlos muñoz
; Furkan KAMACI > > > > 5 Eyl 2019 Per, saat 07:48 tarihinde Kevin Ratnasekera < > > djkevincr1...@gmail.com> şunu yazdı: > > > > > +1 > > > > > > On Thu, Sep 5, 2019 at 2:17 AM Alfonso Nishikawa < > > > alfonso.nishik...@

Re: Add GoraExplorer at Related Projects section

2019-09-04 Thread Furkan KAMACI
t; > > I have been thiking about adding GoraExplorer [1] to the Related Projects > > section of the web, although it is in alpha stage. > > Since I would be adding my own project, is everyone OK with that? :) > > > > [1] https://www.goraexplorer.com/ > >

Re: Add GoraExplorer at Related Projects section

2019-09-04 Thread Kevin Ratnasekera
+1 On Thu, Sep 5, 2019 at 2:17 AM Alfonso Nishikawa < alfonso.nishik...@gmail.com> wrote: > Hi! > > I have been thiking about adding GoraExplorer [1] to the Related Projects > section of the web, although it is in alpha stage. > Since I would be adding my own pr

Add GoraExplorer at Related Projects section

2019-09-04 Thread Alfonso Nishikawa
Hi! I have been thiking about adding GoraExplorer [1] to the Related Projects section of the web, although it is in alpha stage. Since I would be adding my own project, is everyone OK with that? :) [1] https://www.goraexplorer.com/ [2] http://gora.apache.org/related.html Thank you! Regards

[jira] [Updated] (GORA-557) Add support for MongoDB to GoraExplorer

2019-03-19 Thread Alfonso Nishikawa (JIRA)
[ https://issues.apache.org/jira/browse/GORA-557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alfonso Nishikawa updated GORA-557: --- Issue Type: Improvement (was: New Feature) > Add support for MongoDB to GoraExplo

[jira] [Created] (GORA-558) Add support for Cassandra to GoraExplorer

2019-03-19 Thread Alfonso Nishikawa (JIRA)
Alfonso Nishikawa created GORA-558: -- Summary: Add support for Cassandra to GoraExplorer Key: GORA-558 URL: https://issues.apache.org/jira/browse/GORA-558 Project: Apache Gora Issue Type

[jira] [Created] (GORA-557) Add support for MongoDB to GoraExplorer

2019-03-19 Thread Alfonso Nishikawa (JIRA)
Alfonso Nishikawa created GORA-557: -- Summary: Add support for MongoDB to GoraExplorer Key: GORA-557 URL: https://issues.apache.org/jira/browse/GORA-557 Project: Apache Gora Issue Type: New

[GitHub] [gora] djkevincr commented on issue #135: Goraexplorer needed changes

2019-03-19 Thread GitBox
djkevincr commented on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-474604466 @alfonsonishikawa Lets create a new ticket and address separately :) This is an automated

[GitHub] [gora] alfonsonishikawa commented on issue #135: Goraexplorer needed changes

2019-03-19 Thread GitBox
alfonsonishikawa commented on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-474603882 Oh! Thank you for the pull! I was working on the Gora-Pig tests as @djkevincr suggested. I will continue working on them anyway but will open

[GitHub] [gora] djkevincr commented on issue #135: Goraexplorer needed changes

2019-03-19 Thread GitBox
djkevincr commented on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-474603912 @alfonsonishikawa I have merged you PR, thank you very much for your hard work on this :) I went through your design documents and all looked very impressive

[GitHub] [gora] djkevincr merged pull request #135: Goraexplorer needed changes

2019-03-19 Thread GitBox
djkevincr merged pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [gora] lewismc commented on issue #135: Goraexplorer needed changes

2019-03-19 Thread GitBox
lewismc commented on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-474597518 > Do you have any concern over your review on this PR? No This is an automated mess

[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes

2019-03-18 Thread GitBox
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r266680620 ## File path: gora-pig/src/test/java/org/apache/gora/pig/GoraStorageTest.java-disabled ## @@ -0,0 +1,352

[GitHub] [gora] djkevincr commented on issue #135: Goraexplorer needed changes

2019-03-18 Thread GitBox
djkevincr commented on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-474034153 @alfonsonishikawa One concern I do have is, I noticed record.vm velocity template changes, hopefully I think you have regenerated all the AVRO databean

[GitHub] [gora] djkevincr commented on a change in pull request #135: Goraexplorer needed changes

2019-03-18 Thread GitBox
djkevincr commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r266567600 ## File path: gora-pig/src/test/java/org/apache/gora/pig/GoraStorageTest.java-disabled ## @@ -0,0 +1,352 @@ +package

[GitHub] [gora] djkevincr commented on issue #135: Goraexplorer needed changes

2019-03-18 Thread GitBox
djkevincr commented on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-474029378 Locally tested the PR, build passes without any test failures. [INFO] [INFO

[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes

2019-03-17 Thread GitBox
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r266256724 ## File path: gora-pig/src/test/examples/README.md ## @@ -0,0 +1,46 @@ + Review comment: The Gora-Pig example

[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes

2019-03-17 Thread GitBox
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r266256105 ## File path: gora-pig/src/test/examples/example.pig ## @@ -0,0 +1,4 @@ +set job.name 'GoraStorage test' ; +register

[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes

2019-03-17 Thread GitBox
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r266256014 ## File path: gora-core/src/examples/java/org/apache/gora/examples/generated/package-info.java ## @@ -1,20 +0,0

[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes

2019-03-17 Thread GitBox
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r266255944 ## File path: conf/log4j.properties ## @@ -24,7 +24,7 @@ log4j.threshhold=ALL log4j.rootLogger=${gora.root.logger

[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes

2019-03-17 Thread GitBox
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r266249623 ## File path: gora-core/src/main/java/org/apache/gora/store/DataStoreFactory.java ## @@ -412,7 +484,7 @@ public

[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes

2019-03-17 Thread GitBox
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r222506186 ## File path: gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm ## @@ -180,6 +180,11

[GitHub] [gora] alfonsonishikawa commented on issue #135: Goraexplorer needed changes

2019-03-13 Thread GitBox
alfonsonishikawa commented on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-472663392 Hi! I am updating this pull request with the fixes from your comments. Will finish it this week. Thanks

[GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes

2019-03-13 Thread GitBox
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#discussion_r265370854 ## File path: gora-core/src/examples/java/org/apache/gora/examples/generated/package-info.java ## @@ -1,20 +0,0

[GitHub] [gora] djkevincr edited a comment on issue #135: Goraexplorer needed changes

2019-03-13 Thread GitBox
djkevincr edited a comment on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-472522370 @alfonsonishikawa Are you done with updating PR as per the reviews? Is there anything else that we should address or Do you need further time

[GitHub] [gora] djkevincr edited a comment on issue #135: Goraexplorer needed changes

2019-03-13 Thread GitBox
djkevincr edited a comment on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-472522370 @alfonsonishikawa Are you done with updating PR as per the reviews? Is there anything else that we should address or do you need further time

[GitHub] [gora] djkevincr commented on issue #135: Goraexplorer needed changes

2019-03-13 Thread GitBox
djkevincr commented on issue #135: Goraexplorer needed changes URL: https://github.com/apache/gora/pull/135#issuecomment-472522370 @alfonsonishikawa Are you done with updating PR as per the reviews? Is there anything else that we should address or do you need further time on this? Its

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-14 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r225001067 --- Diff: pom.xml --- @@ -832,6 +833,12 @@ 1.0.1 2.5 + +0.16.0 +1.11-8 --- End diff --

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-14 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r225000854 --- Diff: gora-pig/src/test/examples/example.pig --- @@ -0,0 +1,4 @@ +set job.name 'GoraStorage test' ; +register gora/*.jar ; +webpage =

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-14 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r225000361 --- Diff: gora-pig/src/main/java/org/apache/gora/pig/mapreduce/PigGoraOutputFormat.java --- @@ -0,0 +1,86 @@ +package

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-14 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r225000105 --- Diff: gora-pig/pom.xml --- @@ -0,0 +1,180 @@ + +http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd; +

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-14 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r224999854 --- Diff: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java --- @@ -80,15 +81,20 @@ * DataStore for HBase. Thread safe.

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-14 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r224998986 --- Diff: gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm --- @@ -180,6 +180,11 @@ public class

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543455 --- Diff: gora-pig/src/test/examples/README.txt --- @@ -0,0 +1,9 @@ + --- End diff -- Can you make this an .md file? ---

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542930 --- Diff: gora-pig/src/main/java/org/apache/gora/pig/ResourceFieldSchemaWithIndex.java --- @@ -0,0 +1,31 @@ +package org.apache.gora.pig; --- End diff

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222540948 --- Diff: gora-compiler/src/main/java/org/apache/gora/compiler/GoraCompiler.java --- @@ -86,6 +88,31 @@ public static void compileSchema(File[] srcFiles, File

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222541609 --- Diff: gora-core/src/main/java/org/apache/gora/store/DataStoreFactory.java --- @@ -251,6 +254,70 @@ D getDataStore( Class dataStoreClass, Class keyClass,

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542624 --- Diff: gora-pig/pom.xml --- @@ -0,0 +1,180 @@ + --- End diff -- License header. ---

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222540708 --- Diff: bin/compile-examples.sh --- @@ -36,8 +36,57 @@ DIR=$GORA_HOME/$MODULE/src/examples/avro/ OUTDIR=$GORA_HOME/$MODULE/src/examples/java

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543677 --- Diff: pom.xml --- @@ -757,9 +758,9 @@ gora-maven-plugin gora-mongodb gora-solr +gora-aerospike --- End diff --

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542669 --- Diff: gora-pig/pom.xml --- @@ -0,0 +1,180 @@ + +http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd; +

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222541705 --- Diff: gora-core/src/main/java/org/apache/gora/store/DataStoreFactory.java --- @@ -412,7 +484,7 @@ public static String getMappingFile(Properties

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222541077 --- Diff: gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm --- @@ -180,6 +180,11 @@ public class

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543835 --- Diff: pom.xml --- @@ -1546,6 +1553,40 @@ ${orientqb.version} + + + org.apache.pig +

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543728 --- Diff: pom.xml --- @@ -832,6 +833,12 @@ 1.0.1 2.5 + +0.16.0 +1.11-8 --- End diff -- Is this

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542415 --- Diff: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java --- @@ -734,14 +756,13 @@ private void setField(T persistent, Field field, List

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543239 --- Diff: gora-pig/src/main/java/org/apache/gora/pig/mapreduce/PigGoraOutputFormat.java --- @@ -0,0 +1,86 @@ +package org.apache.gora.pig.mapreduce;

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543267 --- Diff: gora-pig/src/main/java/org/apache/gora/pig/udf/MapMerge.java --- @@ -0,0 +1,33 @@ +package org.apache.gora.pig.udf; --- End diff --

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222541967 --- Diff: gora-core/src/main/java/org/apache/gora/store/DataStoreMetadataFactory.java --- @@ -0,0 +1,93 @@ +/** + * Licensed to the Apache Software

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542504 --- Diff: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseTableMetadata.java --- @@ -0,0 +1,27 @@ +package org.apache.gora.hbase.store; ---

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222541246 --- Diff: gora-core/src/examples/java/org/apache/gora/examples/generated/package-info.java --- @@ -1,20 +0,0 @@ -/** --- End diff -- Why

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542987 --- Diff: gora-pig/src/main/java/org/apache/gora/pig/StorageConfiguration.java --- @@ -0,0 +1,140 @@ +package org.apache.gora.pig; --- End diff --

  1   2   >