[jira] [Commented] (GRIFFIN-194) [service] Hive API improvement

2018-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664734#comment-16664734 ] ASF GitHub Bot commented on GRIFFIN-194: Github user guoyuepeng commented on a d

[GitHub] incubator-griffin pull request #447: [GRIFFIN-194] single call to fetch all ...

2018-10-25 Thread guoyuepeng
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/447#discussion_r228420528 --- Diff: ui/angular/src/app/measure/create-measure/ac/ac.component.ts --- @@ -644,48 +644,37 @@ export class AcComponent implements OnInit, Af

[jira] [Commented] (GRIFFIN-194) [service] Hive API improvement

2018-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664726#comment-16664726 ] ASF GitHub Bot commented on GRIFFIN-194: Github user guoyuepeng commented on a d

[GitHub] incubator-griffin pull request #447: [GRIFFIN-194] single call to fetch all ...

2018-10-25 Thread guoyuepeng
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/447#discussion_r228419404 --- Diff: service/src/main/java/org/apache/griffin/core/metastore/hive/HiveMetaStoreServiceImpl.java --- @@ -99,8 +100,17 @@ public HiveMetaSt

[jira] [Commented] (GRIFFIN-203) "Plaintext mode" for measure creation

2018-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664647#comment-16664647 ] ASF GitHub Bot commented on GRIFFIN-203: Github user gavlyukovskiy commented on

[GitHub] incubator-griffin issue #446: [GRIFFIN-203] "Plaintext mode" for measure cre...

2018-10-25 Thread gavlyukovskiy
Github user gavlyukovskiy commented on the issue: https://github.com/apache/incubator-griffin/pull/446 Thank you everyone for feedback, I'm not UI guy so structure was messed little bit :) I changed it to be consistent with other pages and now it looks much better. ---

[jira] [Commented] (GRIFFIN-208) Job status is SUCCESS even if some stages have failed

2018-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664575#comment-16664575 ] ASF GitHub Bot commented on GRIFFIN-208: Github user chemikadze commented on a d

[GitHub] incubator-griffin pull request #448: [GRIFFIN-208] log exception details whe...

2018-10-25 Thread chemikadze
Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/448#discussion_r228391307 --- Diff: measure/src/main/scala/org/apache/griffin/measure/Application.scala --- @@ -104,12 +106,18 @@ object Application extends Loggable {

[jira] [Commented] (GRIFFIN-203) "Plaintext mode" for measure creation

2018-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664548#comment-16664548 ] ASF GitHub Bot commented on GRIFFIN-203: Github user icesmartjuan commented on t

[GitHub] incubator-griffin issue #446: [GRIFFIN-203] "Plaintext mode" for measure cre...

2018-10-25 Thread icesmartjuan
Github user icesmartjuan commented on the issue: https://github.com/apache/incubator-griffin/pull/446 Awesome feature! There seems an issue when zoom up the page, the textare is outside and the ```submit``` button can't be clicked/triggered. ![image](https://user-images.github

[jira] [Commented] (GRIFFIN-208) Job status is SUCCESS even if some stages have failed

2018-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664516#comment-16664516 ] ASF GitHub Bot commented on GRIFFIN-208: Github user chemikadze commented on a d

[GitHub] incubator-griffin pull request #448: [GRIFFIN-208] log exception details whe...

2018-10-25 Thread chemikadze
Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/448#discussion_r228385053 --- Diff: measure/src/main/scala/org/apache/griffin/measure/Application.scala --- @@ -104,12 +106,18 @@ object Application extends Loggable {

[jira] [Commented] (GRIFFIN-203) "Plaintext mode" for measure creation

2018-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664282#comment-16664282 ] ASF GitHub Bot commented on GRIFFIN-203: Github user chemikadze commented on the

[GitHub] incubator-griffin issue #446: [GRIFFIN-203] "Plaintext mode" for measure cre...

2018-10-25 Thread chemikadze
Github user chemikadze commented on the issue: https://github.com/apache/incubator-griffin/pull/446 Looks like there are still some rendering issues: https://user-images.githubusercontent.com/867294/47530131-9ac61b80-d85e-11e8-8bf1-aa825105ff52.png";> ---

[jira] [Commented] (GRIFFIN-208) Job status is SUCCESS even if some stages have failed

2018-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664119#comment-16664119 ] ASF GitHub Bot commented on GRIFFIN-208: GitHub user chemikadze opened a pull re

[GitHub] incubator-griffin pull request #448: [GRIFFIN-208] log exception details whe...

2018-10-25 Thread chemikadze
GitHub user chemikadze opened a pull request: https://github.com/apache/incubator-griffin/pull/448 [GRIFFIN-208] log exception details when it makes sense Sometimes error messages are not descriptive enough and do not allow to pinpoint exact issue. Exception stack traces should m

[jira] [Commented] (GRIFFIN-205) Accuracy measure check should provide matchedFraction to store

2018-10-25 Thread Nikolay Sokolov (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664081#comment-16664081 ] Nikolay Sokolov commented on GRIFFIN-205: - [~artem.shutak] as we've merged this

[GitHub] incubator-griffin pull request #442: Support "cache" field on rules in servi...

2018-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-griffin/pull/442 ---

[GitHub] incubator-griffin pull request #442: Support "cache" field on rules in servi...

2018-10-25 Thread guoyuepeng
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/442#discussion_r228217972 --- Diff: service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java --- @@ -81,6 +81,9 @@ Licensed to the Apache Software Foundati

[GitHub] incubator-griffin pull request #442: Support "cache" field on rules in servi...

2018-10-25 Thread bhlx3lyx7
Github user bhlx3lyx7 commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/442#discussion_r228215711 --- Diff: service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java --- @@ -81,6 +81,9 @@ Licensed to the Apache Software Foundatio

[GitHub] incubator-griffin issue #446: [GRIFFIN-203] "Plaintext mode" for measure cre...

2018-10-25 Thread guoyuepeng
Github user guoyuepeng commented on the issue: https://github.com/apache/incubator-griffin/pull/446 Awesome! ---

[jira] [Commented] (GRIFFIN-203) "Plaintext mode" for measure creation

2018-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663842#comment-16663842 ] ASF GitHub Bot commented on GRIFFIN-203: Github user guoyuepeng commented on the

[GitHub] incubator-griffin pull request #445: Update deploy-guide.md

2018-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-griffin/pull/445 ---

[GitHub] incubator-griffin pull request #443: Fix conventions in batch-sample

2018-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-griffin/pull/443 ---

[jira] [Resolved] (GRIFFIN-207) LDAP auth is not supporting group filters and non-CN login names

2018-10-25 Thread William Guo (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] William Guo resolved GRIFFIN-207. - Resolution: Fixed Fix Version/s: 0.3.1-incubating Issue resolved by pull request 441 [htt

[jira] [Commented] (GRIFFIN-207) LDAP auth is not supporting group filters and non-CN login names

2018-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663802#comment-16663802 ] ASF GitHub Bot commented on GRIFFIN-207: Github user asfgit closed the pull requ

[GitHub] incubator-griffin pull request #441: [GRIFFIN-207] LDAP login service improv...

2018-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-griffin/pull/441 ---

[GitHub] incubator-griffin pull request #447: [GRIFFIN-194] single call to fetch all ...

2018-10-25 Thread chemikadze
GitHub user chemikadze opened a pull request: https://github.com/apache/incubator-griffin/pull/447 [GRIFFIN-194] single call to fetch all tables of all dbs Significantly improves opening speed for measure dialogs. Previously taking 10+ seconds on huge schemas, with this call

[jira] [Commented] (GRIFFIN-194) [service] Hive API improvement

2018-10-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GRIFFIN-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663346#comment-16663346 ] ASF GitHub Bot commented on GRIFFIN-194: GitHub user chemikadze opened a pull re