Github user whhe commented on the issue:
https://github.com/apache/incubator-griffin/pull/441
> @whhe @toyboxman @guoyuepeng are you good with fixes after review?
It looks good to me.
---
Github user whhe commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/441#discussion_r227194519
--- Diff:
service/src/main/java/org/apache/griffin/core/login/ldap/SelfSignedSocketFactory.java
---
@@ -0,0 +1,100 @@
+/*
+Licensed
Github user whhe commented on the issue:
https://github.com/apache/incubator-griffin/pull/332
Hi @toyboxman
I understand your concern and I agree that %n is better than \n as line
separator. As you mentioned, the change you committed is acceptable, but not
necessary
Github user whhe commented on the issue:
https://github.com/apache/incubator-griffin/pull/332
Hi @toyboxman
Thanks for your advice, but I think the line separator here has nothing to
do with platform. Elasticsearch just use it (in http entity) to identify the
bulk request
GitHub user whhe opened a pull request:
https://github.com/apache/incubator-griffin/pull/201
update exception handling and restful response
1. Update exception handling. Add exception handlers for client error and
checked exception at server side. Remove unnecessary try-catch
GitHub user whhe opened a pull request:
https://github.com/apache/incubator-griffin/pull/188
modify login and get metrics process
1. simplify login process, with login strategy "test", any user can login
regardless of username and password
2. modify returned value of
GitHub user whhe opened a pull request:
https://github.com/apache/incubator-griffin/pull/124
add login module
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/whhe/incubator-griffin master
Alternatively you can review and apply
