Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/332
Hi, @whhe @guoyuepeng
I submit a new patch to revise, please review again
https://github.com/apache/incubator-griffin/pull/335
---
Github user guoyuepeng commented on the issue:
https://github.com/apache/incubator-griffin/pull/332
hi @toyboxman
Yes, we might need to new patch for all '\n'
Thanks,
William
---
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/332
let me check how many times '\n' was used in codes and make a new patch
---
Github user whhe commented on the issue:
https://github.com/apache/incubator-griffin/pull/332
Hi @toyboxman
I understand your concern and I agree that %n is better than \n as line
separator. As you mentioned, the change you committed is acceptable, but not
necessary in this
Github user toyboxman commented on the issue:
https://github.com/apache/incubator-griffin/pull/332
Hi @whhe
I got you here. but I wanna clarify why I change it.
Java Formatter suggests % as special notation character instead of '\'
Github user whhe commented on the issue:
https://github.com/apache/incubator-griffin/pull/332
Hi @toyboxman
Thanks for your advice, but I think the line separator here has nothing to
do with platform. Elasticsearch just use it (in http entity) to identify the
bulk request
