[GitHub] incubator-griffin pull request #442: Support "cache" field on rules in servi...

2018-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-griffin/pull/442 ---

[GitHub] incubator-griffin pull request #442: Support "cache" field on rules in servi...

2018-10-25 Thread guoyuepeng
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/442#discussion_r228217972 --- Diff: service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java --- @@ -81,6 +81,9 @@ Licensed to the Apache Software

[GitHub] incubator-griffin pull request #442: Support "cache" field on rules in servi...

2018-10-25 Thread bhlx3lyx7
Github user bhlx3lyx7 commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/442#discussion_r228215711 --- Diff: service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java --- @@ -81,6 +81,9 @@ Licensed to the Apache Software

[GitHub] incubator-griffin pull request #442: Support "cache" field on rules in servi...

2018-10-23 Thread guoyuepeng
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/442#discussion_r227272894 --- Diff: service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java --- @@ -81,6 +81,9 @@ Licensed to the Apache Software

[GitHub] incubator-griffin pull request #442: Support "cache" field on rules in servi...

2018-10-22 Thread chemikadze
Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/442#discussion_r227217198 --- Diff: service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java --- @@ -81,6 +81,9 @@ Licensed to the Apache Software

[GitHub] incubator-griffin pull request #442: Support "cache" field on rules in servi...

2018-10-21 Thread toyboxman
Github user toyboxman commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/442#discussion_r226905150 --- Diff: service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java --- @@ -81,6 +81,9 @@ Licensed to the Apache Software

[GitHub] incubator-griffin pull request #442: Support "cache" field on rules in servi...

2018-10-21 Thread chemikadze
Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/442#discussion_r226871843 --- Diff: service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java --- @@ -81,6 +81,9 @@ Licensed to the Apache Software

[GitHub] incubator-griffin pull request #442: Support "cache" field on rules in servi...

2018-10-21 Thread guoyuepeng
Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/442#discussion_r226866876 --- Diff: service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java --- @@ -81,6 +81,9 @@ Licensed to the Apache Software

[GitHub] incubator-griffin pull request #442: Support "cache" field on rules in servi...

2018-10-19 Thread chemikadze
GitHub user chemikadze opened a pull request: https://github.com/apache/incubator-griffin/pull/442 Support "cache" field on rules in service module Measure module exposes "cache" flag on rules, but it's not possible to store and schedule such a job in service module. You can merge