Re: [VOTE] Release Groovy 2.4.8 - take 3

2017-01-12 Thread Paul King
I am happy to announce that the vote has passed with four binding +1 votes and one non-binding +1 vote. Binding: Paul King, Guillaume Laforge, Jochen Theodorou, Cédric Champeau. Non-binding: Jacopo Cappellato. (We had additional +1s earlier on the same binary artifacts but the VOTE was restarted so

Re: [VOTE] Release Groovy 2.4.8 - take 3

2017-01-11 Thread Jacopo Cappellato
+1 (not binding) Tests on source release artifact: - hash is ok - signature is ok - LICENSE and NOTICE files look good (but "I am not a lawyer"!) - README file ok (I have followed the steps described there to build the dist and test it) - build dist from sources (./gradlew clean dist): ok - run te

Re: [VOTE] Release Groovy 2.4.8 - take 3

2017-01-10 Thread jim northrop
Thank you Paul. We're working to get GPars V2.0 doc.s ready so will include 2.4.8 plus asciidoctor 1.5.5 just out this morning. ☺️ Sent from my iPad > On 11 Jan 2017, at 01:42, Paul King wrote: > > A little early to give an exact ETA Jim. I'll update here when I know more. > > On Wed, Jan 11,

Re: [VOTE] Release Groovy 2.4.8

2017-01-10 Thread Roman Shaposhnik
On Tue, Jan 10, 2017 at 5:02 AM, Paul King wrote: > Looks like everyone is keen to get the release out soon. Given it was > just a minor tweak to the build file, I'll re-issue the vote but with > a 48 hr window. +1 Thanks, Roman.

Re: [VOTE] Release Groovy 2.4.8 - take 3

2017-01-10 Thread Paul King
A little early to give an exact ETA Jim. I'll update here when I know more. On Wed, Jan 11, 2017 at 2:05 AM, Jim Northrop wrote: > Do we have an ETA date when we can chg our gradle configs to pull 2.4.8 > please? > > Sent from my iPad > >> On 10 Jan 2017, at 14:06, Paul King wrote: >> >> [Hopef

Re: [VOTE] Release Groovy 2.4.8 - take 3

2017-01-10 Thread Jim Northrop
Do we have an ETA date when we can chg our gradle configs to pull 2.4.8 please? Sent from my iPad > On 10 Jan 2017, at 14:06, Paul King wrote: > > [Hopefully for real this time] > > Dear community, > > I am happy to start the VOTE thread for a Groovy 2.4.8 release! > > This release includes

Re: [VOTE] Release Groovy 2.4.8 - take 3

2017-01-10 Thread Cédric Champeau
+1 (binding) Checking apache-groovy-src-2.4.8.zip : signature [ok] checksum [ok] Checking apache-groovy-binary-2.4.8.zip : signature [ok] checksum [ok] Checking apache-groovy-sdk-2.4.8.zip : signature [ok] checksum [ok] Checking apache-groovy-docs-2.4.8.zip : signature [ok] checksum [ok] 2017-01

Re: [VOTE] Release Groovy 2.4.8 - take 3

2017-01-10 Thread Jochen Theodorou
+1 On 10.01.2017 14:10, Guillaume Laforge wrote: +1 (binding) On Tue, Jan 10, 2017 at 2:06 PM, Paul King mailto:pa...@asert.com.au>> wrote: [Hopefully for real this time] Dear community, I am happy to start the VOTE thread for a Groovy 2.4.8 release! This release includes 85

Re: [VOTE] Release Groovy 2.4.8 - take 3

2017-01-10 Thread Guillaume Laforge
+1 (binding) On Tue, Jan 10, 2017 at 2:06 PM, Paul King wrote: > [Hopefully for real this time] > > Dear community, > > I am happy to start the VOTE thread for a Groovy 2.4.8 release! > > This release includes 85 bug fixes/improvements as outlined in the > changelog: > https://issues.apache.org/

[VOTE] Release Groovy 2.4.8 - take 3

2017-01-10 Thread Paul King
[Hopefully for real this time] Dear community, I am happy to start the VOTE thread for a Groovy 2.4.8 release! This release includes 85 bug fixes/improvements as outlined in the changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12335950 Tag: https://g

Re: [VOTE] Release Groovy 2.4.8

2017-01-10 Thread Paul King
gt;> >> >> >> - >> >> Uwe Schindler >> >> Achterdiek 19, D-28357 Bremen >> >> http://www.thetaphi.de >> >> eMail: u...@thetaphi.de >> >> >> >> From: Cédric Champeau [mailto:cedric.champ...@gmail.com] &

Re: [VOTE] Release Groovy 2.4.8

2017-01-10 Thread Cédric Champeau
; *To:* dev@groovy.apache.org; Paul King > *Cc:* John Wagenleitner > *Subject:* Re: [VOTE] Release Groovy 2.4.8 > > > > Was it such a big deal we needed to cancel the vote? I find it a bit > unfortunate, since "building" just works, or that setting the signing >

Re: [VOTE] Release Groovy 2.4.8

2017-01-10 Thread Guillaume Laforge
I also believe it's okay, and not critical, leading us to cancel the vote. We can just list that point as a known (minor) issue. On Tue, Jan 10, 2017 at 12:41 PM, Cédric Champeau wrote: > Was it such a big deal we needed to cancel the vote? I find it a bit > unfortunate, since "building" just wo

RE: [VOTE] Release Groovy 2.4.8

2017-01-10 Thread Uwe Schindler
ampeau [mailto:cedric.champ...@gmail.com] Sent: Tuesday, January 10, 2017 12:42 PM To: dev@groovy.apache.org; Paul King Cc: John Wagenleitner Subject: Re: [VOTE] Release Groovy 2.4.8 Was it such a big deal we needed to cancel the vote? I find it a bit unfortunate, since "building"

Re: [VOTE] Release Groovy 2.4.8

2017-01-10 Thread Cédric Champeau
Was it such a big deal we needed to cancel the vote? I find it a bit unfortunate, since "building" just works, or that setting the signing properties do. Anyway I leave it to you. 2017-01-10 12:37 GMT+01:00 Paul King : > John found an issue with "install" if you don't have signing properties in >

Re: [VOTE] Release Groovy 2.4.8

2017-01-10 Thread Paul King
John found an issue with "install" if you don't have signing properties in place. As painful as it is, I'll cancel the vote and try again. I have re-run the tweaked build script and the new artifacts are re-uploaded to the same place on the DEV server. Anyone want to give it a quick try before I d

Re: [VOTE] Release Groovy 2.4.8

2017-01-09 Thread John Wagenleitner
With the downloaded source I was using gradle 2.14. I also fetched the GROOVY_2_4_8 tag and ran gradlew from there which is 2.3. I get the error with both. Not sure if I need to set up a property to point to gpg keys, but haven't had to do that in the past. On Mon, Jan 9, 2017 at 7:42 PM, Paul

Re: [VOTE] Release Groovy 2.4.8

2017-01-09 Thread Paul King
Can you check the version of gradle that is running? The artifacts are built using install and install works fine for me from the src zip. On Tue, Jan 10, 2017 at 12:33 PM, John Wagenleitner wrote: > When I run `gradlew install` from source (both from the downloaded zip and > from the GROOVY_2_4_

Re: [VOTE] Release Groovy 2.4.8

2017-01-09 Thread John Wagenleitner
When I run `gradlew install` from source (both from the downloaded zip and from the GROOVY_2_4_8 tag) I get the error below. Looks like prior to commit 9fa4b015e4a80ef03 [1] this was a warning but now it fails the build and wont install the artifacts in the local maven repo. [1] https://github.co

Re: [VOTE] Release Groovy 2.4.8

2017-01-09 Thread Jochen Theodorou
+1 On 09.01.2017 07:33, Paul King wrote: Dear community, I am happy to start the VOTE thread for a Groovy 2.4.8 release! This release includes 84 bug fixes/improvements as outlined in the changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12335950 Tag

Re: [VOTE] Release Groovy 2.4.8

2017-01-09 Thread Jim Jagielski
+1 (binding)! > On Jan 9, 2017, at 1:33 AM, Paul King wrote: > > Dear community, > > I am happy to start the VOTE thread for a Groovy 2.4.8 release! > > This release includes 84 bug fixes/improvements as outlined in the changelog: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?project

Re: [VOTE] Release Groovy 2.4.8

2017-01-09 Thread Graeme Rocher
+1 (binding) Nice work Paul! On Mon, Jan 9, 2017 at 10:58 AM, Cédric Champeau wrote: > +1 (binding) > > Signatures ok. > SHA256 sum ok. > Buildable from sources. > > Good work, Paul! > > > 2017-01-09 7:33 GMT+01:00 Paul King : >> >> Dear community, >> >> I am happy to start the VOTE thread for a

Re: [VOTE] Release Groovy 2.4.8

2017-01-09 Thread Cédric Champeau
+1 (binding) Signatures ok. SHA256 sum ok. Buildable from sources. Good work, Paul! 2017-01-09 7:33 GMT+01:00 Paul King : > Dear community, > > I am happy to start the VOTE thread for a Groovy 2.4.8 release! > > This release includes 84 bug fixes/improvements as outlined in the > changelog: >

Re: [VOTE] Release Groovy 2.4.8

2017-01-09 Thread Guillaume Laforge
+1 (binding) I didn't check the signatures. But otherwise, the various notices files are there, I built from source successfully, I tried a few manual tests with the groovy, groovysh, and groovyConsole commands. All went totally fine. Guillaume On Mon, Jan 9, 2017 at 7:33 AM, Paul King wrote:

[VOTE] Release Groovy 2.4.8

2017-01-08 Thread Paul King
Dear community, I am happy to start the VOTE thread for a Groovy 2.4.8 release! This release includes 84 bug fixes/improvements as outlined in the changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12335950 Tag: https://git1-us-west.apache.org/repos/asf

Re: [VOTE] Release Groovy 2.4.8 [CANCELLED]

2017-01-08 Thread Paul King
Okay, I'm about to start a new vote count. I re-jigged the release process a bit to keep signing strictly local. Also, the glitch from the previous release should be fixed and I re-worked the bootstrapping so that gradle versions 3+ should also work. Cheers, Paul. On Fri, Dec 30, 2016 at 7:54 PM

Re: [VOTE] Release Groovy 2.4.8

2017-01-02 Thread Paul King
Well, it's designed so that we have any easy way to bootstrap from the source distro for people who aren't familiar with gradle. No need to know about any built-in commands or properties. We could get rid of it but it would make the instructions slightly more verbose and of course different between

Re: [VOTE] Release Groovy 2.4.8

2017-01-02 Thread Keegan Witt
It looks like it's there for the downloadWrapper task (wrapper.gradle). But I'm not sure why we have that defined. I've always just used gradle-wrapper.properties and "gradlew wrapper" to update the wrapper jar and gradlew scripts. If we don't need it anymore, I say we remove both the property an

Re: [VOTE] Release Groovy 2.4.8

2016-12-31 Thread Paul King
I imagine some of them could be moved but I think what we have is the more common place to have those versions. I am unsure whether an IDE assistance would be affected with such a move - I haven't actually tried. Cheers, Paul. On Sat, Dec 31, 2016 at 9:57 PM, Jochen Theodorou wrote: > On 31.12.2

Re: [VOTE] Release Groovy 2.4.8

2016-12-31 Thread Jochen Theodorou
On 31.12.2016 12:38, Paul King wrote: [...] There is a 'gradleVersion' property (set in the build.gradle file) which is used when bootstrapping the wrapper, so no need for further instructions in that regard. ah, ok. I am used to find those things in gradle.properties now... Is there any reaso

Re: [VOTE] Release Groovy 2.4.8

2016-12-31 Thread Paul King
Yes, I guess Gradle 3 had breaking changes in their groovydoc tasks. I guess we should be mentioning that in the README somewhere. Any gradle version before 3 should work and there be some hack for 3 too no doubt - I'll see what I can do. There is a 'gradleVersion' property (set in the build.gradl

Re: [VOTE] Release Groovy 2.4.8

2016-12-31 Thread Jochen Theodorou
Is it maybe because Groovy 2.4.8 is supposed to use Gradle 2.3 and that this build then does not work with Gradle 3.2.1, the version master is using? Just tested, and yes, this seems to be the cause. This means you cannot create the wrapper using Gradle 3.2.1 because the build file is not com

Re: [VOTE] Release Groovy 2.4.8

2016-12-31 Thread Jochen Theodorou
On 31.12.2016 03:25, Paul King wrote: The README gives bootstrap instructions for building from source. In particular, you should not copy gradlew from another groovy install. Instead you can just run any gradle and that will effectively do a "gradle wrapper" which will get the correct gradle ver

Re: [VOTE] Release Groovy 2.4.8

2016-12-30 Thread Paul King
The README gives bootstrap instructions for building from source. In particular, you should not copy gradlew from another groovy install. Instead you can just run any gradle and that will effectively do a "gradle wrapper" which will get the correct gradle version. Let me know if that works. Cheers

Re: [VOTE] Release Groovy 2.4.8

2016-12-30 Thread Jochen Theodorou
On 30.12.2016 22:13, Paul King wrote: Can you give some more info? I can't replicate. I copied the 3.2.1 wrapper over and then tried to start... this is what I got. Just tried again using another 3.2.1 wrapper and this time I got FAILURE: Build failed with an exception. * Where: Script '/t

Re: [VOTE] Release Groovy 2.4.8

2016-12-30 Thread Paul King
Can you give some more info? I can't replicate. Cheers, Paul. On Sat, Dec 31, 2016 at 4:46 AM, Jochen Theodorou wrote: > On 30.12.2016 07:25, Paul King wrote: >> >> Dear community, >> >> I am happy to start the VOTE thread for a Groovy 2.4.8 release! >> >> This release includes 82 bug fixes/impr

Re: [VOTE] Release Groovy 2.4.8

2016-12-30 Thread Bahman Movaqar
On 12/30/2016 07:25 AM, Paul King wrote: > Dear community, > > I am happy to start the VOTE thread for a Groovy 2.4.8 release! > > This release includes 82 bug fixes/improvements as outlined in the changelog: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=1233

Re: [VOTE] Release Groovy 2.4.8

2016-12-30 Thread Jochen Theodorou
On 30.12.2016 07:25, Paul King wrote: Dear community, I am happy to start the VOTE thread for a Groovy 2.4.8 release! This release includes 82 bug fixes/improvements as outlined in the changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12335950 Tag: h

Re: [VOTE] Release Groovy 2.4.8

2016-12-30 Thread Russel Winder
Cédric, Current best hypothesis is that Gradle is working for me as long as there is no buildSrc directory. On Fri, 2016-12-30 at 12:37 +0100, Cédric Champeau wrote: > It works fine locally. Is your local dir writable? No full disk? > Could you > try to delete ~/.gradle/caches/3.2.1 ? > > > 201

Re: [VOTE] Release Groovy 2.4.8

2016-12-30 Thread Russel Winder
On Fri, 2016-12-30 at 12:37 +0100, Cédric Champeau wrote: > It works fine locally. Is your local dir writable? No full disk? > Could you > try to delete ~/.gradle/caches/3.2.1 ? What is really worrying is that I get the problem using the SDKMAN! gradle installation as well as the gradlew command w

Re: [VOTE] Release Groovy 2.4.8

2016-12-30 Thread Russel Winder
On Fri, 2016-12-30 at 12:37 +0100, Cédric Champeau wrote: > It works fine locally. Is your local dir writable? No full disk? > Could you > try to delete ~/.gradle/caches/3.2.1 ? Good to hear it works somewhere. :-) Tried removing that cache directory, no change. :-( -- Russel. ===

Re: [VOTE] Release Groovy 2.4.8

2016-12-30 Thread Cédric Champeau
It works fine locally. Is your local dir writable? No full disk? Could you try to delete ~/.gradle/caches/3.2.1 ? 2016-12-30 12:34 GMT+01:00 Russel Winder : > It seems the Gradle 3.2.1 that gets downloaded is unable to build > Groovy on Debian Sid: > > > |> ./gradlew clean > Downloading https://

Re: [VOTE] Release Groovy 2.4.8

2016-12-30 Thread Russel Winder
It seems the Gradle 3.2.1 that gets downloaded is unable to build Groovy on Debian Sid: |> ./gradlew clean Downloading https://services.gradle.org/distributions/gradle-3.2.1-bin.zip ...

Re: [VOTE] Release Groovy 2.4.8 [CANCELLED]

2016-12-30 Thread Paul King
Darn. Thanks for spotting that. Yes I fixed that on master previously but didn't notice that I forgot to merge the fix when backporting and CI was failing for a different reason so I ignored what I thought was a false positive. It's only test code, not prod code that is affected but I think it's w

Re: [VOTE] Release Groovy 2.4.8

2016-12-30 Thread Pascal Schumacher
Hello Paul, thanks a lot for volunteering as a release manager. :) Sadly the javadoc of StringGroovyMethods#uncapitalize contains an error so, the unit tests fail with: MainJavadocAssertionTest > StringGroovyMethodsJavadocAssertionTest.testAssertionFromStringGroovyMethodsLine213 FAILED As

[VOTE] Release Groovy 2.4.8

2016-12-29 Thread Paul King
Dear community, I am happy to start the VOTE thread for a Groovy 2.4.8 release! This release includes 82 bug fixes/improvements as outlined in the changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123&version=12335950 Tag: https://git1-us-west.apache.org/repos/asf