[GitHub] [guacamole-client] necouchman commented on pull request #794: GUACAMOLE-1733: Add missing optional configuration options from docker start.sh script

2023-02-16 Thread via GitHub
necouchman commented on PR #794: URL: https://github.com/apache/guacamole-client/pull/794#issuecomment-1433847220 Okay, the changes are good, I believe; however, the final remaining item is to clean up commits and commit messages. In particular: * Each commit message should be descriptive

[GitHub] [guacamole-server] necouchman opened a new pull request, #415: GUACAMOLE-600: Add support for setting the Telnet connection timeout.

2023-02-16 Thread via GitHub
necouchman opened a new pull request, #415: URL: https://github.com/apache/guacamole-server/pull/415 Add support for specifying the connection timeout for Telnet connections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [guacamole-server] necouchman opened a new pull request, #414: GUACAMOLE-600: Add support for setting SSH and SFTP timeouts.

2023-02-16 Thread via GitHub
necouchman opened a new pull request, #414: URL: https://github.com/apache/guacamole-server/pull/414 This pull request adds support for setting the connection timeout for SSH and SFTP connections via connection parameters. -- This is an automated message from the Apache Git Service. To re

RE: Re: Re: Guacamole RDP connection establishing timeout

2023-02-16 Thread Dyck, Martin (BITBW)
Sounds great. After some tcpdumping the decisive paramenter should be TcpAckTimeout. Because: I saw that after 5 seconds Guacamole sends a TCP keep alive, but after 9 seconds Guacamole sends a FIN to end the RDP connection attempt. But as soon as the RDP connection is approved by an employee

[GitHub] [guacamole-client] ronansalmon commented on a diff in pull request #794: GUACAMOLE-1733: Add missing optional configuration options from docker start.sh script

2023-02-16 Thread via GitHub
ronansalmon commented on code in PR #794: URL: https://github.com/apache/guacamole-client/pull/794#discussion_r1108507402 ## guacamole-docker/bin/start.sh: ## @@ -1164,6 +1174,19 @@ if [ -n "$API_SESSION_TIMEOUT" ]; then associate_apisessiontimeout fi +# Maximum number o

Re: Re: Guacamole RDP connection establishing timeout

2023-02-16 Thread Nick Couchman
On Thu, Feb 16, 2023 at 2:07 AM Dyck, Martin (BITBW) wrote: > > Hi Nick, > > > > thank you very much for the quick reply. That sounds promising. > > I have seen your pull request #413. So can we expect in the next guacamole > release a way to modify the TcpAckTimeout? That would be gorgeous! > Y

[GitHub] [guacamole-client] necouchman commented on a diff in pull request #794: GUACAMOLE-1733: Add missing optional configuration options from docker start.sh script

2023-02-16 Thread via GitHub
necouchman commented on code in PR #794: URL: https://github.com/apache/guacamole-client/pull/794#discussion_r1108392443 ## guacamole-docker/bin/start.sh: ## @@ -1164,6 +1174,19 @@ if [ -n "$API_SESSION_TIMEOUT" ]; then associate_apisessiontimeout fi +# Maximum number of

[GitHub] [guacamole-client] ronansalmon commented on a diff in pull request #794: GUACAMOLE-1733: Add missing optional configuration options from docker start.sh script

2023-02-16 Thread via GitHub
ronansalmon commented on code in PR #794: URL: https://github.com/apache/guacamole-client/pull/794#discussion_r1108178184 ## guacamole-docker/bin/start.sh: ## @@ -1064,6 +1069,11 @@ fi set_property "guacd-hostname" "$GUACD_HOSTNAME" set_property "guacd-port" "$GUACD_PORT"