necouchman commented on PR #794:
URL: https://github.com/apache/guacamole-client/pull/794#issuecomment-1433847220
Okay, the changes are good, I believe; however, the final remaining item is
to clean up commits and commit messages. In particular:
* Each commit message should be descriptive
necouchman opened a new pull request, #415:
URL: https://github.com/apache/guacamole-server/pull/415
Add support for specifying the connection timeout for Telnet connections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
necouchman opened a new pull request, #414:
URL: https://github.com/apache/guacamole-server/pull/414
This pull request adds support for setting the connection timeout for SSH
and SFTP connections via connection parameters.
--
This is an automated message from the Apache Git Service.
To re
Sounds great.
After some tcpdumping the decisive paramenter should be TcpAckTimeout. Because:
I saw that after 5 seconds Guacamole sends a TCP keep alive, but after 9
seconds Guacamole sends a FIN to end the RDP connection attempt.
But as soon as the RDP connection is approved by an employee
ronansalmon commented on code in PR #794:
URL: https://github.com/apache/guacamole-client/pull/794#discussion_r1108507402
##
guacamole-docker/bin/start.sh:
##
@@ -1164,6 +1174,19 @@ if [ -n "$API_SESSION_TIMEOUT" ]; then
associate_apisessiontimeout
fi
+# Maximum number o
On Thu, Feb 16, 2023 at 2:07 AM Dyck, Martin (BITBW)
wrote:
>
> Hi Nick,
>
>
>
> thank you very much for the quick reply. That sounds promising.
>
> I have seen your pull request #413. So can we expect in the next guacamole
> release a way to modify the TcpAckTimeout? That would be gorgeous!
>
Y
necouchman commented on code in PR #794:
URL: https://github.com/apache/guacamole-client/pull/794#discussion_r1108392443
##
guacamole-docker/bin/start.sh:
##
@@ -1164,6 +1174,19 @@ if [ -n "$API_SESSION_TIMEOUT" ]; then
associate_apisessiontimeout
fi
+# Maximum number of
ronansalmon commented on code in PR #794:
URL: https://github.com/apache/guacamole-client/pull/794#discussion_r1108178184
##
guacamole-docker/bin/start.sh:
##
@@ -1064,6 +1069,11 @@ fi
set_property "guacd-hostname" "$GUACD_HOSTNAME"
set_property "guacd-port" "$GUACD_PORT"