[GitHub] [guacamole-client] mike-jumper commented on pull request #896: GUACAMOLE-1085: Migrate frontend to angular

2023-06-30 Thread via GitHub
mike-jumper commented on PR #896: URL: https://github.com/apache/guacamole-client/pull/896#issuecomment-1615295716 > Are there any plans to release an official NPM package for guacamole-common-js? If it should be done or needs to be done, then yes - absolutely. -- This is an automa

[GitHub] [guacamole-client] mike-jumper commented on pull request #896: GUACAMOLE-1085: Migrate frontend to angular

2023-06-30 Thread via GitHub
mike-jumper commented on PR #896: URL: https://github.com/apache/guacamole-client/pull/896#issuecomment-1615288511 :open_mouth: Thanks, @leonard2901! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [guacamole-client] leonard2901 opened a new pull request, #896: GUACAMOLE-1085: Migrate frontend to angular

2023-06-30 Thread via GitHub
leonard2901 opened a new pull request, #896: URL: https://github.com/apache/guacamole-client/pull/896 This PR includes the current progress for the migration of the AngularJS frontend to Angular. There is still a lot of work left to do, but I think now would be a good time to get some fe

Re: Decorating Extension with Single-Use Password

2023-06-30 Thread Nick Couchman
> > > > > You'll end up in a similar situation to what we were encountering with > > SAML+TOTP where anti-replay defenses conflict. You can work around that > > with the same approach (pending merge): allow reuse of the code/link > > while authentication is being refused only for transient reasons

Re: Decorating Extension with Single-Use Password

2023-06-30 Thread Nick Couchman
On Fri, Jun 30, 2023 at 12:43 PM Michael Jumper wrote: > > On 6/30/23 08:13, Nick Couchman wrote: > > I decided to take a shot at writing a One-Time Password extension that > > sends the OTP via e-mail, providing multi-factor authentication by > > implementing it as a decorating authentication ext

Re: Decorating Extension with Single-Use Password

2023-06-30 Thread Michael Jumper
On 6/30/23 08:13, Nick Couchman wrote: I decided to take a shot at writing a One-Time Password extension that sends the OTP via e-mail, providing multi-factor authentication by implementing it as a decorating authentication extension. I've got quite a bit of it written and mostly working, but I'm

Re: Decorating Extension with Single-Use Password

2023-06-30 Thread Nick Couchman
On Fri, Jun 30, 2023 at 11:13 AM Nick Couchman wrote: > > I decided to take a shot at writing a One-Time Password extension that > sends the OTP via e-mail, providing multi-factor authentication by > implementing it as a decorating authentication extension. I've got > quite a bit of it written and

[GitHub] [guacamole-client] jmuehlner commented on a diff in pull request #846: GUACAMOLE-1780: Fix TOTP interaction with SAML and SSL

2023-06-30 Thread via GitHub
jmuehlner commented on code in PR #846: URL: https://github.com/apache/guacamole-client/pull/846#discussion_r1248006675 ## extensions/guacamole-auth-sso/modules/guacamole-auth-sso-base/src/main/java/org/apache/guacamole/auth/sso/SSOAuthenticationEventListener.java: ## @@ -0,0 +1

[GitHub] [guacamole-client] mike-jumper commented on a diff in pull request #846: GUACAMOLE-1780: Fix TOTP interaction with SAML and SSL

2023-06-30 Thread via GitHub
mike-jumper commented on code in PR #846: URL: https://github.com/apache/guacamole-client/pull/846#discussion_r1247982791 ## extensions/guacamole-auth-sso/modules/guacamole-auth-sso-base/src/main/java/org/apache/guacamole/auth/sso/SSOAuthenticationEventListener.java: ## @@ -0,0

Decorating Extension with Single-Use Password

2023-06-30 Thread Nick Couchman
I decided to take a shot at writing a One-Time Password extension that sends the OTP via e-mail, providing multi-factor authentication by implementing it as a decorating authentication extension. I've got quite a bit of it written and mostly working, but I'm running into one behavior that I cannot