[GitHub] incubator-guacamole-client pull request #191: GUACAMOLE-394: Refactor extens...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-guacamole-client/pull/191 ---

[GitHub] incubator-guacamole-client pull request #191: GUACAMOLE-394: Refactor extens...

Github user jmuehlner commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/191#discussion_r141450769 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/ActivityRecordSet.java --- @@ -0,0 +1,128 @@ +/* + *

[GitHub] incubator-guacamole-server pull request #114: GUACAMOLE-398: Fix memory leak...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-guacamole-server/pull/114 ---

[GitHub] incubator-guacamole-server pull request #114: GUACAMOLE-398: Fix memory leak...

Github user necouchman commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/114#discussion_r141412631 --- Diff: src/common-ssh/ssh.c --- @@ -457,6 +457,7 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client,

[GitHub] incubator-guacamole-server pull request #114: GUACAMOLE-398: Fix memory leak...

Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/114#discussion_r141411562 --- Diff: src/common-ssh/ssh.c --- @@ -457,6 +457,7 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client,

[GitHub] incubator-guacamole-server pull request #114: GUACAMOLE-398: Fix memory leak...

GitHub user necouchman opened a pull request: https://github.com/apache/incubator-guacamole-server/pull/114 GUACAMOLE-398: Fix memory leak identified by Coverity Quick fix to correct a memory leak identified by the latest Coverity scan in the common ssh code. You can merge this

[GitHub] incubator-guacamole-client pull request #183: GUACAMOLE-362: Add support for...

Github user necouchman commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r141360655 --- Diff: extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/conf/ConfigurationService.java --- @@ -68,4

[GitHub] incubator-guacamole-client pull request #183: GUACAMOLE-362: Add support for...

Github user necouchman commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r141361436 --- Diff: extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/AuthenticationProviderService.java --- @@ -83,7

[GitHub] incubator-guacamole-client pull request #183: GUACAMOLE-362: Add support for...

Github user necouchman commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r141360602 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/properties/PrivateKeyGuacamoleProperty.java --- @@ -0,0 +1,81 @@ +/*

[GitHub] incubator-guacamole-client pull request #183: GUACAMOLE-362: Add support for...

Github user necouchman commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r141361788 --- Diff: extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/AuthenticationProviderService.java --- @@

[GitHub] incubator-guacamole-client pull request #183: GUACAMOLE-362: Add support for...

Github user necouchman commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r141359733 --- Diff: extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/ticket/TicketValidationService.java --- @@

[GitHub] incubator-guacamole-client pull request #183: GUACAMOLE-362: Add support for...

Github user necouchman commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r141360569 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/properties/PrivateKeyGuacamoleProperty.java --- @@ -0,0 +1,81 @@ +/*

[GitHub] incubator-guacamole-client pull request #182: GUACAMOLE-363: Add support for...

Github user necouchman commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/182#discussion_r141345122 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-sqlserver/schema/002-create-admin-user.sql --- @@ -0,0 +1,46

[GitHub] incubator-guacamole-client pull request #182: GUACAMOLE-363: Add support for...

Github user necouchman commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/182#discussion_r141345274 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-sqlserver/schema/001-create-schema.sql --- @@ -0,0 +1,558 @@

[GitHub] incubator-guacamole-client pull request #182: GUACAMOLE-363: Add support for...

Github user necouchman commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/182#discussion_r141342394 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-sqlserver/schema/002-create-admin-user.sql --- @@ -0,0 +1,46

[GitHub] incubator-guacamole-client pull request #182: GUACAMOLE-363: Add support for...

Github user necouchman commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/182#discussion_r141341854 --- Diff:

[GitHub] incubator-guacamole-client pull request #182: GUACAMOLE-363: Add support for...

Github user necouchman commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/182#discussion_r141341833 --- Diff:

[GitHub] incubator-guacamole-client pull request #182: GUACAMOLE-363: Add support for...

Github user necouchman commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/182#discussion_r141340510 --- Diff:

Re: [DISCUSS] Stalled PRs

> > To magically close #174, I included "closes #174" in my commit message. > GitHub will then automatically close the pull request noted once that > commit message is merged to master. Unless we're doing changes elsewhere > which remove the need for the original PRs, we won't be able to do this.

Re: [DISCUSS] Discontinuing uploads to SourceForge entirely

On Wed, Sep 27, 2017 at 3:41 AM, Mike Jumper wrote: > Before the Incubator, Guacamole was originally hosted on SourceForge. The > old SourceForge project has long since been closed down, but I've been > continuing to copy release artifacts to the old SourceForge

[GitHub] incubator-guacamole-client pull request #183: GUACAMOLE-362: Add support for...

Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r141267616 --- Diff: extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/AuthenticationProviderService.java --- @@

[GitHub] incubator-guacamole-client pull request #183: GUACAMOLE-362: Add support for...

Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r141266516 --- Diff: extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/conf/ConfigurationService.java --- @@ -68,4

[GitHub] incubator-guacamole-client pull request #183: GUACAMOLE-362: Add support for...

Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r141266397 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/properties/PrivateKeyGuacamoleProperty.java --- @@ -0,0 +1,81 @@

[GitHub] incubator-guacamole-client pull request #183: GUACAMOLE-362: Add support for...

Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r141266280 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/properties/PrivateKeyGuacamoleProperty.java --- @@ -0,0 +1,81 @@

[GitHub] incubator-guacamole-client pull request #183: GUACAMOLE-362: Add support for...

Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r141265939 --- Diff: extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/ticket/TicketValidationService.java --- @@

[DISCUSS] Discontinuing uploads to SourceForge entirely

Before the Incubator, Guacamole was originally hosted on SourceForge. The old SourceForge project has long since been closed down, but I've been continuing to copy release artifacts to the old SourceForge download locations to give users a grace period to migrate to the new location. My

Re: [DISCUSS] Stalled PRs

On Tue, Sep 26, 2017 at 7:40 PM, Nick Couchman wrote: > There are a couple of pull requests that have stalled with no response from > the original author. Okay, I have one myself that I need to go back and > finish up, but I'm more concerned about a couple of them that fix

[GitHub] incubator-guacamole-client pull request #182: GUACAMOLE-363: Add support for...

Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/182#discussion_r141254723 --- Diff:

[GitHub] incubator-guacamole-client pull request #182: GUACAMOLE-363: Add support for...

Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/182#discussion_r141254109 --- Diff:

[GitHub] incubator-guacamole-client pull request #182: GUACAMOLE-363: Add support for...

Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/182#discussion_r141254688 --- Diff:

[GitHub] incubator-guacamole-client pull request #182: GUACAMOLE-363: Add support for...

Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/182#discussion_r141252622 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-sqlserver/schema/001-create-schema.sql --- @@ -0,0 +1,558 @@

[GitHub] incubator-guacamole-client pull request #182: GUACAMOLE-363: Add support for...

Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/182#discussion_r141252815 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-sqlserver/schema/001-create-schema.sql --- @@ -0,0 +1,558 @@

[GitHub] incubator-guacamole-client pull request #182: GUACAMOLE-363: Add support for...

Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/182#discussion_r141255305 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-sqlserver/schema/002-create-admin-user.sql --- @@ -0,0 +1,46