[GitHub] incubator-guacamole-server pull request #123: GUACAMOLE-273: Add Brazillian ...

2017-11-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/123#discussion_r150938547 --- Diff: src/protocols/rdp/keymaps/pt_br_qwerty.keymap --- @@ -0,0 +1,58 @@ +# +# Licensed to the Apache Software

[GitHub] incubator-guacamole-server pull request #123: GUACAMOLE-273: Add Brazillian ...

2017-11-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/123#discussion_r150928082 --- Diff: src/protocols/rdp/keymaps/pt_br_qwerty.keymap --- @@ -0,0 +1,58 @@ +# +# Licensed to the Apache Software

[GitHub] incubator-guacamole-server pull request #122: GUACAMOLE-434: Add UK English ...

2017-11-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/122#discussion_r150927148 --- Diff: src/protocols/rdp/keymaps/en_gb_qwerty.keymap --- @@ -0,0 +1,56 @@ +# +# Licensed to the Apache Software

[GitHub] incubator-guacamole-client pull request #209: GUACAMOLE-161: Add missing pre...

2017-11-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/209#discussion_r150925860 --- Diff: guacamole-common-js/src/main/webapp/modules/Keyboard.js --- @@ -984,8 +1003,15 @@ Guacamole.Keyboard = function(element

[GitHub] incubator-guacamole-client pull request #209: GUACAMOLE-161: Add missing pre...

2017-11-13 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/209#discussion_r150676272 --- Diff: guacamole-common-js/src/main/webapp/modules/Keyboard.js --- @@ -984,8 +1003,15 @@ Guacamole.Keyboard = function(element

[GitHub] incubator-guacamole-server pull request #120: GUACAMOLE-424: Fix null pointe...

2017-11-13 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/120#discussion_r150634687 --- Diff: src/common/cursor.c --- @@ -34,6 +34,14 @@ #include #include + +/** + * Allocates a cursor

[GitHub] incubator-guacamole-server pull request #120: GUACAMOLE-424: Fix null pointe...

2017-11-13 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/120#discussion_r150634771 --- Diff: src/common/display.c --- @@ -99,6 +99,19 @@ static void guac_common_display_free_layers(guac_common_display_layer* layers

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-11-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r149186298 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ConfigurationService.java --- @@ -273,6

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-11-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r149186347 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ConfigurationService.java --- @@ -292,4

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-11-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r149184317 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-11-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r149186316 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ConfigurationService.java --- @@ -292,4

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-11-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r149184261 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-11-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r149186459 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/LDAPGuacamoleProperties.java --- @@ -174,4

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-11-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r149184453 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/UserService.java --- @@ -267,8 +285,23

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-11-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r149181098 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ReferralAuthHandler.java --- @@ -0,0 +1,80

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-11-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r149182139 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ReferralAuthHandler.java --- @@ -0,0 +1,80

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-11-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r149186411 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/LDAPGuacamoleProperties.java --- @@ -174,4

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-11-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r149186256 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ConfigurationService.java --- @@ -252,6

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-11-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r149186435 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/LDAPGuacamoleProperties.java --- @@ -174,4

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-11-06 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r149184513 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/UserService.java --- @@ -267,8 +285,23

[DISCUSS] Guacamole Podling Report (Draft) - November 2017

2017-10-31 Thread Mike Jumper
Hello all, Please find and discuss the below draft for Apache Guacamole's seventh podling report. In the interest of time, I've already added the current draft to the wiki page: https://wiki.apache.org/incubator/November2017 For reference, Apache Guacamole's previous reports can be found

[GitHub] incubator-guacamole-client pull request #206: GUACAMOLE-362: Fix resource le...

2017-10-28 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/206#discussion_r147570872 --- Diff: extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/conf/PrivateKeyGuacamoleProperty.java

[GitHub] incubator-guacamole-client pull request #206: GUACAMOLE-362: Fix resource le...

2017-10-28 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/206#discussion_r147563773 --- Diff: extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/conf/PrivateKeyGuacamoleProperty.java

[GitHub] incubator-guacamole-client pull request #206: GUACAMOLE-362: Fix resource le...

2017-10-28 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/206#discussion_r147560748 --- Diff: extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/conf/PrivateKeyGuacamoleProperty.java

[GitHub] incubator-guacamole-client pull request #206: GUACAMOLE-362: Fix resource le...

2017-10-28 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/206#discussion_r147559637 --- Diff: extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/conf/PrivateKeyGuacamoleProperty.java

[RESULT] [VOTE] Graduate Apache Guacamole as TLP

2017-10-28 Thread Mike Jumper
On Tue, Oct 24, 2017 at 9:10 PM, Mike Jumper <mjum...@apache.org> wrote: > Hello all, > > Given the current state of the Apache Guacamole podling, positive > discussion on this list regarding graduation [1] [2], and positive > feedback regarding graduation in our most recent

[GitHub] incubator-guacamole-client pull request #205: GUACAMOLE-412: Refactor UserEv...

2017-10-27 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/incubator-guacamole-client/pull/205 GUACAMOLE-412: Refactor UserEvent to provide AuthenticatedUser instead of UserContext. This change refactors `UserEvent` and related classes, representing user identity

[GitHub] incubator-guacamole-client pull request #180: GUACAMOLE-355: Catch CAS Error...

2017-10-27 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/180#discussion_r147493674 --- Diff: guacamole/src/main/webapp/app/login/styles/dialog.css --- @@ -116,9 +116,6 @@ } .login-ui.continuation

[GitHub] incubator-guacamole-client pull request #183: GUACAMOLE-362: Add support for...

2017-10-27 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r147473323 --- Diff: extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/conf/PrivateKeyGuacamoleProperty.java

[GitHub] incubator-guacamole-server pull request #120: GUACAMOLE-424: Fix null pointe...

2017-10-25 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/120#discussion_r146898961 --- Diff: src/protocols/vnc/user.c --- @@ -112,8 +112,10 @@ int guac_vnc_user_leave_handler(guac_user* user

Re: Preparing the community graduation vote

2017-10-24 Thread Mike Jumper
On Sun, Oct 22, 2017 at 5:03 PM, Mike Jumper <mike.jum...@guac-dev.org> wrote: > On Sun, Oct 22, 2017 at 12:50 PM, Mike Jumper <mike.jum...@guac-dev.org> > wrote: >> On Sat, Oct 21, 2017 at 8:30 PM, Jean-Baptiste Onofré <j...@nanthrax.net> >> wrote: >&

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-10-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r146658052 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-10-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r146657553 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/UserService.java --- @@ -107,19 +108,37

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-10-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r146657406 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-10-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r146657508 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-10-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r146655739 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ReferralAuthHandler.java --- @@ -0,0 +1,97

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-10-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r146655204 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ReferralAuthHandler.java --- @@ -0,0 +1,97

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-10-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r146655137 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ReferralAuthHandler.java --- @@ -0,0 +1,97

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-10-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r146654775 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ReferralAuthHandler.java --- @@ -0,0 +1,97

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-10-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r146654730 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ReferralAuthHandler.java --- @@ -0,0 +1,97

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-10-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r146654624 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/LDAPConnectionService.java --- @@ -111,6

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-10-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r146653140 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/LDAPConnectionService.java --- @@ -111,6

[GitHub] incubator-guacamole-client pull request #202: GUACAMOLE-243: Allow LDAP refe...

2017-10-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/202#discussion_r146647996 --- Diff: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/LDAPConnectionService.java --- @@ -111,6

Re: [DISCUSS] Next Release?

2017-10-24 Thread Mike Jumper
On Tue, Oct 24, 2017 at 6:06 AM, Nick Couchman wrote: > > > > > Great - sounds like we're in agreement. ;) > > > > I'll retag things as described and create the > > "staging/0.9.14-incubating" branches [1]. Once the staging branches > > exist, depending on the issue, some PRs

[GitHub] incubator-guacamole-server pull request #120: GUACAMOLE-424: Fix null pointe...

2017-10-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/120#discussion_r146633955 --- Diff: src/protocols/vnc/user.c --- @@ -112,8 +112,10 @@ int guac_vnc_user_leave_handler(guac_user* user

[GitHub] incubator-guacamole-server pull request #118: GUACAMOLE-384: fixing segfault...

2017-10-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/118#discussion_r146480623 --- Diff: src/terminal/terminal/terminal.h --- @@ -492,6 +492,14 @@ int guac_terminal_render_frame(guac_terminal* terminal

[GitHub] incubator-guacamole-server pull request #118: GUACAMOLE-384: fixing segfault...

2017-10-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/118#discussion_r146480887 --- Diff: src/protocols/ssh/ssh.c --- @@ -340,6 +346,12 @@ void* ssh_client_thread(void* data) { break

[GitHub] incubator-guacamole-server pull request #118: GUACAMOLE-384: fixing segfault...

2017-10-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/118#discussion_r146477301 --- Diff: src/terminal/terminal/terminal.h --- @@ -492,6 +492,14 @@ int guac_terminal_render_frame(guac_terminal* terminal

[GitHub] incubator-guacamole-server pull request #118: GUACAMOLE-384: fixing segfault...

2017-10-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/118#discussion_r146481288 --- Diff: src/protocols/ssh/client.c --- @@ -70,8 +70,12 @@ int guac_ssh_client_free_handler(guac_client* client

Re: [DISCUSS] Next Release?

2017-10-23 Thread Mike Jumper
t a blocker overall, >> though. >> > > Cool, thanks for the update. Sounds promising. Do you have it in a Github > repo somwhere? > Yep: https://github.com/mike-jumper/incubator-guacamole-server/tree/xf86-video-guac > ... > Sounds good. ... > ... > Fine with

Re: [DISCUSS] Next Release?

2017-10-23 Thread Mike Jumper
On Mon, Oct 23, 2017 at 11:25 AM, Nick Couchman wrote: >> >> I would be in favor of finalizing scope for 0.9.14-incubating. There's >> quite a few changes ready, and several others waiting only on review >> or documentation: >> >>

Re: [DISCUSS] Next Release?

2017-10-23 Thread Mike Jumper
On Mon, Oct 23, 2017 at 5:53 AM, Nick Couchman wrote: > So, I saw Mike updating some JIRA issues for fix releases - not sure if > that was some work to prep for a new release? It's been about 3 months > since our last one, with several significant changes - are we ready to push

Re: Preparing the community graduation vote

2017-10-22 Thread Mike Jumper
On Sun, Oct 22, 2017 at 12:50 PM, Mike Jumper <mike.jum...@guac-dev.org> wrote: > On Sat, Oct 21, 2017 at 8:30 PM, Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: >> Hi Mike, >> >> first, I would start with the evaluation check list. It's not formally

[GitHub] incubator-guacamole-website pull request #48: WIP: Add podling maturity eval...

2017-10-22 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/incubator-guacamole-website/pull/48 WIP: Add podling maturity evaluation. As [discussed on the mailing list](https://lists.apache.org/thread.html/a5259173a8ef4a1d2bb7be2d99d3cbc2ccf8856130ae6e3fe54e079e

Re: [DISCUSS] Stalled PRs

2017-10-22 Thread Mike Jumper
On Sat, Oct 21, 2017 at 7:25 PM, Nick Couchman wrote: >> >> My blunt opinion would be that we should never take over changes. The >> point of an open source community like Apache Guacamole is >> collaboration. There's a big difference between a contribution from a >> contributor

Re: [DISCUSS] Stalled PRs

2017-10-21 Thread Mike Jumper
On Tue, Oct 17, 2017 at 5:43 AM, Nick Couchman wrote: >> >> Alright, then. Guess there's nothing to do now but close the pull requests. >> If it's possible to use ASF's deployment of Git Box (I don't know what's >> required here), then we can do this ourselves. Otherwise, might

[GitHub] incubator-guacamole-server pull request #118: GUACAMOLE-384: fixing segfault...

2017-10-21 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/118#discussion_r146113065 --- Diff: src/protocols/ssh/client.c --- @@ -70,8 +70,14 @@ int guac_ssh_client_free_handler(guac_client* client

[GitHub] incubator-guacamole-server pull request #118: GUACAMOLE-384: fixing segfault...

2017-10-20 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/118#discussion_r146080194 --- Diff: src/protocols/ssh/client.c --- @@ -70,8 +70,14 @@ int guac_ssh_client_free_handler(guac_client* client

[GitHub] incubator-guacamole-client pull request #197: GUACAMOLE-412: Prevent excepti...

2017-10-20 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/197#discussion_r145886535 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/event/AuthenticationSuccessEvent.java --- @@ -43,19 +44,19

[GitHub] incubator-guacamole-server pull request #118: GUACAMOLE-384: fixing segfault...

2017-10-19 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/118#discussion_r145865862 --- Diff: src/protocols/ssh/client.c --- @@ -70,8 +70,14 @@ int guac_ssh_client_free_handler(guac_client* client

Re: [DISCUSS] Stalled PRs

2017-10-16 Thread Mike Jumper
On Mon, Oct 16, 2017 at 7:47 PM, Nick Couchman wrote: > On Sat, Sep 30, 2017 at 3:38 PM, Nick Couchman wrote: > > > > > > I did track down e-mail address (via JIRA) for the two folks with the > > aforementioned PRs and e-mailed them directly to see if they

[GitHub] incubator-guacamole-client pull request #183: GUACAMOLE-362: Add support for...

2017-10-16 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r144761726 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/properties/PrivateKeyGuacamoleProperty.java --- @@ -0,0 +1,95

[GitHub] incubator-guacamole-client pull request #183: GUACAMOLE-362: Add support for...

2017-10-15 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r144711034 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/properties/PrivateKeyGuacamoleProperty.java --- @@ -0,0 +1,95

Re: script before & after connecting

2017-10-13 Thread Mike Jumper
2017-10-13 12:50 GMT-07:00 Jonathan Haché-Deschênes < jhache-desche...@infoplus.ca>: > Is there a way to execute script on “guacamole server” before > connecting a specific RDP, VNC, TELNET, SSH connexion. > > We want to be able to execute script before connecting to session. > > - Start

[GitHub] incubator-guacamole-client pull request #198: GUACAMOLE-415: Add support for...

2017-10-13 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/198#discussion_r144631879 --- Diff: extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-sqlite/src/main/java/org/apache/guacamole/auth/sqlite

[GitHub] incubator-guacamole-client pull request #183: GUACAMOLE-362: Add support for...

2017-10-12 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r144460945 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/properties/PrivateKeyGuacamoleProperty.java --- @@ -0,0 +1,95

Re: [DISCUSS] JDBC SQLite Module?

2017-10-12 Thread Mike Jumper
On Thu, Oct 12, 2017 at 7:50 AM, Nick Couchman wrote: > > Just wanted to throw this out for discussion - is there any interest in a > JDBC SQLite module? Seems like maybe it would provide a good method for > people to test/tinker with Guacamole before actually implementing it.

[GitHub] incubator-guacamole-client pull request #183: GUACAMOLE-362: Add support for...

2017-10-10 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r143890955 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/properties/PrivateKeyGuacamoleProperty.java --- @@ -0,0 +1,95

[GitHub] incubator-guacamole-client pull request #183: GUACAMOLE-362: Add support for...

2017-10-10 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r143890795 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/properties/PrivateKeyGuacamoleProperty.java --- @@ -0,0 +1,95

[GitHub] incubator-guacamole-client pull request #183: GUACAMOLE-362: Add support for...

2017-10-10 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r143890893 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/properties/PrivateKeyGuacamoleProperty.java --- @@ -0,0 +1,95

[GitHub] incubator-guacamole-client pull request #183: GUACAMOLE-362: Add support for...

2017-10-10 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r143890461 --- Diff: extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/ticket/TicketValidationService.java

[GitHub] incubator-guacamole-client pull request #183: GUACAMOLE-362: Add support for...

2017-10-10 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r143891620 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/properties/PrivateKeyGuacamoleProperty.java --- @@ -0,0 +1,95

Re: Guacamole web client

2017-10-08 Thread Mike Jumper
On Sat, Oct 7, 2017 at 12:20 PM, Craig Jones wrote: > Thanks Mike for your prompt reply, really appreciate it. > > No problem. Also, please beware that you are not subscribed to the dev@ list, and your emails keep hitting the moderation queue. You need to subscribe

[GitHub] incubator-guacamole-server pull request #109: GUACAMOLE-388: resolve null po...

2017-10-08 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-server/pull/109#discussion_r143347204 --- Diff: src/protocols/vnc/user.c --- @@ -112,6 +112,9 @@ int guac_vnc_user_leave_handler(guac_user* user

Re: contributing documentation

2017-10-06 Thread Mike Jumper
On Fri, Oct 6, 2017 at 1:06 PM, carl harris wrote: > I was thinking of writing a section for the manual to describe the newly > merged listener extension support, using an approach similar to the > existing chapter "Custom Authentication." > > What's the right way to

Re: Guacamole web client

2017-10-06 Thread Mike Jumper
On Fri, Oct 6, 2017 at 3:51 AM, Craig Jones wrote: > ... > > Is it possible to connect to a designated machine using the tunnel? Maybe > another library? > You can connect wherever you like, and it's entirely up to you to dictate within your application how the

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143105648 --- Diff: guacamole/src/main/java/org/apache/guacamole/extension/ExtensionModule.java --- @@ -188,6 +195,49 @@ private void

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143105340 --- Diff: guacamole/src/main/java/org/apache/guacamole/tunnel/TunnelRequestService.java --- @@ -58,6 +62,58 @@ private

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143105757 --- Diff: guacamole/src/main/java/org/apache/guacamole/extension/ListenerFactory.java --- @@ -0,0 +1,256

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143104765 --- Diff: guacamole/src/main/java/org/apache/guacamole/extension/ProviderFactory.java --- @@ -0,0 +1,101

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143104981 --- Diff: guacamole/src/main/java/org/apache/guacamole/extension/ProviderFactory.java --- @@ -0,0 +1,101

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143105666 --- Diff: guacamole/src/main/java/org/apache/guacamole/extension/ListenerFactory.java --- @@ -0,0 +1,256

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143105788 --- Diff: guacamole/src/main/java/org/apache/guacamole/extension/ListenerFactory.java --- @@ -0,0 +1,256

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143105313 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/event/ListenerService.java --- @@ -0,0 +1,53

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143106204 --- Diff: guacamole/src/main/java/org/apache/guacamole/extension/ListenerFactory.java --- @@ -0,0 +1,256

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143105024 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/auth/AuthenticationService.java --- @@ -75,6 +79,12

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143106189 --- Diff: guacamole/src/main/java/org/apache/guacamole/extension/ListenerFactory.java --- @@ -0,0 +1,256

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143105739 --- Diff: guacamole/src/main/java/org/apache/guacamole/extension/ListenerFactory.java --- @@ -0,0 +1,256

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143106271 --- Diff: guacamole/src/main/java/org/apache/guacamole/extension/ListenerFactory.java --- @@ -0,0 +1,256

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143106213 --- Diff: guacamole/src/main/java/org/apache/guacamole/extension/ListenerFactory.java --- @@ -0,0 +1,256

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143105548 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/event/listener/Listener.java --- @@ -0,0 +1,51

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143105779 --- Diff: guacamole/src/main/java/org/apache/guacamole/extension/ListenerFactory.java --- @@ -0,0 +1,256

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143105353 --- Diff: guacamole/src/main/java/org/apache/guacamole/tunnel/TunnelRequestService.java --- @@ -58,6 +62,58 @@ private

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143106229 --- Diff: guacamole/src/main/java/org/apache/guacamole/extension/ListenerFactory.java --- @@ -0,0 +1,256

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143104552 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/event/listener/TunnelCloseListener.java --- @@ -25,11 +25,15

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143104561 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/event/listener/TunnelConnectListener.java --- @@ -25,7 +25,11

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143104963 --- Diff: guacamole/src/main/java/org/apache/guacamole/extension/ProviderFactory.java --- @@ -0,0 +1,101

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143105704 --- Diff: guacamole/src/main/java/org/apache/guacamole/extension/ListenerFactory.java --- @@ -0,0 +1,256

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143106160 --- Diff: guacamole/src/main/java/org/apache/guacamole/extension/ListenerFactory.java --- @@ -0,0 +1,256

[GitHub] incubator-guacamole-client pull request #184: GUACAMOLE-364: authentication ...

2017-10-05 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143105331 --- Diff: guacamole/src/main/java/org/apache/guacamole/tunnel/TunnelRequestService.java --- @@ -58,6 +62,58 @@ private

  1   2   3   4   5   6   7   >