Re: [announce] New committer - Jesse Wilson

2009-11-13 Thread Pavel Pervov
Congratulations, Jesse! Welcome to the Harmony! On Fri, Nov 6, 2009 at 6:47 PM, Tim Ellison t.p.elli...@gmail.com wrote: On behalf of the PMC, I am delighted to welcome Jesse Wilson as our newest committer on the Apache Harmony project. Jesse has been sending in numerous patches to core areas

Re: [jira] Updated: (HARMONY-6375) [classlib][nio]ServerSocketChannel hang when the main thread is waiting for request to accept and another thread try to configure the block mode on one channel

2009-11-13 Thread Mark Hindess
In message 55080442.1258095819685.javamail.j...@brutus, Ray Chen (JIRA) writes: Ray Chen updated HARMONY-6375: -- Attachment: Harmony6375TestCase.java It is a test case which can reproduce the problem [classlib][nio]ServerSocketChannel hang when the main

[classlib] Testing multithreaded behaviour

2009-11-13 Thread Mark Hindess
Those clever guys at google wrote so code to help testing multithread behaviour: http://code.google.com/p/thread-weaver/ Anyone tried this? I wonder if we could use this to avoid arbitrary sleeps that slow down our tests and potentially make them unstable? Regards, Mark.

Re: [classlib] Testing multithreaded behaviour

2009-11-13 Thread Jesse Wilson
On Fri, Nov 13, 2009 at 1:48 AM, Mark Hindess mark.hind...@googlemail.comwrote: Anyone tried this? I wonder if we could use this to avoid arbitrary sleeps that slow down our tests and potentially make them unstable? That's what Weaver is intended for! And it also lets you test concurrency

Re: [classlib] Fixing an unsafe reference in InputStream

2009-11-13 Thread Tim Ellison
On 12/Nov/2009 19:20, Vijay Menon wrote: Right, writes - even unsynchronized ones - to the same cache line are problematic. Here's a good quick read on this: http://en.wikipedia.org/wiki/MESI_protocol. Recent Intel architectures adapt this protocol. Here's the interesting bit: A write

Re: svn commit: r835212 - /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/io/BufferedReader.java

2009-11-13 Thread Tim Ellison
This commit breaks a couple of existing compatibility tests for BufferedReader: java.lang.NullPointerException: buffer is null at java.io.BufferedReader.read(BufferedReader.java:282) at

Re: svn commit: r835212 - /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/io/BufferedReader.java

2009-11-13 Thread Jesse Wilson
On Fri, Nov 13, 2009 at 9:22 AM, Tim Ellison t.p.elli...@gmail.com wrote: This commit breaks a couple of existing compatibility tests for BufferedReader: Yup, I saw this and I'm fixing it. I suspect it's just a bogus test. Sorry about that!

Re: svn commit: r835212 - /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/io/BufferedReader.java

2009-11-13 Thread Jesse Wilson
On Fri, Nov 13, 2009 at 9:41 AM, Tim Ellison t.p.elli...@gmail.com wrote: I took a look at the tests briefly, they are checking exception throwing compatibility, something that we aim to maintain with the RI as rightly or wrongly apps depend upon non-spec'd behavior. Sorry about this guys.

SneakyThrow!

2009-11-13 Thread Jesse Wilson
Harmony team, In the process of fixing a bug, I just checked in SneakyThrowhttp://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/org/apache/harmony/luni/util/SneakyThrow.java?revision=835972view=markup. This is a weird API that probably won't see much use. But it

Doubting exception priority compatibility

2009-11-13 Thread Jesse Wilson
Harmony team, I'm skeptical of the utility of being exception-priority compatible with the RI. We have a wiki pagehttp://wiki.apache.org/harmony/Exception-throwing_compatibility describes our goals, but I don't think these are worth their costs. Recently I broke tests by breaking exception