Re: Commit to 5 or 6?

2010-10-09 Thread Alexei Fedotov
Jesse, I'm trying to understand best coding practices. Do you mean replacing assertTrue to assertEquals for assertions like a = b? isAvailable() assertions still may be implemented via assertTrue? -- With best regards / с наилучшими пожеланиями, Alexei Fedotov / Алексей Федотов,

Re: Commit to 5 or 6?

2010-10-09 Thread Jesse Wilson
On Sat, Oct 9, 2010 at 5:58 AM, Alexei Fedotov alexei.fedo...@gmail.comwrote: I'm trying to understand best coding practices. Do you mean replacing assertTrue to assertEquals for assertions like a = b? isAvailable() assertions still may be implemented via assertTrue? Mostly I prefer this:

Re: Commit to 5 or 6?

2010-10-09 Thread Mark Hindess
In message aanlktimrq6wh546m+kxvusvgswrux4mu5eqhqgp5a...@mail.gmail.com, Jesse Wilson writes: [snip] It comes up less frequently, but I have some other preferences related to better detail messages. When comparing arrays, equals() does the wrong thing. To work around, I compare the string