Re: Commit to 5 or 6?

2010-10-10 Thread Alexei Fedotov
Jesse, Mark, Thanks for explaining your point! -- With best regards / с наилучшими пожеланиями, Alexei Fedotov / Алексей Федотов, http://dataved.ru/ +7 916 562 8095 On Sun, Oct 10, 2010 at 12:36 AM, Mark Hindess mark.hind...@googlemail.com wrote: In message

Re: Commit to 5 or 6?

2010-10-09 Thread Alexei Fedotov
Jesse, I'm trying to understand best coding practices. Do you mean replacing assertTrue to assertEquals for assertions like a = b? isAvailable() assertions still may be implemented via assertTrue? -- With best regards / с наилучшими пожеланиями, Alexei Fedotov / Алексей Федотов,

Re: Commit to 5 or 6?

2010-10-09 Thread Jesse Wilson
On Sat, Oct 9, 2010 at 5:58 AM, Alexei Fedotov alexei.fedo...@gmail.comwrote: I'm trying to understand best coding practices. Do you mean replacing assertTrue to assertEquals for assertions like a = b? isAvailable() assertions still may be implemented via assertTrue? Mostly I prefer this:

Re: Commit to 5 or 6?

2010-10-09 Thread Mark Hindess
In message aanlktimrq6wh546m+kxvusvgswrux4mu5eqhqgp5a...@mail.gmail.com, Jesse Wilson writes: [snip] It comes up less frequently, but I have some other preferences related to better detail messages. When comparing arrays, equals() does the wrong thing. To work around, I compare the string

Re: Commit to 5 or 6?

2010-10-05 Thread Tim Ellison
On 05/Oct/2010 00:09, Jesse Wilson wrote: I'm planning to do some work on the Harmony 6 tests. I'm planning to do small improvements: isolating tests for security managers, replace assertTrue() with assertEquals(), etc. This work will be driven by me trying to get Android's class library