Re: Rethinking testing conventions

2010-03-10 Thread Jesse Wilson
On Tue, Mar 9, 2010 at 5:01 PM, Nathan Beyer ndbe...@apache.org wrote: One concept I've been working with is using annotations to describe the tests for the purposes of exclusions and for platform definition. The annotations can then be utilized in many ways via JUnit - method rules, request

Re: Rethinking testing conventions

2010-03-10 Thread Charles Lee
On Wed, Mar 10, 2010 at 9:01 AM, Nathan Beyer ndbe...@apache.org wrote: I've been experimenting with JUnit4 extensions in an attempt to find a more simple approach to our basic testing needs. The two major requirements that I see in Harmony's test infrastructure (at least the classlib stuff)

Re: Rethinking testing conventions

2010-03-10 Thread Nathan Beyer
On Tue, Mar 9, 2010 at 10:45 PM, Charles Lee littlee1...@gmail.com wrote: +1. @Platform is the specified annotation or is the annotation used in junit4? Platform and Exclude would be a custom annotations - perhaps org.apache.harmony.test.Platform. Then there'd be a custom runner or filter

Re: Rethinking testing conventions

2010-03-10 Thread Nathan Beyer
On Wed, Mar 10, 2010 at 3:39 PM, Jesse Wilson jessewil...@google.com wrote: On Tue, Mar 9, 2010 at 5:01 PM, Nathan Beyer ndbe...@apache.org wrote: One concept I've been working with is using annotations to describe the tests for the purposes of exclusions and for platform definition. The

Re: Rethinking testing conventions

2010-03-10 Thread Nathan Beyer
On Wed, Mar 10, 2010 at 7:38 PM, Charles Lee littlee1...@gmail.com wrote: On Wed, Mar 10, 2010 at 9:01 AM, Nathan Beyer ndbe...@apache.org wrote: I've been experimenting with JUnit4 extensions in an attempt to find a more simple approach to our basic testing needs. The two major requirements

Rethinking testing conventions

2010-03-09 Thread Nathan Beyer
I've been experimenting with JUnit4 extensions in an attempt to find a more simple approach to our basic testing needs. The two major requirements that I see in Harmony's test infrastructure (at least the classlib stuff) are - exclusions and platform-specific tests. (I'm ignoring the

Re: Rethinking testing conventions

2010-03-09 Thread Charles Lee
That's great. But most old test case is in JUnit 3.8 style. We can follow the latest junit when we add the new test cases. What about the old ones? On Wed, Mar 10, 2010 at 9:01 AM, Nathan Beyer ndbe...@apache.org wrote: I've been experimenting with JUnit4 extensions in an attempt to find a

Re: Rethinking testing conventions

2010-03-09 Thread Nathan Beyer
On Tue, Mar 9, 2010 at 8:50 PM, Charles Lee littlee1...@gmail.com wrote: That's great. But most old test case is in JUnit 3.8 style. We can follow the latest junit when we add the new test cases. What about the old ones? We've been using JUnit 4 runners for a long time now. JUnit 4 style tests

Re: Rethinking testing conventions

2010-03-09 Thread Charles Lee
+1. @Platform is the specified annotation or is the annotation used in junit4? On Wed, Mar 10, 2010 at 11:34 AM, Nathan Beyer ndbe...@apache.org wrote: On Tue, Mar 9, 2010 at 8:50 PM, Charles Lee littlee1...@gmail.com wrote: That's great. But most old test case is in JUnit 3.8 style. We can