HBASE-4636 (Allow CF to retain deleted rows) is ready for final comments

2011-10-20 Thread lars hofhansl
https://issues.apache.org/jira/browse/HBASE-4536 I have been working on this for a while and am planning to commit this to trunk tomorrow. As usual, please share any last questions/concerns/comments. I am expecting some followup work from this (supporting "raw" scans in the export tool came up

Re: suggestion for smoother code review process

2011-10-20 Thread Akash Ashok
On Fri, Oct 21, 2011 at 3:35 AM, Todd Lipcon wrote: > Hey Ted, > > I agree the formatting of the reviewboard comments back onto JIRA > could be improved. I wrote the original script that does it - it's > some nasty procmail and python. > Hey Todd, I would like to work on this. Also Is it nasty pr

Re: [unit tests] small tests vs. others

2011-10-20 Thread Akash Ashok
Ooo +1 on this. This sounds Just wonderful. :) Cheers, Akash A On Fri, Oct 21, 2011 at 3:34 AM, Andrew Purtell wrote: > +1, this sounds great. > > In 0.20 I had the REST (aka Stargate at that time) tests running all in > single JVM but in the port to 0.90 had to be updated for the current > sur

Re: suggestion for smoother code review process

2011-10-20 Thread Nicolas Spiegelberg
Step 1 for Phabricator is to reach parity with the current Review Board utilities. Step 2 is to improve formatting and minimize redundancy. I agree with Jonathan's comments: if you see something got added to RB/Phab, interact with the dialog there instead of trying to use JIRA directly. On 10/20

Re: suggestion for smoother code review process

2011-10-20 Thread Jonathan Hsieh
My tendency has always been to look first for reviews on reviewboard and to take advantage of the interface there. I've found the bugs file link to be really helpful, but agree that the ugly mail to the jira is somewhat annoying. Jon. On Thu, Oct 20, 2011 at 3:22 PM, Ted Yu wrote: > I looked a

Re: suggestion for smoother code review process

2011-10-20 Thread Ted Yu
I looked at John Sichi's comment, obviously issued from phabricator, for HBASE-4532 @ 18/Oct/11 23:41 I don't see much difference from feedback from review board - AFFECTED FILES were included. One thing I do like the postback from review board is the nice layout viewable in Yahoo email but not g

Re: suggestion for smoother code review process

2011-10-20 Thread Ted Yu
I think the easiest improvement is to strip the list of files from reviewboard feedback. I would wait for a while to see if any volunteer comes up for the above task :-) I am not sure about phabricator which requires an account. I remember seeing phabricator feedback in JIRA. The format is differ

Re: suggestion for smoother code review process

2011-10-20 Thread Ted Yu
That's why I would get nervous if I step away from computer for an hour :-) On Thu, Oct 20, 2011 at 3:06 PM, Andrew Purtell wrote: > +1 > > dev@ is not really possible to follow anymore, unless full time on HBase. > > > Best regards, > > > - Andy > > > > > >

Re: suggestion for smoother code review process

2011-10-20 Thread Andrew Purtell
+1 dev@ is not really possible to follow anymore, unless full time on HBase. Best regards,   - Andy > >From: Ted Yu >To: dev@hbase.apache.org >Sent: Thursday, October 20, 2011 3:03 PM >Subject: suggestion for smoother code review process > >Hi, >We have

Re: suggestion for smoother code review process

2011-10-20 Thread Todd Lipcon
Hey Ted, I agree the formatting of the reviewboard comments back onto JIRA could be improved. I wrote the original script that does it - it's some nasty procmail and python. It sounds like the FB folks are working on getting phabricator up - maybe it will have better JIRA integration? Let me kno

Re: [unit tests] small tests vs. others

2011-10-20 Thread Andrew Purtell
+1, this sounds great. In 0.20 I had the REST (aka Stargate at that time) tests running all in single JVM but in the port to 0.90 had to be updated for the current surefire config. If there were a small/medium convention at that time the relative speed could have been preserved.     - Andy

suggestion for smoother code review process

2011-10-20 Thread Ted Yu
Hi, We have been using review board for a while to conduct code review. One aspect I don't like the integration is that every round of review would result in the summary and list of files (both of which could be long) to be reposted to JIRA. For a large project, such as HBASE-2856 or HBASE-3777, it

Re: [unit tests] small tests vs. others

2011-10-20 Thread Gary Helmling
+1 on small/medium/large I have a test mvn repo up on people.apache.org that we can use for a patched surefire build, if that helps. On Thu, Oct 20, 2011 at 2:33 PM, Jonathan Gray wrote: > +1 on small/medium/large. > >> -Original Message- >> From: Todd Lipcon [mailto:t...@cloudera.com]

Build failed in Jenkins: hbase-0.90 #329

2011-10-20 Thread Apache Jenkins Server
See Changes: [stack] HBASE-4378 [hbck] Does not complain about regions with startkey==endkey. -- [...truncated 1636 lines...] Running org.apache.hadoop.hbase.mapred.TestTableInputFormat Tests run: 6, F

RE: [unit tests] small tests vs. others

2011-10-20 Thread Jonathan Gray
+1 on small/medium/large. > -Original Message- > From: Todd Lipcon [mailto:t...@cloudera.com] > Sent: Thursday, October 20, 2011 1:49 PM > To: dev@hbase.apache.org > Subject: Re: [unit tests] small tests vs. others > > +1 on separating into small/medium/large. One of the requirements of >

Re: Potential memory leak in client RPC timeout mechanism

2011-10-20 Thread Jean-Daniel Cryans
Yeah it does that if the heap is big... mmm dev could be useful but it's a guess, as what's eating all that mem might be too small there and buried under the rest. J-D On Wed, Oct 19, 2011 at 7:00 PM, Shrijeet Paliwal wrote: > Stack, I have created https://issues.apache.org/jira/browse/HBASE-463

Re: [unit tests] small tests vs. others

2011-10-20 Thread Stack
Sounds good Nicolas. St.Ack On Thu, Oct 20, 2011 at 1:46 PM, N Keywal wrote: > Hi, > > I've done a stat on the tests we have. Many of them are actually quite > simple: There are 226 test classes in HBase.  100  of them does not use a > cluster, and takes less than 2 seconds to execute. 24 do not

Re: [unit tests] small tests vs. others

2011-10-20 Thread Todd Lipcon
+1 on separating into small/medium/large. One of the requirements of "small" should be that it can run parallel with other tests and in nofork mode. See SUREFIRE-329 for the necessary surefire patch. Until that's integrated upstream we'd have to have our own patched surefire :( -Todd On Thu, Oct

[unit tests] small tests vs. others

2011-10-20 Thread N Keywal
Hi, I've done a stat on the tests we have. Many of them are actually quite simple: There are 226 test classes in HBase. 100 of them does not use a cluster, and takes less than 2 seconds to execute. 24 do not use a cluster but need between 2 and 40 seconds. I tried to execute these with differen

Jenkins build is back to normal : HBase-TRUNK #2345

2011-10-20 Thread Apache Jenkins Server
See

Re: If I run Hive queries on external HBase tables, then does blooms will be used?

2011-10-20 Thread Jean-Daniel Cryans
(this is a usage question, putting dev@ in BCC and sending to user@) Yes, it will as it's in run inside the region servers. J-D On Thu, Oct 20, 2011 at 11:40 AM, AnilKumar B wrote: > Hi > > I have created HBase table and setted the bloom filter to some column > family. And I am running Hive qu

Re: HBase Trunk Hung

2011-10-20 Thread Stack
I wrote to bui...@apache.org to ask them kill it (and get a thread dump first). St.Ack On Thu, Oct 20, 2011 at 10:45 AM, Ted Yu wrote: > Currently HBase-0.92 is configured with 191 minutes timeout. > The build should have been aborted since it got stuck. > > Obviously the timeout isn't applicable

If I run Hive queries on external HBase tables, then does blooms will be used?

2011-10-20 Thread AnilKumar B
Hi I have created HBase table and setted the bloom filter to some column family. And I am running Hive queries on this HBase table. Is there any use of those blooms, which are setted for HBase column family? Thanks & Regards, B Anil Kumar.

Re: HBase Trunk Hung

2011-10-20 Thread Ted Yu
Currently HBase-0.92 is configured with 191 minutes timeout. The build should have been aborted since it got stuck. Obviously the timeout isn't applicable in certain cases. I tried to stop the build but wasn't able to. FYI On Thu, Oct 20, 2011 at 10:41 AM, Akash Ashok wrote: > On Thu, Oct 20,

Re: HBase Trunk Hung

2011-10-20 Thread Akash Ashok
On Thu, Oct 20, 2011 at 11:04 PM, Jonathan Hsieh wrote: > Jenkins has setting for having jobs time out after a certain amount I'd > time. on my instances I've bumped 0.92 and trunk builds to 400 minutes or > so. > > It would be great to be able to have the apahe Jenkins job settings > readable

Re: HBase Trunk Hung

2011-10-20 Thread Jonathan Hsieh
Jenkins has setting for having jobs time out after a certain amount I'd time. on my instances I've bumped 0.92 and trunk builds to 400 minutes or so. It would be great to be able to have the apahe Jenkins job settings readable (but not writable) by contributors. Currently it is a black box so

Re: HBase Trunk Hung

2011-10-20 Thread Akash Ashok
Yup its still Hung. Can't one of the committers ask for the permission to delete a build ? Sounds like a easier fix than raising an issue to INFRA. Just a suggestion. I am not truly aware as to who is given what permissions on Jenkins and why :) Also now may be the time to see if Jenkins deletes t

Re: Hbase client do not able to connect with remote Hbase server

2011-10-20 Thread Ali Raza
Hi Doug Meil, I have tried it without setting hbase.master too but still throws the same exception. I forgot to tell that i have installed hbase in standalone mode on a separate machinesorry for that. Thanks for your reply. Regards Syed Ali Raza

Build failed in Jenkins: HBase-TRUNK #2344

2011-10-20 Thread Apache Jenkins Server
See Changes: [jgray] HBASE-4460 Support running an embedded ThriftServer within a RegionServer (jgray) -- [...truncated 1679 lines...] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed