Jenkins build is back to normal : HBase-0.92 #214

2011-12-29 Thread Apache Jenkins Server
See

Build failed in Jenkins: hbase-0.90 #373

2011-12-29 Thread Apache Jenkins Server
See Changes: [tedyu] HBASE-5102 Change the default value of the property "hbase.connection.per.config" to false in hbase-default.xml -- [...truncated 1227 lines...] Tests run: 3, Fai

Re: question regarding code

2011-12-29 Thread Lars H
oh no no... please file a jira and help us make HBase better. Mikael Sitruk schrieb: >Lars hi > >This method will be called anytime that old log exist and might be cleaned >(HLog.cleanOldsLogs()) and there are too much logs. >It is called from LogRoller thread, Hlog creation, and metaUtils.shutd

Re: question regarding code

2011-12-29 Thread Lars H
Yeah I think we should change it. Does not look like it's going to be called often enough to make a difference. So better readability is good :) Harsh J schrieb: >Lars, > >Yes, but that vs. unnecessary if-checks in every loop, makes it okay? >Unless these are little nitpicky worries and JVMs do

Re: question regarding code

2011-12-29 Thread Ted Yu
Mikael: I think you can go ahead and open a JIRA. Happy New Year. On Thu, Dec 29, 2011 at 4:15 PM, Mikael Sitruk wrote: > Lars hi > > This method will be called anytime that old log exist and might be cleaned > (HLog.cleanOldsLogs()) and there are too much logs. > It is called from LogRoller thr

Build failed in Jenkins: HBase-0.92 #213

2011-12-29 Thread Apache Jenkins Server
See -- [...truncated 11235 lines...] [DEBUG] commons-cli:commons-cli:jar:1.2:compile (selected for compile) [DEBUG] commons-configuration:commons-configuration:jar:1.6:compile (selected for compile) [DEBUG

Re: question regarding code

2011-12-29 Thread Harsh J
Lars, Yes, but that vs. unnecessary if-checks in every loop, makes it okay? Unless these are little nitpicky worries and JVMs do a lot better magic inside :) On Thu, Dec 29, 2011 at 10:24 PM, lars hofhansl wrote: > The only downside is that the ArrayList now is always created, even if it is > n

Build failed in Jenkins: HBase-TRUNK #2591

2011-12-29 Thread Apache Jenkins Server
See -- [...truncated 1961 lines...] Running org.apache.hadoop.hbase.client.TestHTablePool$TestHTableReusablePool Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.172 sec Running org.apache.ha

Re: question regarding code

2011-12-29 Thread Mikael Sitruk
Lars hi This method will be called anytime that old log exist and might be cleaned (HLog.cleanOldsLogs()) and there are too much logs. It is called from LogRoller thread, Hlog creation, and metaUtils.shutdown() (code in 0.90.1 - also present at least in those classes in trunk), The creation of Arr

Build failed in Jenkins: HBase-0.92 #212

2011-12-29 Thread Apache Jenkins Server
See Changes: [tedyu] HBASE-5055 Build against hadoop 0.22 broken - remove import of DFSClient.DFSInputStream (Ming Ma) [tedyu] HBASE-5103 Fix improper master znode deserialization (Jonathan Hsieh) -

Build failed in Jenkins: HBase-TRUNK #2590

2011-12-29 Thread Apache Jenkins Server
See Changes: [tedyu] HBASE-5103 Fix improper master znode deserialization (Jonathan Hsieh) -- [...truncated 1931 lines...] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.969 sec R

Re: question regarding code

2011-12-29 Thread lars hofhansl
The only downside is that the ArrayList now is always created, even if it is not needed, thereby producing unnecessary garbage. I have not bearing how frequently we'll get here and find no relevant regions, though. -- Lars - Original Message - From: Harsh J To: dev@hbase.apache.org C

Jenkins build is back to normal : HBase-TRUNK-security #54

2011-12-29 Thread Apache Jenkins Server
See

Jenkins build is back to normal : HBase-0.92-security #52

2011-12-29 Thread Apache Jenkins Server
See

Re: question regarding code

2011-12-29 Thread Mikael Sitruk
NP I'll fill it On Dec 29, 2011 10:52 AM, "Harsh J" wrote: > Yeah that'd work too. File a JIRA with the change? > > On 29-Dec-2011, at 2:12 PM, Mikael Sitruk wrote: > > > Hi all > > > > I have question on some code (taken from HLog) see below > > > > > > static byte [][] findMemstoresWithEditsEq

Re: question regarding code

2011-12-29 Thread Harsh J
Yeah that'd work too. File a JIRA with the change? On 29-Dec-2011, at 2:12 PM, Mikael Sitruk wrote: > Hi all > > I have question on some code (taken from HLog) see below > > > static byte [][] findMemstoresWithEditsEqualOrOlderThan(final long > oldestWALseqid, > final Map regionsToSeqids

question regarding code

2011-12-29 Thread Mikael Sitruk
Hi all I have question on some code (taken from HLog) see below static byte [][] findMemstoresWithEditsEqualOrOlderThan(final long oldestWALseqid, final Map regionsToSeqids) { // This method is static so it can be unit tested the easier. List regions = null; for (Map.Entry e