Re: [DISCUSS] Handling removal of deprecated methods and classes

2019-04-24 Thread Misty Linville
For features, I think we would need to understand the popularity of a given feature by our user base, and that might vary wildly by feature. Do you think it would be possible to generalize? On Wed, Apr 24, 2019 at 9:56 PM Stack wrote: > On Wed, Apr 24, 2019 at 9:04 PM Yu Li wrote: > > > ... >

Re: [DISCUSS] Handling removal of deprecated methods and classes

2019-04-24 Thread Misty Linville
I’m late on this, but I had this thought. Why not have a minimum deprecation period of, say, 6 months, after which the API is eligible for depreciation. At that point, a deprecation can be proposed on a DISCUSS thread, with plenty of time given for discussion. On Wed, Apr 24, 2019 at 9:56 PM

Re: [DISCUSS] Handling removal of deprecated methods and classes

2019-04-24 Thread Stack
On Wed, Apr 24, 2019 at 9:04 PM Yu Li wrote: > ... > Thirdly, besides API deprecation, I think we should also discuss about the > rule for feature deprecation. We ever deprecated DLR, I could observe some > discussion on deprecating preemptive fast fail recently, and personally I > think

Re: [DISCUSS] Handling removal of deprecated methods and classes

2019-04-24 Thread Stack
On Wed, Apr 24, 2019 at 7:24 PM 张铎(Duo Zhang) wrote: > Let's get a conclusion here? > > By default, we should try our best to keep the deprecated APIs for at least > a whole major release. I agree with this. Trying to message anything else would be too hard for devs and users to keep straight

Re: [DISCUSS] Handling removal of deprecated methods and classes

2019-04-24 Thread Yu Li
TL;DR: I agree with Duo's proposal, that we keep the base rule in mind but allow exceptional case with adequate discussion and fine documentation. First of all, I'd like to express my personal appreciation for the efforts spent on removing deprecated codes and bringing up the discussion.

[jira] [Created] (HBASE-22307) Deprecated Preemptive Fail Fast and remove the support in 3.0.0

2019-04-24 Thread Duo Zhang (JIRA)
Duo Zhang created HBASE-22307: - Summary: Deprecated Preemptive Fail Fast and remove the support in 3.0.0 Key: HBASE-22307 URL: https://issues.apache.org/jira/browse/HBASE-22307 Project: HBase

Re: [DISCUSS] Handling removal of deprecated methods and classes

2019-04-24 Thread Duo Zhang
Let's get a conclusion here? By default, we should try our best to keep the deprecated APIs for at least a whole major release. All committers should have this in mind, when there is patch which deprecates a public API, we should make sure that there is a @deprecated javadoc comment says on which

[jira] [Resolved] (HBASE-22215) Backport MultiRowRangeFilter does not work with reverse scans

2019-04-24 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Cang resolved HBASE-22215. - Resolution: Fixed > Backport MultiRowRangeFilter does not work with reverse scans >

[jira] [Reopened] (HBASE-22215) Backport MultiRowRangeFilter does not work with reverse scans

2019-04-24 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xu Cang reopened HBASE-22215: - > Backport MultiRowRangeFilter does not work with reverse scans >

[jira] [Created] (HBASE-22306) Improve SLB to distribute table regions across all region servers

2019-04-24 Thread Biju Nair (JIRA)
Biju Nair created HBASE-22306: - Summary: Improve SLB to distribute table regions across all region servers Key: HBASE-22306 URL: https://issues.apache.org/jira/browse/HBASE-22306 Project: HBase

[jira] [Resolved] (HBASE-22270) master's jmx.clusterRequests could be negative in branch-1

2019-04-24 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell resolved HBASE-22270. Resolution: Fixed Assignee: puleya7 Hadoop Flags: Reviewed Fix

Re: [DISCUSS] switch from "Ammending-Author" to "Co-authored-by" in commit messages

2019-04-24 Thread Andrew Purtell
I think it was me who introduced the 'Amending-Author' thing. I started tagging commits this way when I made substantial changes to get a cherry pick to apply, when I did anything more substantial than trivial changes like massaging imports. The tag implies I may be responsible for breakage, not

Re: [VOTE] HBase Connectors 1.0.0RC0

2019-04-24 Thread Sean Busbey
-1 Bad: * source artifact is missing NOTICE file * binary artifacts is missing both LICENSE and NOTICE file * maven repo artifact 'hbase-connectors-assembly' tgz is missing LICENSE and NOTICE file Good: * signatures good * checksums good * maven staged repo looks reasonable Nit: * Why are we

Re: [VOTE] The first HBase 1.3.4 release candidate (RC0) is available

2019-04-24 Thread Sean Busbey
+1 Good: * checksums, signatures * LICENSE/NOTICE * staged maven repo looks fine On Mon, Apr 15, 2019 at 4:10 AM Francis Liu wrote: > > Hi Folks, > > The first HBase 1.3.4 release candidate (RC0) is available for download at > https://dist.apache.org/repos/dist/dev/hbase/hbase-1.3.4RC0/ and

[jira] [Resolved] (HBASE-22294) Remove deprecated method from WALKeyImpl

2019-04-24 Thread Jan Hentschel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel resolved HBASE-22294. --- Resolution: Fixed Hadoop Flags: Incompatible change Release Note: Removed

[jira] [Resolved] (HBASE-22304) Fix remaining Checkstyle issues in hbase-endpoint

2019-04-24 Thread Jan Hentschel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel resolved HBASE-22304. --- Resolution: Fixed Fix Version/s: 2.2.1 2.1.5

Re: [VOTE] The first HBase 1.3.4 release candidate (RC0) is available

2019-04-24 Thread Josh Elser
+1 (binding) Sorry for the delayed vote, Francis. * xsums/sigs are OK * src release looks OK (apache-rat-check and what not) * Can build from src * Can run some tests from the src On 4/15/19 5:09 AM, Francis Liu wrote: Hi Folks, The first HBase 1.3.4 release candidate (RC0) is available for

Re: [VOTE] HBase Connectors 1.0.0RC0

2019-04-24 Thread Stack
+1 Checked signature, hash, and layout. Built from src. Ran all unit tests. Thanks for pushing on this Balazs. S [INFO] [INFO] Reactor Summary for Apache HBase Connectors 1.0.0: [INFO] [INFO] Apache HBase Connectors

Re: Need one more binding vote for 1.3.4 release candidate (RC0)

2019-04-24 Thread Francis Liu
Hi, So far this RC has only 2 binding votes, needs one more. I've extended it until friday (4/26), hopefully we can close this by then. Thanks! Francis

Re: [VOTE] The first HBase 1.3.4 release candidate (RC0) is available

2019-04-24 Thread Francis Christopher Liu
This RC still needs one more binding vote. I'm extending the deadline to until friday (4/26). Please vote. Thanks, Francis On Fri, Apr 19, 2019 at 1:12 PM Francis Christopher Liu < toffer@gmail.com> wrote: > Just a reminder need one more binding vote for this release. So far it's > mine and

[jira] [Created] (HBASE-22305) LRU Block cache may not retain recently used blocks during eviction

2019-04-24 Thread Biju Nair (JIRA)
Biju Nair created HBASE-22305: - Summary: LRU Block cache may not retain recently used blocks during eviction Key: HBASE-22305 URL: https://issues.apache.org/jira/browse/HBASE-22305 Project: HBase

[jira] [Created] (HBASE-22304) Fix remaining Checkstyle issues in hbase-endpoint

2019-04-24 Thread Jan Hentschel (JIRA)
Jan Hentschel created HBASE-22304: - Summary: Fix remaining Checkstyle issues in hbase-endpoint Key: HBASE-22304 URL: https://issues.apache.org/jira/browse/HBASE-22304 Project: HBase Issue

[jira] [Created] (HBASE-22302) Fix TestHbck

2019-04-24 Thread Duo Zhang (JIRA)
Duo Zhang created HBASE-22302: - Summary: Fix TestHbck Key: HBASE-22302 URL: https://issues.apache.org/jira/browse/HBASE-22302 Project: HBase Issue Type: Bug Components: test

[jira] [Resolved] (HBASE-22299) Documentation has incorrect default number of versions

2019-04-24 Thread Peter Somogyi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-22299. --- Resolution: Fixed Fix Version/s: 3.0.0 Merged PR#189, Thanks [~anis016] for your

Re: [DISCUSS] EOL 2.0 release line

2019-04-24 Thread OpenInx
I'v checked the issues in version 2.0.6 [1], seems no critial issues, so for me +1. 1. https://issues.apache.org/jira/issues/?jql=project%20%3D%20HBASE%20AND%20fixVersion%20%3D%202.0.6 On Wed, Apr 24, 2019 at 8:37 PM Sean Busbey wrote: > Hi folks! > > Tomorrow will be a month since the 2.0.5

[DISCUSS] EOL 2.0 release line

2019-04-24 Thread Sean Busbey
Hi folks! Tomorrow will be a month since the 2.0.5 release, which was noted: > NOTICE: We plan on this being the last release on branch-2.0 (unless critical issues found). Any objections to me doing the cleanup + announcement for formally shutting down the release line?

[jira] [Resolved] (HBASE-22272) Fix Checkstyle errors in hbase-backup

2019-04-24 Thread Jan Hentschel (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel resolved HBASE-22272. --- Resolution: Fixed Fix Version/s: 3.0.0 > Fix Checkstyle errors in hbase-backup >

The second HBase 2.2.0 release candidate (RC2) is available

2019-04-24 Thread Guanghao Zhang
Please vote on this release candidate (RC) for Apache HBase 2.2.0. This is the first release of the branch-2.2 line. The VOTE will remain open for at least 72 hours. [ ] +1 Release this package as Apache HBase 2.2.0 [ ] -1 Do not release this package because ... The tag to be voted on is

[VOTE] The second HBase 2.2.0 release candidate (RC2) is available

2019-04-24 Thread Guanghao Zhang
Please vote on this release candidate (RC) for Apache HBase 2.2.0. This is the first release of the branch-2.2 line. The VOTE will remain open for at least 72 hours. [ ] +1 Release this package as Apache HBase 2.2.0 [ ] -1 Do not release this package because ... The tag to be voted on is

[jira] [Resolved] (HBASE-22283) Print row and table information when failed to get region location

2019-04-24 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li resolved HBASE-22283. --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 1.5.1 2.2.1

[jira] [Resolved] (HBASE-22296) Remove TestFromClientSide.testGetStartEndKeysWithRegionReplicas

2019-04-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-22296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-22296. --- Resolution: Fixed Assignee: Duo Zhang Hadoop Flags: Reviewed Pushed to branch-2.2+.

Re: [DISCUSS] Handling removal of deprecated methods and classes

2019-04-24 Thread Duo Zhang
Phoenix is a good example I'd say, we have done a lot of CP related changes before releasing 2.0.0. But until now, Phoenix still has troubles to work together with 2.x, although we have already fixed several compatibility issues... It shows that, usually people will take much care on the alpha and

Re: [DISCUSS] Handling removal of deprecated methods and classes

2019-04-24 Thread Duo Zhang
You can choose to not like it but it is the truth, even now lots of users are still not want to use 2.x, just because there are not enough users already on it. You can not expect them to try out the alpha or beta version and tell you what's wrong with their production... 'Cold start' is always a