The ask of this thread was originally to change the semantics of
"signed-off-by" to only be "A committer who gave an explicit +1". That
was the ask from a community member and why I started this.
I want to tease this apart from the "reviewed-by" suggestion, as this
obviously needs a little
.
--
Best regards,
R.C
From: Jan Hentschel
Sent: 21 November 2020 19:37
To: dev@hbase.apache.org
Subject: Re: [DISCUSS] Clarifying guidance around Signed-off-by in commit
messages
Also +1 for both suggestions as long
Nice discussion here.
For my part, I am +1 for our community to define our meaning around this
aspect of metadata.
However, I don't like using both "signed-off-by" and "reviewed-by" as a
manual annotation on the part of the committer, because we as a community
don't care about the distinction
TL;DR: +1 for document rules / guidance of review trailers in commit
message, and +1 for continuing using the signed-off-by message for
"reviewed by" and/or "co-authored-by" semantic (committers only), adding
explicit preamble in the "Git best practice" chapter in our hbase book [1].
I did some
I expressly would like to see non-commiters given credit for reviews and
have made a point of including them in prior commits for signed-off-by to
do that.
I'm fine with the idea of us using some other means to indicate this, but
I'd like us to make sure there's not some already widely used bit
@hbase.apache.org
Subject: Re: [DISCUSS] Clarifying guidance around Signed-off-by in commit
messages
Also +1 for both suggestions as long as it is clear when to use which. Starting
point (after the discussion) probably would be to include it in our ref guide.
From: Wellington Chevreuil
Reply-To: &quo
ubject: Re: [DISCUSS] Clarifying guidance around Signed-off-by in commit
messages
+1 for both suggestions ('Signed-off-by' and 'Reviewed-by');
Em sáb., 21 de nov. de 2020 às 00:15, Stack
mailto:st...@duboce.net>> escreveu:
Thanks for taking the time to do a write up Josh.
Looks good to me.
W
+1 for both suggestions ('Signed-off-by' and 'Reviewed-by');
Em sáb., 21 de nov. de 2020 às 00:15, Stack escreveu:
> Thanks for taking the time to do a write up Josh.
>
> Looks good to me.
>
> When Sean started in on the 'Signed-off-by:' I didn't get it (especially
> after reading the git
Thanks for taking the time to do a write up Josh.
Looks good to me.
When Sean started in on the 'Signed-off-by:' I didn't get it (especially
after reading the git definition). Sean then set me straight explaining our
use is a bit of a perversion of the original. I notice his definition is
not in
On 11/20/20 1:07 PM, Bharath Vissapragada wrote:
* All individuals mentioned in a sign-off*must* be capable of giving a
binding vote (i.e. they are an HBase committer)
It appears that the original intent
Makes sense to me except a nit (inline).
On Fri, Nov 20, 2020 at 9:20 AM Josh Elser wrote:
> Hi!
>
> As most of you know, we've been using the "Signed-off-by:
> " line in out commit messages more and more lately to indicate
> who reviewed some change.
>
> We've recently had an event in which
Hi!
As most of you know, we've been using the "Signed-off-by:
" line in out commit messages more and more lately to indicate
who reviewed some change.
We've recently had an event in which one of these Signed-off-by lines
showed up with someone's name who didn't consider themselves to have
12 matches
Mail list logo
