Re: [DISCUSS] Disable Style/FrozenStringLiteralComment for ruby

2022-05-13 Thread Tao Li
Hi Mike, Thank you for your reply. I add `# frozen_string_literal: true` after the license header and RuboCop is not happy. I did the verification in this PR https://github.com/apache/hbase/pull/4416, you can refer to it. This comment (while no longer the default in Ruby 3) may indeed provide so

Re: [DISCUSS] Disable Style/FrozenStringLiteralComment for ruby

2022-05-13 Thread Mike Drob
On 2022/05/12 05:04:51 Tao Li wrote: > Hi team, > > By default Style/FrozenStringLiteralComment is enabled in rubocop. If we > update a ruby file, rubocop prompts `Missing frozen string literal comment` > (see > https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/2/artifact/ye

[DISCUSS] Disable Style/FrozenStringLiteralComment for ruby

2022-05-12 Thread Tao Li
Hi All, By default Style/FrozenStringLiteralComment is enabled in rubocop. If we update a ruby file, rubocop prompts `Missing frozen string literal comment` (see https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt)

[DISCUSS] Disable Style/FrozenStringLiteralComment for ruby

2022-05-11 Thread Tao Li
Hi team, By default Style/FrozenStringLiteralComment is enabled in rubocop. If we update a ruby file, rubocop prompts `Missing frozen string literal comment` (see https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt)