Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-29 Thread Duo Zhang
OK, will start the release process today. Tak Lon (Stephen) Wu 于2023年1月30日周一 12:22写道: > > Yup, HBASE-27592 will be included in RC1, and thanks for explaining again. > > Hi Duo, if possible, could you help with 2.4.16 RC? I will start traveling > and can’t have my laptop running the release build

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-29 Thread Tak Lon (Stephen) Wu
Yup, HBASE-27592 will be included in RC1, and thanks for explaining again. Hi Duo, if possible, could you help with 2.4.16 RC? I will start traveling and can’t have my laptop running the release build continuously. (At the same time, I’m looking for on-demand docker in cloud for upcoming builds, i

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-29 Thread Bryan Beaudreault
Sorry for the late reply. Stephen, I know TestRemoteRestore is not in branch-2.5. That test is what initially alerted me to the problem in HBASE-27592. The bigger problem is that any downstream users of hbase might have mismatched dependencies for hadoop-2 and hadoop's netty. Even though branch-

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-29 Thread Duo Zhang
I could help make the 2.4.16 release if no others have interest or have enough time in the following days. Thanks. Tak Lon (Stephen) Wu 于2023年1月29日周日 15:54写道: > > lol, if that's the case, I will try to do both if no one shows up. > > enjoy your trip :) > > -Stephen > > On Sat, Jan 28, 2023 at 11

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-28 Thread Tak Lon (Stephen) Wu
lol, if that's the case, I will try to do both if no one shows up. enjoy your trip :) -Stephen On Sat, Jan 28, 2023 at 11:47 PM Andrew Purtell wrote: > > I am not. When we spoke you said you wanted to try 2.5 first , maybe implying > both :-). Anyway I am heading out of the country next week s

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-28 Thread Andrew Purtell
I am not. When we spoke you said you wanted to try 2.5 first , maybe implying both :-). Anyway I am heading out of the country next week so won’t have time to do a RC before I get back, which will be the middle of February. If nobody has picked up the 2.4 RC by then sure I can do it. > On Jan

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-28 Thread Tak Lon (Stephen) Wu
I wonder if Andrew is preparing it? I can give it a try after I send the 2.5.3RC1, but maybe wait for the message from Andrew. -Stephen On Sat, Jan 28, 2023 at 10:15 PM 张铎(Duo Zhang) wrote: > Any progress on 2.4.16? > > Tak Lon (Stephen) Wu 于2023年1月26日周四 07:39写道: > > > > Hey Bryan, thanks for

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-28 Thread Duo Zhang
Any progress on 2.4.16? Tak Lon (Stephen) Wu 于2023年1月26日周四 07:39写道: > > Hey Bryan, thanks for informing me about this. > > I found the hbase-backup work isn't part of the branch-2.5 changes and > it does not have the test classes TestRemoteRestore. > > Also the nightly for branch-2.5 > https://ci

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-25 Thread Tak Lon (Stephen) Wu
Hey Bryan, thanks for informing me about this. I found the hbase-backup work isn't part of the branch-2.5 changes and it does not have the test classes TestRemoteRestore. Also the nightly for branch-2.5 https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/ is green, so IMO this is not a

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-25 Thread Bryan Beaudreault
Stephen -- I just pushed https://issues.apache.org/jira/browse/HBASE-27592 to branch-2.5. I'm not sure it needs to be a blocker for 2.5.3. I leave it to the RM's here. I noticed this issue incidentally, but our netty.hadoop.version was out of sync with our hadoop-two.version. This would cause NoS

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-24 Thread Tak Lon (Stephen) Wu
Thanks Andrew, I merged it and currently have been running the do-release-docker.sh (with -f publish) for 2+ hours, will check again tomorrow. -Stephen On Tue, Jan 24, 2023 at 5:24 PM Andrew Purtell wrote: > > Approved the PR > > On Tue, Jan 24, 2023 at 2:53 PM Tak Lon (Stephen) Wu > wrote: > >

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-24 Thread Andrew Purtell
Approved the PR On Tue, Jan 24, 2023 at 2:53 PM Tak Lon (Stephen) Wu wrote: > nvmI found the issue and it's just a duplicated test classname > causing the NullPointerException. > > filed https://issues.apache.org/jira/browse/HBASE-27589, please help > to review it. > > -Stephen > > On Tue, J

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-24 Thread Tak Lon (Stephen) Wu
nvmI found the issue and it's just a duplicated test classname causing the NullPointerException. filed https://issues.apache.org/jira/browse/HBASE-27589, please help to review it. -Stephen On Tue, Jan 24, 2023 at 2:17 PM Tak Lon (Stephen) Wu wrote: > > During the execution of publish-dist (

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-24 Thread Tak Lon (Stephen) Wu
During the execution of publish-dist (part of the do-release.sh), I found the strange problem with commit 748ec455b33d29ed007b0143efa73b7409248da7 from HBASE-27498, the test in hbase-it/src/test/java/org/apache/hadoop/hbase/client/TestConnectionImplementation.java is blocking the javadoc target tes

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-23 Thread Tak Lon (Stephen) Wu
Fyi I’m executing the release build via do-release-docker.sh, ran till the mvn site and Java doc generation. But it failed with 20:05:46 [ERROR] javadoc: error - java.lang.NullPointerException , and few error/warning for @result tag as well as @link not found for the generated proto class Blocking

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-22 Thread Andrew Purtell
Sounds good Stephen, please ping me as you need assistance. On Sat, Jan 21, 2023 at 9:32 PM Tak Lon (Stephen) Wu wrote: > Thanks Andrew and Bryan, all the blockers for branch-2.5 should have > been resolved. > > I'm running the compatibility check again, and will continue the > release tasks tom

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-21 Thread Tak Lon (Stephen) Wu
Thanks Andrew and Bryan, all the blockers for branch-2.5 should have been resolved. I'm running the compatibility check again, and will continue the release tasks tomorrow or Monday morning (PST). -Stephen On Fri, Jan 20, 2023 at 11:16 AM Bryan Beaudreault wrote: > > You probably saw, but just

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-20 Thread Bryan Beaudreault
You probably saw, but just to close the loop here -- HBASE-27579 got resolved, so no blocker there anymore. Thanks all! On Fri, Jan 20, 2023 at 12:30 PM Andrew Purtell wrote: > I think HBASE-27539 should be reverted from the releasing branches. Keeping > it in branch-2 and master would be fine,

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-20 Thread Andrew Purtell
I think HBASE-27539 should be reverted from the releasing branches. Keeping it in branch-2 and master would be fine, we do frequently change LP interface details in minor releases. It is the compatibility break in a patch release with a real affected downstream (Phoenix) that is a problem. As RM I

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-19 Thread Tak Lon (Stephen) Wu
Thanks Andrew for sharing the normal flow and helped me off this thread. I have tried steps 1 and 2, and found the following JIRAs may need a few days before closing for 2.5.3 RC. HBASE-27579 under review HBASE-27539 broke the patch version backward compatibility with StoreFileReader, pending conf

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-19 Thread Andrew Purtell
Sure. We are not rushing. Welcome to the RM club. You have commit privileges so all steps outlined below should be achievable. Let me briefly outline the steps for making a release. We can deal with details privately by email. 1. Run the compatibility checker. Verify no changes from prior rel

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-19 Thread Bryan Beaudreault
I pushed a patch for that blocker. On Wed, Jan 18, 2023 at 11:49 PM Tak Lon (Stephen) Wu wrote: > Hi Andrew, > > If we’re not rushing, I would like to help release or at least learn as a > shadow release manager how to do it end-to-end. > > I will ping you separately. > > Thanks, > Stephen > > O

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-18 Thread Tak Lon (Stephen) Wu
Hi Andrew, If we’re not rushing, I would like to help release or at least learn as a shadow release manager how to do it end-to-end. I will ping you separately. Thanks, Stephen On Wed, Jan 18, 2023 at 8:35 PM Andrew Purtell wrote: > Ok. > > > On Jan 18, 2023, at 8:28 PM, Bryan Beaudreault >

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-18 Thread Andrew Purtell
Ok. > On Jan 18, 2023, at 8:28 PM, Bryan Beaudreault > wrote: > > I just submitted a blocker jira: > https://issues.apache.org/jira/browse/HBASE-27579 > > This issue is old, not new to 2.4.x or 2.5.x. But I think we should try to > get the fix into the next patch releases, since it is data l

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-18 Thread Bryan Beaudreault
I just submitted a blocker jira: https://issues.apache.org/jira/browse/HBASE-27579 This issue is old, not new to 2.4.x or 2.5.x. But I think we should try to get the fix into the next patch releases, since it is data loss related. On Tue, Jan 17, 2023 at 5:19 PM Andrew Purtell wrote: > I've cle

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-17 Thread Andrew Purtell
I've cleaned up JIRA for fix versions 2.4.16 and 2.5.3. There is a dependabot PR to fix a warning, see HBASE-27575. When this is merged, I assume tomorrow, I'll go ahead and prepare the two releases, unless Nick you want to pick one. Just say which. On Tue, Jan 17, 2023 at 1:07 AM 张铎(Duo Zhang)

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-17 Thread Duo Zhang
Good. Thanks Nick and Andrew. Since we have two releases, I think each of you can pick one branch to release :) Anyway, let me make a new thirdparty release and bump the dependencies first, IIRC there is at least a CVE fix in netty. Thanks. Andrew Purtell 于2023年1月17日周二 03:13写道: > > I’ll be happ

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-16 Thread Andrew Purtell
I’ll be happy to run a release or both of them as needed too. > On Jan 16, 2023, at 6:44 AM, Nick Dimiduk wrote: > > On Mon, Jan 16, 2023 at 15:02 张铎(Duo Zhang) wrote: > >> If the release managers do not have enough time, do we have any volunteers? > > > I’m happy to help out as needed. >

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-16 Thread Nick Dimiduk
On Mon, Jan 16, 2023 at 15:02 张铎(Duo Zhang) wrote: > If the release managers do not have enough time, do we have any volunteers? I’m happy to help out as needed. Thanks, Nick >

Re: [DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-16 Thread Duo Zhang
Oh, typo, 2.4.15 has been released on 10.28... 张铎(Duo Zhang) 于2023年1月16日周一 22:02写道: > > HBase 2.5.2 has been released on 12.3 and 2.4.16 on 10.28, I think it > is time to roll new patch releases for these two release lines? > > If the release managers do not have enough time, do we have any volun

[DISCUSS] Time to release 2.5.3 and 2.4.16?

2023-01-16 Thread Duo Zhang
HBase 2.5.2 has been released on 12.3 and 2.4.16 on 10.28, I think it is time to roll new patch releases for these two release lines? If the release managers do not have enough time, do we have any volunteers? Thanks.