Re: [DISCUSS] Use spotless to auto format pom and java code

2022-05-11 Thread Andrew Purtell
I see on the issue that Sean indicates we have to put the credit back in the source file because it is BSD 3-clause. My mistake, I thought PB was ASL v2. On Wed, May 11, 2022 at 4:10 AM Peter Somogyi wrote: > Thanks for the suggestion, Andrew. I've added it in HBASE-27023. > > On Tue, May 10, 20

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-05-11 Thread Peter Somogyi
Thanks for the suggestion, Andrew. I've added it in HBASE-27023. On Tue, May 10, 2022 at 11:59 PM Andrew Purtell wrote: > If we credit in the NOTICE file I think it is acceptable. > > On Tue, May 10, 2022 at 8:57 AM Peter Somogyi wrote: > > > I noticed that the spotless license formatting remov

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-05-10 Thread tom lee
Thanks for all your reply. 张铎(Duo Zhang) 于2022年5月11日周三 10:37写道: > The spotless error is on the master branch, your PR has fixed the error. > > tom lee 于2022年5月11日周三 00:13写道: > > > I found some spotless warn, so I repaired them by running "mvn > > spotless:apply". > > > > Then I executed "mvn sp

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-05-10 Thread Duo Zhang
The spotless error is on the master branch, your PR has fixed the error. tom lee 于2022年5月11日周三 00:13写道: > I found some spotless warn, so I repaired them by running "mvn > spotless:apply". > > Then I executed "mvn spotless:check" locally, and the build succeeded, but > there were still spotless w

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-05-10 Thread Andrew Purtell
If we credit in the NOTICE file I think it is acceptable. On Tue, May 10, 2022 at 8:57 AM Peter Somogyi wrote: > I noticed that the spotless license formatting removed some of the license > extensions where the origin of the code was mentioned, credited. > One example is AbstractByteRange [1] wh

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-05-10 Thread tom lee
I found some spotless warn, so I repaired them by running "mvn spotless:apply". Then I executed "mvn spotless:check" locally, and the build succeeded, but there were still spotless warn after submitting PR https://github.com/apache/hbase/pull/4417. I just found this discussion, so before the end

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-05-10 Thread Peter Somogyi
I noticed that the spotless license formatting removed some of the license extensions where the origin of the code was mentioned, credited. One example is AbstractByteRange [1] which is from Protobuf. Are we fine with these removals? Can someone comment on this who is more familiar with licensing

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-05-02 Thread Nick Dimiduk
Ah! Pay heed to the version of the spotless plugin. There was a version upgrade between what was in the pom file on my feature branch vs. on the target branch. On Mon, May 2, 2022 at 4:21 PM Nick Dimiduk wrote: > Now that spotless has landed, here's something to help you get your > outstanding P

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-05-02 Thread Nick Dimiduk
Now that spotless has landed, here's something to help you get your outstanding PRs over the hump. It's not perfect, but maybe it'll help you. First, get the latest upstream changes and apply the latest spotless configuration to your working branch, $ git fetch origin $targetbranch $ git checko

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-04-26 Thread Nick Dimiduk
+1 for Duo's bump here -- let's bring this home! On Tue, Apr 26, 2022 at 4:08 PM 张铎(Duo Zhang) wrote: > Just a reminder that some of us have almost reached a consensus on the > final formatter config file. > > PTAL about the discussion and also the final style in this PR > https://github.com/apa

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-04-26 Thread Duo Zhang
Just a reminder that some of us have almost reached a consensus on the final formatter config file. PTAL about the discussion and also the final style in this PR https://github.com/apache/hbase/pull/4312 We have also talked about whether we should just use some well known styles such as google ja

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-04-12 Thread Duo Zhang
Some heads up, the current state on the big reformat can be reviewed here https://github.com/apache/hbase/pull/4312 Shout if you have any questions about the formatter, we could try to tweak the eclipse formatter to see if it could work as expected. Thanks. Andrew Purtell 于2022年4月3日周日 02:34写道:

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-04-02 Thread Andrew Purtell
I think we have consensus to move forward with application of the PRs, so let's fine tune the formatting configuration, and then regenerate and apply them. On Thu, Mar 31, 2022 at 11:03 PM 张铎(Duo Zhang) wrote: > FWIW, you could do a 'git reset --hard' to the commit before the big > reformat and

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-03-31 Thread Duo Zhang
FWIW, you could do a 'git reset --hard' to the commit before the big reformat and do a 'git blame' again on command line. Nick Dimiduk 于2022年4月1日周五 13:58写道: > I noticed that GitHub’s blame UI has a “show before this commit” feature, > which allowed me to look at the blame info before the reforma

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-03-31 Thread Nick Dimiduk
I noticed that GitHub’s blame UI has a “show before this commit” feature, which allowed me to look at the blame info before the reformat was applied. I assume the same is possible on the command line. On Fri, Apr 1, 2022 at 04:06 张铎(Duo Zhang) wrote: > +1 > > Andrew Purtell 于2022年4月1日周五 06:18写道

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-03-31 Thread Duo Zhang
+1 Andrew Purtell 于2022年4月1日周五 06:18写道: > Now that I understand what 'ratchetFrom' in the plugin configuration was > doing, I have removed it, and resubmitted the PRs. They are all ridiculous > and expected. Just about every file in the source is touched. On master > branch 4679 files are modifi

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-03-31 Thread Andrew Purtell
Now that I understand what 'ratchetFrom' in the plugin configuration was doing, I have removed it, and resubmitted the PRs. They are all ridiculous and expected. Just about every file in the source is touched. On master branch 4679 files are modified out of 5507 (excluding .git/). There are similar

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-03-28 Thread Andrew Purtell
Yes, I figure we should run spotless on all live branch-2x branches to get a baseline for future contributions and backports. On Mon, Mar 28, 2022 at 6:50 PM 张铎(Duo Zhang) wrote: > I’m natural on this. We could remove the ratchetFrom config and do a full > reformat on all branches. The problem i

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-03-28 Thread Duo Zhang
I’m natural on this. We could remove the ratchetFrom config and do a full reformat on all branches. The problem is git blame will be useless… But anyway, if the file has been touched later, git blame will be broken too. I saw Andrew has already opened a PR. Let’s get it done. Thanks. Bryan Beau

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-03-28 Thread Bryan Beaudreault
Thanks for your work here Duo! What should be our convention on committing unrelated formatting changes due to spotless? For example, I have a PR https://github.com/apache/hbase/pull/4180 open. I rebased it on latest master to pull in spotless and ran `mvn spotless:apply` as suggested. As you said

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-03-28 Thread Duo Zhang
Thanks all for chimming in. HBASE-26617 has been resolved and the patch has been committed to branch-2.5+. Will start to work on HBASE-26892 to integrate spotless check in our pre commit build. Bryan Beaudreault 于2022年3月26日周六 02:35写道: > +1, agreed. It would be nice to backport to branch-2 as we

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-03-25 Thread Bryan Beaudreault
+1, agreed. It would be nice to backport to branch-2 as well so we can keep the branches somewhat consistent in style at least. On Fri, Mar 25, 2022 at 2:05 PM Huaxiang Sun wrote: > +1, a very nice and helpful feature. > > > > On 2022/03/25 04:04:31 "张铎(Duo Zhang)" wrote: > > Revive. > > > > Wil

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-03-25 Thread Huaxiang Sun
+1, a very nice and helpful feature. On 2022/03/25 04:04:31 "张铎(Duo Zhang)" wrote: > Revive. > > Will wait for another couple of days, if no big objections, I will move > forward to integrate spotless into our active branches. > > Thanks. > > 张铎(Duo Zhang) 于2022年3月15日周二 21:17写道: > > > I've

Re: [DISCUSS] Use spotless to auto format pom and java code

2022-03-24 Thread Duo Zhang
Revive. Will wait for another couple of days, if no big objections, I will move forward to integrate spotless into our active branches. Thanks. 张铎(Duo Zhang) 于2022年3月15日周二 21:17写道: > I've filed HBASE-26617 a while ago and recently I implemented a PR for > master branch. > > https://github.com/

[DISCUSS] Use spotless to auto format pom and java code

2022-03-15 Thread Duo Zhang
I've filed HBASE-26617 a while ago and recently I implemented a PR for master branch. https://github.com/apache/hbase/pull/4214 The PR is a bit large because it will also format the pom, the actual changes are here https://github.com/apache/hbase/pull/4214/files#diff-9c5fb3d1b7e3b0f54bc5c4182965