With 3 binding +1 votes (Josh, Stack, Peter) this vote passes.
Thanks everyone who participated in the vote.
Best regards,
Balazs
On Thu, May 2, 2019 at 3:14 PM Sean Busbey wrote:
> On Thu, May 2, 2019, 04:38 Balazs Meszaros
> wrote:
>
> >
> > > * We get the ${project.basedir} in the local
On Thu, May 2, 2019, 04:38 Balazs Meszaros
wrote:
>
> > * We get the ${project.basedir} in the local copy when building because
> of the HBase dep of 2.1.0 doesn't have HBASE-21005. Do we want to choose
> the latest 2.1.x?
>
> I do not know the answer for that. We can depend on the latest HBase
> * Binary release's LICENSE file is missing some stuff. e.g. we bundle
jcodings which is MIT licensed but that is not included in LICENSE. IMO,
we can come back and fix these for the next release.
HBASE-22338 is filed. (Thanks Peter)
> * We get the ${project.basedir} in the local copy when
+1
signatures, checksums: OK
build from source: OK (Oracle 1.8.0_171, Maven 3.6.1)
Apache rat check: OK
Unit / IT tests: OK
Filed issues for Josh's and Artem's findings:
HBASE-22336
HBASE-22337
HBASE-22338
On Mon, Apr 29, 2019 at 7:07 PM Artem Ervits wrote:
> +1 (non-binding)
>
> signatures
+1 (non-binding)
signatures and sums for src: OK
signatures and sums for bin: OK
compile from src: OpenJDK 1.8.0_212-b04: OK
UTs: OK
ITs: OK
Ratcheck: OK
Additionally, the following nits found during review:
${project.basedir} is in the root of the project after compile
after build,
+1 (non-binding)
- Checked signature, checksum
- Built from source
- Ran all unit / integration tests
I did not run tests with Kafka / Spark.
Regards,
Andor
On Sat, Apr 27, 2019 at 9:39 PM Stack wrote:
> +1
>
> Sig, hash, license, rat, and build from src all good (I see same detritus
> as
+1
Sig, hash, license, rat, and build from src all good (I see same detritus
as our Josh reports).
Thanks Balazs,
S
On Fri, Apr 26, 2019 at 6:02 AM Balazs Meszaros
wrote:
> Please vote on this Apache HBase Connectors release candidate.
>
> The release files including signatures can be found
+1 (binding)
* xsums/sigs good
* KEYS up to date
* Can build/test from src
* L good for src
Nits:
* Binary release's LICENSE file is missing some stuff. e.g. we bundle
jcodings which is MIT licensed but that is not included in LICENSE. IMO,
we can come back and fix these for the next
Please vote on this Apache HBase Connectors release candidate.
The release files including signatures can be found at:
http://home.apache.org/~meszibalu/hbase-connectors-1.0.0RC1/
and maven artifacts are available here:
https://repository.apache.org/content/repositories/orgapachehbase-1307/
